ppc/pnv: use stack->pci_regs[] in pnv_pec_stk_pci_xscom_write()

[PATCH 0/1] ppc/pnv: use stack->pci_regs[] in pnv_pec_stk_pci_xscom_write()

Daniel Henrique Barboza posted 1 patch 2 years, 3 months ago

Download series mbox

Failed in applying to current master (apply log)

hw/pci-host/pnv_phb4.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

Expand all Fold all

[PATCH 0/1] ppc/pnv: use stack->pci_regs[] in pnv_pec_stk_pci_xscom_write()

Posted by Daniel Henrique Barboza 2 years, 3 months ago

Hi,

This is something that caught my eye when I was looking into the
instances where we need stack properties versus phb4 properties.

I tested this fix and it doesn't seem to impact the boot process
whatsoever. Tracing pnv_pec_stk_pci_xscom_write() shows that the writes
are being done at early boot and then nothing else. There might be a
future bug that we're fixing beforehand with this patch as well.

At the very least the code now makes more sense, at least in my
estimation.

Daniel Henrique Barboza (1):
  ppc/pnv: use stack->pci_regs[] in pnv_pec_stk_pci_xscom_write()

 hw/pci-host/pnv_phb4.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

-- 
2.33.1

Re: [PATCH 0/1] ppc/pnv: use stack->pci_regs[] in pnv_pec_stk_pci_xscom_write()

Posted by Cédric Le Goater 2 years, 3 months ago

On 1/11/22 21:01, Daniel Henrique Barboza wrote:
> Hi,
> 
> This is something that caught my eye when I was looking into the
> instances where we need stack properties versus phb4 properties.
> 
> I tested this fix and it doesn't seem to impact the boot process
> whatsoever. Tracing pnv_pec_stk_pci_xscom_write() shows that the writes
> are being done at early boot and then nothing else. There might be a
> future bug that we're fixing beforehand with this patch as well.
> 
> At the very least the code now makes more sense, at least in my
> estimation.
> 
> Daniel Henrique Barboza (1):
>    ppc/pnv: use stack->pci_regs[] in pnv_pec_stk_pci_xscom_write()
> 
>   hw/pci-host/pnv_phb4.c | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
> 


Applied to ppc7.0.

Thanks,

C.