[PATCH 3/8] hw/pci: Document pci_dma_map()

Philippe Mathieu-Daudé posted 8 patches 4 years, 1 month ago
There is a newer version of this series
[PATCH 3/8] hw/pci: Document pci_dma_map()
Posted by Philippe Mathieu-Daudé 4 years, 1 month ago
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 include/hw/pci/pci.h | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 5b36334a28a..f0d707efb8c 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -876,6 +876,18 @@ PCI_DMA_DEFINE_LDST(q_be, q_be, 64);
 
 #undef PCI_DMA_DEFINE_LDST
 
+/**
+ * pci_dma_map: Map a physical memory region into a device PCI address space.
+ *
+ * May map a subset of the requested range, given by and returned in @plen.
+ * May return %NULL and set *@plen to zero(0), if resources needed to perform
+ * the mapping are exhausted.
+ *
+ * @dev: #PCIDevice to be accessed
+ * @addr: address within that device's address space
+ * @plen: pointer to length of buffer; updated on return
+ * @dir: indicates the transfer direction
+ */
 static inline void *pci_dma_map(PCIDevice *dev, dma_addr_t addr,
                                 dma_addr_t *plen, DMADirection dir)
 {
-- 
2.33.1

Re: [PATCH 3/8] hw/pci: Document pci_dma_map()
Posted by Peter Xu 4 years, 1 month ago
On Fri, Dec 31, 2021 at 12:48:56PM +0100, Philippe Mathieu-Daudé wrote:
> +/**
> + * pci_dma_map: Map a physical memory region into a device PCI address space.

Shouldn't this be: "Map device PCI address space range into host virtual
address"?

-- 
Peter Xu


Re: [PATCH 3/8] hw/pci: Document pci_dma_map()
Posted by Philippe Mathieu-Daudé 4 years, 1 month ago
On Tue, Jan 4, 2022 at 8:27 AM Peter Xu <peterx@redhat.com> wrote:
>
> On Fri, Dec 31, 2021 at 12:48:56PM +0100, Philippe Mathieu-Daudé wrote:
> > +/**
> > + * pci_dma_map: Map a physical memory region into a device PCI address space.
>
> Shouldn't this be: "Map device PCI address space range into host virtual
> address"?

Yes, certainly... Thank you!