tests/tcg: Fix float_{convs,madds}

[PATCH 0/2] tests/tcg: Fix float_{convs,madds}

Richard Henderson posted 2 patches 2 years, 4 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211224035541.2159966-1-richard.henderson@linaro.org

Maintainers: Taylor Simpson <tsimpson@quicinc.com>, "Alex Bennée" <alex.bennee@linaro.org>

tests/tcg/multiarch/float_convs.c |   2 +-
tests/tcg/multiarch/float_madds.c |   2 +-
tests/tcg/hexagon/float_convs.ref | 152 +++---
tests/tcg/hexagon/float_madds.ref |  48 +-
tests/tcg/ppc64le/float_convs.ref | 748 +++++++++++++++++++++++++++++
tests/tcg/ppc64le/float_madds.ref | 768 ++++++++++++++++++++++++++++++
6 files changed, 1618 insertions(+), 102 deletions(-)
create mode 100644 tests/tcg/ppc64le/float_convs.ref
create mode 100644 tests/tcg/ppc64le/float_madds.ref

Expand all Fold all

[PATCH 0/2] tests/tcg: Fix float_{convs,madds}

Posted by Richard Henderson 2 years, 4 months ago

We didn't read the fp flags early enough, so we got whatever
came out of the guest printf.  With careful review of the
hexagon output, we would have seen this long ago.


r~


Richard Henderson (2):
  tests/tcg/multiarch: Read fp flags before printf
  test/tcg/ppc64le: Add float reference files

 tests/tcg/multiarch/float_convs.c |   2 +-
 tests/tcg/multiarch/float_madds.c |   2 +-
 tests/tcg/hexagon/float_convs.ref | 152 +++---
 tests/tcg/hexagon/float_madds.ref |  48 +-
 tests/tcg/ppc64le/float_convs.ref | 748 +++++++++++++++++++++++++++++
 tests/tcg/ppc64le/float_madds.ref | 768 ++++++++++++++++++++++++++++++
 6 files changed, 1618 insertions(+), 102 deletions(-)
 create mode 100644 tests/tcg/ppc64le/float_convs.ref
 create mode 100644 tests/tcg/ppc64le/float_madds.ref

-- 
2.25.1

Re: [PATCH 0/2] tests/tcg: Fix float_{convs,madds}

Posted by Alex Bennée 2 years, 4 months ago

Richard Henderson <richard.henderson@linaro.org> writes:

> We didn't read the fp flags early enough, so we got whatever
> came out of the guest printf.  With careful review of the
> hexagon output, we would have seen this long ago.

Queued to testing/next, thanks.

-- 
Alex Bennée