ui/dbus: fix buffer-overflow detected by ASAN

[PATCH] ui/dbus: fix buffer-overflow detected by ASAN

Posted by marcandre.lureau@redhat.com 2 years, 4 months ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

On the last added dbus patch, I left a tiny BO:

==441487==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x611000025a70 at pc 0x7f0817bb764c bp 0x7ffde672ae60 sp 0x7ffde672ae58
WRITE of size 8 at 0x611000025a70 thread T0
    #0 0x7f0817bb764b in dbus_vc_class_init ../ui/dbus.c:401

A cookie for ASAN! not you C :)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 ui/dbus.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/dbus.c b/ui/dbus.c
index b2c1c9fb522c..0074424c1fed 100644
--- a/ui/dbus.c
+++ b/ui/dbus.c
@@ -405,6 +405,7 @@ dbus_vc_class_init(ObjectClass *oc, void *data)
 static const TypeInfo dbus_vc_type_info = {
     .name = TYPE_CHARDEV_VC,
     .parent = TYPE_CHARDEV_DBUS,
+    .class_size = sizeof(DBusVCClass),
     .class_init = dbus_vc_class_init,
 };
 
-- 
2.34.1.8.g35151cf07204

Re: [PATCH] ui/dbus: fix buffer-overflow detected by ASAN

Posted by Philippe Mathieu-Daudé 2 years, 4 months ago

On 12/22/21 15:40, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> On the last added dbus patch, I left a tiny BO:
> 
> ==441487==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x611000025a70 at pc 0x7f0817bb764c bp 0x7ffde672ae60 sp 0x7ffde672ae58
> WRITE of size 8 at 0x611000025a70 thread T0
>     #0 0x7f0817bb764b in dbus_vc_class_init ../ui/dbus.c:401
> 
> A cookie for ASAN! not you C :)
> 

Fixes: 7f767ca35e5 ("ui/dbus: register D-Bus VC handler")
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  ui/dbus.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ui/dbus.c b/ui/dbus.c
> index b2c1c9fb522c..0074424c1fed 100644
> --- a/ui/dbus.c
> +++ b/ui/dbus.c
> @@ -405,6 +405,7 @@ dbus_vc_class_init(ObjectClass *oc, void *data)
>  static const TypeInfo dbus_vc_type_info = {
>      .name = TYPE_CHARDEV_VC,
>      .parent = TYPE_CHARDEV_DBUS,
> +    .class_size = sizeof(DBusVCClass),
>      .class_init = dbus_vc_class_init,
>  };
>