[PATCH qemu master] hw/misc/aspeed_pwm: fix typo

Troy Lee posted 1 patch 2 years, 4 months ago
Failed in applying to current master (apply log)
hw/misc/aspeed_pwm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH qemu master] hw/misc/aspeed_pwm: fix typo
Posted by Troy Lee 2 years, 4 months ago
Typo found during developing.

Fixes: 70b3f1a34d3c ("hw/misc: Add basic Aspeed PWM model")
Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
---
 hw/misc/aspeed_pwm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/misc/aspeed_pwm.c b/hw/misc/aspeed_pwm.c
index 8ebab5dcef..dbf9634da3 100644
--- a/hw/misc/aspeed_pwm.c
+++ b/hw/misc/aspeed_pwm.c
@@ -96,7 +96,7 @@ static void aspeed_pwm_class_init(ObjectClass *klass, void *data)
 
     dc->realize = aspeed_pwm_realize;
     dc->reset = aspeed_pwm_reset;
-    dc->desc = "Aspeed PWM Controller",
+    dc->desc = "Aspeed PWM Controller";
     dc->vmsd = &vmstate_aspeed_pwm;
 }
 
-- 
2.25.1


Re: [PATCH qemu master] hw/misc/aspeed_pwm: fix typo
Posted by Philippe Mathieu-Daudé 2 years, 4 months ago
On 12/22/21 11:24, Troy Lee wrote:
> Typo found during developing.
> 
> Fixes: 70b3f1a34d3c ("hw/misc: Add basic Aspeed PWM model")
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> ---
>  hw/misc/aspeed_pwm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/misc/aspeed_pwm.c b/hw/misc/aspeed_pwm.c
> index 8ebab5dcef..dbf9634da3 100644
> --- a/hw/misc/aspeed_pwm.c
> +++ b/hw/misc/aspeed_pwm.c
> @@ -96,7 +96,7 @@ static void aspeed_pwm_class_init(ObjectClass *klass, void *data)
>  
>      dc->realize = aspeed_pwm_realize;
>      dc->reset = aspeed_pwm_reset;
> -    dc->desc = "Aspeed PWM Controller",
> +    dc->desc = "Aspeed PWM Controller";
>      dc->vmsd = &vmstate_aspeed_pwm;
>  }
>  

No need for another patch, since it doesn't build.
Simply squash it in your commit 70b3f1a34d3c.


Re: [PATCH qemu master] hw/misc/aspeed_pwm: fix typo
Posted by Cédric Le Goater 2 years, 4 months ago
Hello Troy Lee,

On 12/22/21 11:24, Troy Lee wrote:
> Typo found during developing.
> 
> Fixes: 70b3f1a34d3c ("hw/misc: Add basic Aspeed PWM model")

PWM is not upstream. I will include the fix in a new aspeed-7.0 branch.

Thanks,

C.



> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> ---
>   hw/misc/aspeed_pwm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/misc/aspeed_pwm.c b/hw/misc/aspeed_pwm.c
> index 8ebab5dcef..dbf9634da3 100644
> --- a/hw/misc/aspeed_pwm.c
> +++ b/hw/misc/aspeed_pwm.c
> @@ -96,7 +96,7 @@ static void aspeed_pwm_class_init(ObjectClass *klass, void *data)
>   
>       dc->realize = aspeed_pwm_realize;
>       dc->reset = aspeed_pwm_reset;
> -    dc->desc = "Aspeed PWM Controller",
> +    dc->desc = "Aspeed PWM Controller";
>       dc->vmsd = &vmstate_aspeed_pwm;
>   }
>   
>