tests/qtest/boot-serial-test: Silence the warning about deprecated sga device

[PATCH] tests/qtest/boot-serial-test: Silence the warning about deprecated sga device

Thomas Huth posted 1 patch 2 years, 4 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211220164042.397028-1-thuth@redhat.com

Maintainers: Laurent Vivier <lvivier@redhat.com>, Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

tests/qtest/boot-serial-test.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH] tests/qtest/boot-serial-test: Silence the warning about deprecated sga device

Posted by Thomas Huth 2 years, 4 months ago

When running the qtests, there are currently a bunch of warnings about
the deprecated sga device during the boot-serial-test. Switch to
"-M graphics=off" to silence these warnings.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/boot-serial-test.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/tests/qtest/boot-serial-test.c b/tests/qtest/boot-serial-test.c
index 4d8e1343bd..d72a82d629 100644
--- a/tests/qtest/boot-serial-test.c
+++ b/tests/qtest/boot-serial-test.c
@@ -157,11 +157,11 @@ static testdef_t tests[] = {
     { "ppc64", "powernv8", "", "OPAL" },
     { "ppc64", "powernv9", "", "OPAL" },
     { "ppc64", "sam460ex", "-device e1000", "8086  100e" },
-    { "i386", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
-    { "i386", "pc", "-device sga", "SGABIOS" },
-    { "i386", "q35", "-device sga", "SGABIOS" },
-    { "x86_64", "isapc", "-cpu qemu32 -device sga", "SGABIOS" },
-    { "x86_64", "q35", "-device sga", "SGABIOS" },
+    { "i386", "isapc", "-cpu qemu32 -M graphics=off", "SeaBIOS" },
+    { "i386", "pc", "-M graphics=off", "SeaBIOS" },
+    { "i386", "q35", "-M graphics=off", "SeaBIOS" },
+    { "x86_64", "isapc", "-cpu qemu32 -M graphics=off", "SeaBIOS" },
+    { "x86_64", "q35", "-M graphics=off", "SeaBIOS" },
     { "sparc", "LX", "", "TMS390S10" },
     { "sparc", "SS-4", "", "MB86904" },
     { "sparc", "SS-600MP", "", "TMS390Z55" },
-- 
2.27.0

Re: [PATCH] tests/qtest/boot-serial-test: Silence the warning about deprecated sga device

Posted by Richard Henderson 2 years, 4 months ago

On 12/20/21 8:40 AM, Thomas Huth wrote:
> When running the qtests, there are currently a bunch of warnings about
> the deprecated sga device during the boot-serial-test. Switch to
> "-M graphics=off" to silence these warnings.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/qtest/boot-serial-test.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] tests/qtest/boot-serial-test: Silence the warning about deprecated sga device

Posted by Philippe Mathieu-Daudé 2 years, 4 months ago

On 12/20/21 17:40, Thomas Huth wrote:
> When running the qtests, there are currently a bunch of warnings about
> the deprecated sga device during the boot-serial-test. Switch to
> "-M graphics=off" to silence these warnings.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qtest/boot-serial-test.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>