[v6] tests/unit: Rework test-smp-parse tests

[PATCH v6 0/8] tests/unit: Rework test-smp-parse tests

Philippe Mathieu-Daudé posted 8 patches 2 years, 4 months ago

Diff against v1 v2 v3 v4 v5
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211216132015.815493-1-philmd@redhat.com

include/hw/boards.h         |   3 +-
hw/core/machine-smp.c       |   6 +-
hw/core/machine.c           |   2 +-
tests/unit/test-smp-parse.c | 181 +++++++++++++++++++++++-------------
4 files changed, 121 insertions(+), 71 deletions(-)

Expand all Fold all

[PATCH v6 0/8] tests/unit: Rework test-smp-parse tests

Posted by Philippe Mathieu-Daudé 2 years, 4 months ago

Since v5:
- Adapt test class names (Yanan Wang)

Since v4:
- Rebase (skipping merged patches)
- Renamed tests (Yanan Wang)

Since v2:
- Restore 'dies_supported' field in test_with_dies (Yanan)
- Add R-b tags
- QOM-ify the TYPE_MACHINE classes

Supersedes: <20211115145900.2531865-1-philmd@redhat.com>

Philippe Mathieu-Daudé (8):
  tests/unit/test-smp-parse: Pass machine type as argument to tests
  tests/unit/test-smp-parse: Split the 'generic' test in valid / invalid
  tests/unit/test-smp-parse: Add 'smp-with-dies' machine type
  tests/unit/test-smp-parse: Add 'smp-generic-invalid' machine type
  tests/unit/test-smp-parse: Add 'smp-generic-valid' machine type
  tests/unit/test-smp-parse: Simplify pointer to compound literal use
  tests/unit/test-smp-parse: Constify some pointer/struct
  hw/core: Rename smp_parse() -> machine_parse_smp_config()

 include/hw/boards.h         |   3 +-
 hw/core/machine-smp.c       |   6 +-
 hw/core/machine.c           |   2 +-
 tests/unit/test-smp-parse.c | 181 +++++++++++++++++++++++-------------
 4 files changed, 121 insertions(+), 71 deletions(-)

-- 
2.33.1

Re: [PATCH v6 0/8] tests/unit: Rework test-smp-parse tests

Posted by Philippe Mathieu-Daudé 2 years, 3 months ago

> Philippe Mathieu-Daudé (8):
>   tests/unit/test-smp-parse: Pass machine type as argument to tests
>   tests/unit/test-smp-parse: Split the 'generic' test in valid / invalid
>   tests/unit/test-smp-parse: Add 'smp-with-dies' machine type
>   tests/unit/test-smp-parse: Add 'smp-generic-invalid' machine type
>   tests/unit/test-smp-parse: Add 'smp-generic-valid' machine type
>   tests/unit/test-smp-parse: Simplify pointer to compound literal use
>   tests/unit/test-smp-parse: Constify some pointer/struct
>   hw/core: Rename smp_parse() -> machine_parse_smp_config()

Series queued to machine-next.