[PATCH] gitlab-ci: Speed up the msys2-64bit job by using --without-default-devices

Thomas Huth posted 1 patch 2 years, 4 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211216082253.43899-1-thuth@redhat.com
Maintainers: Thomas Huth <thuth@redhat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, "Alex Bennée" <alex.bennee@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, Beraldo Leal <bleal@redhat.com>
.gitlab-ci.d/windows.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] gitlab-ci: Speed up the msys2-64bit job by using --without-default-devices
Posted by Thomas Huth 2 years, 4 months ago
The new msys2-64bit job is often running for more than 50 minutes - and
if the CI is currently loaded, it times out after 60 minutes. The job
has been declared with a bigger timeout, but seems like this is getting
ignored on the shared Gitlab-CI Windows runners, so we're currently
seeing a lot of failures with this job. Thus we have to reduce the time
it takes to finish this job. Since we want to test compiling the WHPX
and HAX accelerator code with this job, switching to another target CPU
is not really a good option, so let's reduce the amount of code that we
have to compile with the --without-default-devices switch instead.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.d/windows.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/windows.yml b/.gitlab-ci.d/windows.yml
index 309f7e7fb8..62dd9ed832 100644
--- a/.gitlab-ci.d/windows.yml
+++ b/.gitlab-ci.d/windows.yml
@@ -58,7 +58,7 @@ msys2-64bit:
   - $env:CHERE_INVOKING = 'yes'  # Preserve the current working directory
   - $env:MSYSTEM = 'MINGW64'     # Start a 64 bit Mingw environment
   - .\msys64\usr\bin\bash -lc './configure --target-list=x86_64-softmmu
-      --enable-capstone=system'
+      --enable-capstone=system --without-default-devices'
   - .\msys64\usr\bin\bash -lc "sed -i '/^ROMS=/d' build/config-host.mak"
   - .\msys64\usr\bin\bash -lc 'make -j2'
   - .\msys64\usr\bin\bash -lc 'make check'
-- 
2.27.0


Re: [PATCH] gitlab-ci: Speed up the msys2-64bit job by using --without-default-devices
Posted by Philippe Mathieu-Daudé 2 years, 4 months ago
On 12/16/21 09:22, Thomas Huth wrote:
> The new msys2-64bit job is often running for more than 50 minutes - and
> if the CI is currently loaded, it times out after 60 minutes. The job
> has been declared with a bigger timeout, but seems like this is getting
> ignored on the shared Gitlab-CI Windows runners, so we're currently
> seeing a lot of failures with this job. Thus we have to reduce the time
> it takes to finish this job. Since we want to test compiling the WHPX
> and HAX accelerator code with this job, switching to another target CPU
> is not really a good option, so let's reduce the amount of code that we
> have to compile with the --without-default-devices switch instead.

Good idea!

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .gitlab-ci.d/windows.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)