[v2] Python: delete synchronous qemu.qmp package

[PATCH v2 06/25] python/qemu-ga-client: update instructions to newer CLI syntax

Posted by John Snow 4 years ago

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/qemu/qmp/qemu_ga_client.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/qemu/qmp/qemu_ga_client.py b/python/qemu/qmp/qemu_ga_client.py
index 67ac0b4211..b3e1d98c9e 100644
--- a/python/qemu/qmp/qemu_ga_client.py
+++ b/python/qemu/qmp/qemu_ga_client.py
@@ -5,7 +5,7 @@
 
 Start QEMU with:
 
-# qemu [...] -chardev socket,path=/tmp/qga.sock,server,wait=off,id=qga0 \
+# qemu [...] -chardev socket,path=/tmp/qga.sock,server=on,wait=off,id=qga0 \
   -device virtio-serial \
   -device virtserialport,chardev=qga0,name=org.qemu.guest_agent.0
 
-- 
2.31.1

Re: [PATCH v2 06/25] python/qemu-ga-client: update instructions to newer CLI syntax

Posted by Daniel P. Berrangé 4 years ago

On Wed, Dec 15, 2021 at 02:39:20PM -0500, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/qemu/qmp/qemu_ga_client.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [PATCH v2 06/25] python/qemu-ga-client: update instructions to newer CLI syntax

Posted by Vladimir Sementsov-Ogievskiy 4 years ago

I had to search a bit through the history to check this )

The commit ccd3b3b8112b670f "qemu-option: warn for short-form boolean options" may be noted here.

And may be subject changed to "don't use deprecated syntax in comment" or something like this. server=on is not a *new* syntax I think.

15.12.2021 22:39, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

> ---
>   python/qemu/qmp/qemu_ga_client.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/python/qemu/qmp/qemu_ga_client.py b/python/qemu/qmp/qemu_ga_client.py
> index 67ac0b4211..b3e1d98c9e 100644
> --- a/python/qemu/qmp/qemu_ga_client.py
> +++ b/python/qemu/qmp/qemu_ga_client.py
> @@ -5,7 +5,7 @@
>   
>   Start QEMU with:
>   
> -# qemu [...] -chardev socket,path=/tmp/qga.sock,server,wait=off,id=qga0 \
> +# qemu [...] -chardev socket,path=/tmp/qga.sock,server=on,wait=off,id=qga0 \
>     -device virtio-serial \
>     -device virtserialport,chardev=qga0,name=org.qemu.guest_agent.0
>   
> 


-- 
Best regards,
Vladimir

Re: [PATCH v2 06/25] python/qemu-ga-client: update instructions to newer CLI syntax

Posted by John Snow 4 years ago

On Thu, Dec 16, 2021 at 5:14 AM Vladimir Sementsov-Ogievskiy <
vsementsov@virtuozzo.com> wrote:

> I had to search a bit through the history to check this )
>
> The commit ccd3b3b8112b670f "qemu-option: warn for short-form boolean
> options" may be noted here.
>
> And may be subject changed to "don't use deprecated syntax in comment" or
> something like this. server=on is not a *new* syntax I think.
>
>
Fair. I've updated the commit message.


> 15.12.2021 22:39, John Snow wrote:
> > Signed-off-by: John Snow <jsnow@redhat.com>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>
>
Thanks!