[v2] Python: delete synchronous qemu.qmp package

[PATCH v2 04/25] python/aqmp: add SocketAddrT to package root

Posted by John Snow 4 years ago

It's a commonly needed definition, it can be re-exported by the root.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 python/qemu/aqmp/__init__.py | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py
index 880d5b6fa7..c6fa2dda58 100644
--- a/python/qemu/aqmp/__init__.py
+++ b/python/qemu/aqmp/__init__.py
@@ -26,7 +26,12 @@
 from .error import AQMPError
 from .events import EventListener
 from .message import Message
-from .protocol import ConnectError, Runstate, StateError
+from .protocol import (
+    ConnectError,
+    Runstate,
+    SocketAddrT,
+    StateError,
+)
 from .qmp_client import ExecInterruptedError, ExecuteError, QMPClient
 
 
@@ -48,4 +53,7 @@
     'ConnectError',
     'ExecuteError',
     'ExecInterruptedError',
+
+    # Type aliases
+    'SocketAddrT',
 )
-- 
2.31.1

Re: [PATCH v2 04/25] python/aqmp: add SocketAddrT to package root

Posted by Vladimir Sementsov-Ogievskiy 4 years ago

15.12.2021 22:39, John Snow wrote:
> It's a commonly needed definition, it can be re-exported by the root.
> 
> Signed-off-by: John Snow<jsnow@redhat.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

-- 
Best regards,
Vladimir

Re: [PATCH v2 04/25] python/aqmp: add SocketAddrT to package root

Posted by Beraldo Leal 4 years ago

On Wed, Dec 15, 2021 at 02:39:18PM -0500, John Snow wrote:
> It's a commonly needed definition, it can be re-exported by the root.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/qemu/aqmp/__init__.py | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/python/qemu/aqmp/__init__.py b/python/qemu/aqmp/__init__.py
> index 880d5b6fa7..c6fa2dda58 100644
> --- a/python/qemu/aqmp/__init__.py
> +++ b/python/qemu/aqmp/__init__.py
> @@ -26,7 +26,12 @@
>  from .error import AQMPError
>  from .events import EventListener
>  from .message import Message
> -from .protocol import ConnectError, Runstate, StateError
> +from .protocol import (
> +    ConnectError,
> +    Runstate,
> +    SocketAddrT,
> +    StateError,
> +)
>  from .qmp_client import ExecInterruptedError, ExecuteError, QMPClient
>  
>  
> @@ -48,4 +53,7 @@
>      'ConnectError',
>      'ExecuteError',
>      'ExecInterruptedError',
> +
> +    # Type aliases
> +    'SocketAddrT',
>  )

Reviewed-by: Beraldo Leal <bleal@redhat.com>

--
Beraldo