[v2] Python: delete synchronous qemu.qmp package

[PATCH v2 16/25] scripts/bench-block-job: switch to AQMP

Posted by John Snow 4 years ago

For this commit, we only need to remove accommodations for the
synchronous QMP library.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 scripts/simplebench/bench_block_job.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.py
index a403c35b08..af9d1646a4 100755
--- a/scripts/simplebench/bench_block_job.py
+++ b/scripts/simplebench/bench_block_job.py
@@ -27,7 +27,6 @@
 
 sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
 from qemu.machine import QEMUMachine
-from qemu.qmp import QMPConnectError
 from qemu.aqmp import ConnectError
 
 
@@ -50,7 +49,7 @@ def bench_block_job(cmd, cmd_args, qemu_args):
         vm.launch()
     except OSError as e:
         return {'error': 'popen failed: ' + str(e)}
-    except (QMPConnectError, ConnectError, socket.timeout):
+    except (ConnectError, socket.timeout):
         return {'error': 'qemu failed: ' + str(vm.get_log())}
 
     try:
-- 
2.31.1

Re: [PATCH v2 16/25] scripts/bench-block-job: switch to AQMP

Posted by Vladimir Sementsov-Ogievskiy 4 years ago

15.12.2021 22:39, John Snow wrote:
> For this commit, we only need to remove accommodations for the
> synchronous QMP library.
> 
> Signed-off-by: John Snow<jsnow@redhat.com>


Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

-- 
Best regards,
Vladimir

Re: [PATCH v2 16/25] scripts/bench-block-job: switch to AQMP

Posted by Beraldo Leal 4 years ago

On Wed, Dec 15, 2021 at 02:39:30PM -0500, John Snow wrote:
> For this commit, we only need to remove accommodations for the
> synchronous QMP library.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  scripts/simplebench/bench_block_job.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/scripts/simplebench/bench_block_job.py b/scripts/simplebench/bench_block_job.py
> index a403c35b08..af9d1646a4 100755
> --- a/scripts/simplebench/bench_block_job.py
> +++ b/scripts/simplebench/bench_block_job.py
> @@ -27,7 +27,6 @@
>  
>  sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python'))
>  from qemu.machine import QEMUMachine
> -from qemu.qmp import QMPConnectError
>  from qemu.aqmp import ConnectError
>  
>  
> @@ -50,7 +49,7 @@ def bench_block_job(cmd, cmd_args, qemu_args):
>          vm.launch()
>      except OSError as e:
>          return {'error': 'popen failed: ' + str(e)}
> -    except (QMPConnectError, ConnectError, socket.timeout):
> +    except (ConnectError, socket.timeout):
>          return {'error': 'qemu failed: ' + str(vm.get_log())}
>  
>      try:

Reviewed-by: Beraldo Leal <bleal@redhat.com>

--
Beraldo