[v2] gqa-win: get_pci_info: Fix memory leak

[PATCH v2 0/6] gqa-win: get_pci_info: Fix memory leak

Kostiantyn Kostiuk posted 6 patches 4 years, 1 month ago

Diff against v1
Download series mbox

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211214124109.103102-1-konstantin@daynix.com

Maintainers: Michael Roth <michael.roth@amd.com>

qga/commands-win32.c | 235 ++++++++++++++++++++++++-------------------
1 file changed, 134 insertions(+), 101 deletions(-)

Expand all Fold all

[PATCH v2 0/6] gqa-win: get_pci_info: Fix memory leak

Posted by Kostiantyn Kostiuk 4 years, 1 month ago

This set of patches fixes memory leaks in the get_pci_info function when it fails
to get parent device data. In this case the parent_dev_info and the parent_dev_id
variables will be initialized, but not freed.

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1958825

Changelog:
v1 -> v2
 * Rename label "cleanup" -> "end"
 * Reorder some patches
 * Perform small refactoring: split logic to separate functions

Kostiantyn Kostiuk (6):
  gqa-win: get_pci_info: Clean dev_info if handle is valid
  gqa-win: get_pci_info: Use common 'end' label
  gqa-win: get_pci_info: Free parent_dev_info properly
  gqa-win: get_pci_info: Split logic to separate functions
  gqa-win: get_pci_info: Add g_autofree for few variables
  gqa-win: get_pci_info: Replace 'while' with 2 calls of the function

 qga/commands-win32.c | 235 ++++++++++++++++++++++++-------------------
 1 file changed, 134 insertions(+), 101 deletions(-)

--
2.25.1