[PATCH] configure: remove dead variables

Paolo Bonzini posted 1 patch 4 years, 2 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211210084718.24758-1-pbonzini@redhat.com
configure | 5 -----
1 file changed, 5 deletions(-)
[PATCH] configure: remove dead variables
Posted by Paolo Bonzini 4 years, 2 months ago
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/configure b/configure
index 48c21775f3..d3aac031a5 100755
--- a/configure
+++ b/configure
@@ -626,7 +626,6 @@ fi
 case $targetos in
 MINGW32*)
   mingw32="yes"
-  supported_os="yes"
   plugins="no"
   pie="no"
 ;;
@@ -668,7 +667,6 @@ SunOS)
   QEMU_CFLAGS="-D__EXTENSIONS__ $QEMU_CFLAGS"
 ;;
 Haiku)
-  haiku="yes"
   pie="no"
   QEMU_CFLAGS="-DB_USE_POSITIVE_POSIX_ERRORS -D_BSD_SOURCE -fPIC $QEMU_CFLAGS"
 ;;
@@ -3472,9 +3470,6 @@ fi
 if test "$solaris" = "yes" ; then
   echo "CONFIG_SOLARIS=y" >> $config_host_mak
 fi
-if test "$haiku" = "yes" ; then
-  echo "CONFIG_HAIKU=y" >> $config_host_mak
-fi
 if test "$static" = "yes" ; then
   echo "CONFIG_STATIC=y" >> $config_host_mak
 fi
-- 
2.33.1


Re: [PATCH] configure: remove dead variables
Posted by Alex Bennée 4 years, 2 months ago
Paolo Bonzini <pbonzini@redhat.com> writes:

> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée

Re: [PATCH] configure: remove dead variables
Posted by Ján Tomko 4 years, 2 months ago
On a Friday in 2021, Paolo Bonzini wrote:
>Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>---
> configure | 5 -----
> 1 file changed, 5 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

$supported_os is unused since
commit f9332757898a764d85e19d339ec421236e885b68
     meson: move summary to meson.build

$haiku is unused since
commit d99e97e6912d90a55e9a92e004dd54513da2848a
     configure: Add a proper check for openpty() in libutil

CONFIG_HAIKU is unused since
commit 4348300e751df1cd24810fb5f699f1f85bbc2849
     net/tap: Replace tap-haiku.c and tap-aix.c by a generic tap-stub.c

Jano