uas: add missing return

[PATCH] uas: add missing return

Gerd Hoffmann posted 1 patch 4 years, 2 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211210080659.2537084-1-kraxel@redhat.com

Maintainers: Gerd Hoffmann <kraxel@redhat.com>

hw/usb/dev-uas.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] uas: add missing return

Posted by Gerd Hoffmann 4 years, 2 months ago

Otherwise we run the error handling code even for successful requests.

Fixes: 13b250b12ad3 ("uas: add stream number sanity checks.")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/dev-uas.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c
index 599d6b52a012..c9f295e7e449 100644
--- a/hw/usb/dev-uas.c
+++ b/hw/usb/dev-uas.c
@@ -908,6 +908,7 @@ static void usb_uas_handle_data(USBDevice *dev, USBPacket *p)
         p->status = USB_RET_STALL;
         break;
     }
+    return;
 
 err_stream:
     error_report("%s: invalid stream %d", __func__, p->stream);
-- 
2.33.1

Re: [PATCH] uas: add missing return

Posted by Philippe Mathieu-Daudé 4 years, 2 months ago

On 12/10/21 09:06, Gerd Hoffmann wrote:
> Otherwise we run the error handling code even for successful requests.
> 
> Fixes: 13b250b12ad3 ("uas: add stream number sanity checks.")
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/usb/dev-uas.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>