[PATCH 4/8] vhost-user-video: add meson subdir build logic

Peter Griffin posted 8 patches 3 years, 9 months ago
Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Peter Griffin <peter.griffin@linaro.org>
[PATCH 4/8] vhost-user-video: add meson subdir build logic
Posted by Peter Griffin 3 years, 9 months ago
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 tools/meson.build | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tools/meson.build b/tools/meson.build
index 3e5a0abfa2..3314b5efc5 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -24,3 +24,12 @@ endif
 if have_virtiofsd
   subdir('virtiofsd')
 endif
+
+have_virtiovideo = (have_system and
+    have_tools and
+    'CONFIG_LINUX' in config_host)
+
+if have_virtiovideo
+  subdir('vhost-user-video')
+endif
+
-- 
2.25.1


Re: [PATCH 4/8] vhost-user-video: add meson subdir build logic
Posted by Alex Bennée 3 years, 8 months ago
Peter Griffin <peter.griffin@linaro.org> writes:

> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  tools/meson.build | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/tools/meson.build b/tools/meson.build
> index 3e5a0abfa2..3314b5efc5 100644
> --- a/tools/meson.build
> +++ b/tools/meson.build
> @@ -24,3 +24,12 @@ endif
>  if have_virtiofsd
>    subdir('virtiofsd')
>  endif
> +
> +have_virtiovideo = (have_system and
> +    have_tools and
> +    'CONFIG_LINUX' in config_host)

Following the convention of cece116c939d219070b250338439c2d16f94e3da

  have_virtiovideo = (targetos == 'linux' and
      have_tools and
      'CONFIG_VHOST_USER' in config_host)

> +
> +if have_virtiovideo
> +  subdir('vhost-user-video')
> +endif
> +


-- 
Alex Bennée

Re: [PATCH 4/8] vhost-user-video: add meson subdir build logic
Posted by Peter Griffin 3 years, 8 months ago
Hi Alex,

Thanks for reviewing.

On Tue, 11 Jan 2022, Alex Bennée wrote:

> 
> Peter Griffin <peter.griffin@linaro.org> writes:
> 
> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> > ---
> >  tools/meson.build | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/tools/meson.build b/tools/meson.build
> > index 3e5a0abfa2..3314b5efc5 100644
> > --- a/tools/meson.build
> > +++ b/tools/meson.build
> > @@ -24,3 +24,12 @@ endif
> >  if have_virtiofsd
> >    subdir('virtiofsd')
> >  endif
> > +
> > +have_virtiovideo = (have_system and
> > +    have_tools and
> > +    'CONFIG_LINUX' in config_host)
> 
> Following the convention of cece116c939d219070b250338439c2d16f94e3da
> 
>   have_virtiovideo = (targetos == 'linux' and
>       have_tools and
>       'CONFIG_VHOST_USER' in config_host)
>

Will fix in v2

regards,

Peter.

> > +
> > +if have_virtiovideo
> > +  subdir('vhost-user-video')
> > +endif
> > +
> 
> 
> -- 
> Alex Bennée