[v2] hw/display: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO

[PATCH v2 0/4] hw/display: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO

Philippe Mathieu-Daudé posted 4 patches 2 years, 4 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211206224528.563588-1-f4bug@amsat.org

Maintainers: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>

configs/devices/mips-softmmu/common.mak |   2 +-
include/hw/display/vga.h                |   6 +-
hw/display/vga-isa-mm.c                 | 114 -------------------
hw/display/vga-mmio.c                   | 139 ++++++++++++++++++++++++
hw/mips/jazz.c                          |   9 +-
hw/display/Kconfig                      |   2 +-
hw/display/meson.build                  |   2 +-
hw/mips/Kconfig                         |   2 +-
8 files changed, 152 insertions(+), 124 deletions(-)
delete mode 100644 hw/display/vga-isa-mm.c
create mode 100644 hw/display/vga-mmio.c

Expand all Fold all

[PATCH v2 0/4] hw/display: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO

Posted by Philippe Mathieu-Daudé 2 years, 4 months ago

Convert the open-coded vga_mmio_init() to a sysbus device.

Since v1:
- Addressed Zolton and Thomas comments, added their R-b tags

Philippe Mathieu-Daudé (4):
  hw/display: Rename VGA_ISA_MM -> VGA_MMIO
  hw/display/vga-mmio: Inline vga_mm_init()
  hw/display/vga-mmio: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO
  hw/mips/jazz: Inline vga_mmio_init() and remove it

 configs/devices/mips-softmmu/common.mak |   2 +-
 include/hw/display/vga.h                |   6 +-
 hw/display/vga-isa-mm.c                 | 114 -------------------
 hw/display/vga-mmio.c                   | 139 ++++++++++++++++++++++++
 hw/mips/jazz.c                          |   9 +-
 hw/display/Kconfig                      |   2 +-
 hw/display/meson.build                  |   2 +-
 hw/mips/Kconfig                         |   2 +-
 8 files changed, 152 insertions(+), 124 deletions(-)
 delete mode 100644 hw/display/vga-isa-mm.c
 create mode 100644 hw/display/vga-mmio.c

-- 
2.33.1

Re: [PATCH v2 0/4] hw/display: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO

Posted by Philippe Mathieu-Daudé 2 years, 4 months ago

On 12/6/21 23:45, Philippe Mathieu-Daudé wrote:
> Convert the open-coded vga_mmio_init() to a sysbus device.

> Philippe Mathieu-Daudé (4):
>   hw/display: Rename VGA_ISA_MM -> VGA_MMIO
>   hw/display/vga-mmio: Inline vga_mm_init()
>   hw/display/vga-mmio: QOM'ify vga_mmio_init() as TYPE_VGA_MMIO
>   hw/mips/jazz: Inline vga_mmio_init() and remove it

Queued to mips-next.