1. Patchew
  2. QEMU
  3. View series

[PATCH for-7.0] hw/i386/pc: Add missing property descriptions

Thomas Huth posted 1 patch 2 years, 4 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211206134255.94784-1-thuth@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Richard Henderson <richard.henderson@linaro.org>
hw/i386/pc.c | 8 ++++++++
1 file changed, 8 insertions(+)
[PATCH for-7.0] hw/i386/pc: Add missing property descriptions
Posted by Thomas Huth 2 years, 4 months ago 
When running "qemu-system-x86_64 -M pc,help" I noticed that some
properties were still missing their description. Add them now so
that users get at least a slightly better idea what they are all
about.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/i386/pc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index a2ef40ecbc..837f2bff4e 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1734,15 +1734,23 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
 
     object_class_property_add_bool(oc, PC_MACHINE_SMBUS,
         pc_machine_get_smbus, pc_machine_set_smbus);
+    object_class_property_set_description(oc, PC_MACHINE_SMBUS,
+        "Enable/disable system management bus");
 
     object_class_property_add_bool(oc, PC_MACHINE_SATA,
         pc_machine_get_sata, pc_machine_set_sata);
+    object_class_property_set_description(oc, PC_MACHINE_SATA,
+        "Enable/disable Serial ATA bus");
 
     object_class_property_add_bool(oc, PC_MACHINE_PIT,
         pc_machine_get_pit, pc_machine_set_pit);
+    object_class_property_set_description(oc, PC_MACHINE_PIT,
+        "Enable/disable Intel 8254 programmable interval timer emulation");
 
     object_class_property_add_bool(oc, "hpet",
         pc_machine_get_hpet, pc_machine_set_hpet);
+    object_class_property_set_description(oc, "hpet",
+        "Enable/disable high precision event timer emulation");
 
     object_class_property_add_bool(oc, "default-bus-bypass-iommu",
         pc_machine_get_default_bus_bypass_iommu,
-- 
2.27.0
Re: [PATCH for-7.0] hw/i386/pc: Add missing property descriptions
Posted by Thomas Huth 2 years, 4 months ago 
On 06/12/2021 14.42, Thomas Huth wrote:
> When running "qemu-system-x86_64 -M pc,help" I noticed that some
> properties were still missing their description. Add them now so
> that users get at least a slightly better idea what they are all
> about.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   hw/i386/pc.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index a2ef40ecbc..837f2bff4e 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1734,15 +1734,23 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
>   
>       object_class_property_add_bool(oc, PC_MACHINE_SMBUS,
>           pc_machine_get_smbus, pc_machine_set_smbus);
> +    object_class_property_set_description(oc, PC_MACHINE_SMBUS,
> +        "Enable/disable system management bus");
>   
>       object_class_property_add_bool(oc, PC_MACHINE_SATA,
>           pc_machine_get_sata, pc_machine_set_sata);
> +    object_class_property_set_description(oc, PC_MACHINE_SATA,
> +        "Enable/disable Serial ATA bus");
>   
>       object_class_property_add_bool(oc, PC_MACHINE_PIT,
>           pc_machine_get_pit, pc_machine_set_pit);
> +    object_class_property_set_description(oc, PC_MACHINE_PIT,
> +        "Enable/disable Intel 8254 programmable interval timer emulation");
>   
>       object_class_property_add_bool(oc, "hpet",
>           pc_machine_get_hpet, pc_machine_set_hpet);
> +    object_class_property_set_description(oc, "hpet",
> +        "Enable/disable high precision event timer emulation");
>   
>       object_class_property_add_bool(oc, "default-bus-bypass-iommu",
>           pc_machine_get_default_bus_bypass_iommu,

Friendly happy new year ping!

  Thomas
Re: [PATCH for-7.0] hw/i386/pc: Add missing property descriptions
Posted by Igor Mammedov 2 years, 3 months ago 
On Mon,  6 Dec 2021 14:42:55 +0100
Thomas Huth <thuth@redhat.com> wrote:

> When running "qemu-system-x86_64 -M pc,help" I noticed that some
> properties were still missing their description. Add them now so
> that users get at least a slightly better idea what they are all
> about.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/i386/pc.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index a2ef40ecbc..837f2bff4e 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1734,15 +1734,23 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
>  
>      object_class_property_add_bool(oc, PC_MACHINE_SMBUS,
>          pc_machine_get_smbus, pc_machine_set_smbus);
> +    object_class_property_set_description(oc, PC_MACHINE_SMBUS,
> +        "Enable/disable system management bus");
>  
>      object_class_property_add_bool(oc, PC_MACHINE_SATA,
>          pc_machine_get_sata, pc_machine_set_sata);
> +    object_class_property_set_description(oc, PC_MACHINE_SATA,
> +        "Enable/disable Serial ATA bus");
>  
>      object_class_property_add_bool(oc, PC_MACHINE_PIT,
>          pc_machine_get_pit, pc_machine_set_pit);
> +    object_class_property_set_description(oc, PC_MACHINE_PIT,
> +        "Enable/disable Intel 8254 programmable interval timer emulation");
>  
>      object_class_property_add_bool(oc, "hpet",
>          pc_machine_get_hpet, pc_machine_set_hpet);
> +    object_class_property_set_description(oc, "hpet",
> +        "Enable/disable high precision event timer emulation");
>  
>      object_class_property_add_bool(oc, "default-bus-bypass-iommu",
>          pc_machine_get_default_bus_bypass_iommu,

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.