[v1] ppc/pnv: Add support for user created PHB3/PHB4 devices

[PATCH 02/14] ppc/pnv: Drop the "num-phbs" property

Posted by Cédric Le Goater 4 years, 2 months ago

It is never used.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/ppc/pnv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index bd768dcc28ad..988b305398b2 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -1764,7 +1764,6 @@ static Property pnv_chip_properties[] = {
     DEFINE_PROP_UINT32("nr-cores", PnvChip, nr_cores, 1),
     DEFINE_PROP_UINT64("cores-mask", PnvChip, cores_mask, 0x0),
     DEFINE_PROP_UINT32("nr-threads", PnvChip, nr_threads, 1),
-    DEFINE_PROP_UINT32("num-phbs", PnvChip, num_phbs, 0),
     DEFINE_PROP_END_OF_LIST(),
 };
 
-- 
2.31.1

Re: [PATCH 02/14] ppc/pnv: Drop the "num-phbs" property

Posted by Frederic Barrat 4 years, 2 months ago


On 02/12/2021 15:42, Cédric Le Goater wrote:
> It is never used.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---


Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com>


>   hw/ppc/pnv.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index bd768dcc28ad..988b305398b2 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -1764,7 +1764,6 @@ static Property pnv_chip_properties[] = {
>       DEFINE_PROP_UINT32("nr-cores", PnvChip, nr_cores, 1),
>       DEFINE_PROP_UINT64("cores-mask", PnvChip, cores_mask, 0x0),
>       DEFINE_PROP_UINT32("nr-threads", PnvChip, nr_threads, 1),
> -    DEFINE_PROP_UINT32("num-phbs", PnvChip, num_phbs, 0),
>       DEFINE_PROP_END_OF_LIST(),
>   };
>   
>

Re: [PATCH 02/14] ppc/pnv: Drop the "num-phbs" property

Posted by Daniel Henrique Barboza 4 years, 2 months ago


On 12/2/21 11:42, Cédric Le Goater wrote:
> It is never used.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   hw/ppc/pnv.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index bd768dcc28ad..988b305398b2 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -1764,7 +1764,6 @@ static Property pnv_chip_properties[] = {
>       DEFINE_PROP_UINT32("nr-cores", PnvChip, nr_cores, 1),
>       DEFINE_PROP_UINT64("cores-mask", PnvChip, cores_mask, 0x0),
>       DEFINE_PROP_UINT32("nr-threads", PnvChip, nr_threads, 1),
> -    DEFINE_PROP_UINT32("num-phbs", PnvChip, num_phbs, 0),
>       DEFINE_PROP_END_OF_LIST(),
>   };
>   
>