[v2] block: minor refactoring in preparation to the block layer API split

[PATCH v2 0/4] block: minor refactoring in preparation to the block layer API split

Emanuele Giuseppe Esposito posted 4 patches 2 years, 4 months ago

Diff against v1 v3
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211130094633.277982-1-eesposit@redhat.com

Maintainers: Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>

There is a newer version of this series

block.c                        |  4 ++-
block/monitor/block-hmp-cmds.c |  2 +-
blockdev.c                     | 47 ++++------------------------------
include/block/block_int.h      |  3 ---
include/sysemu/blockdev.h      |  6 +----
softmmu/vl.c                   | 25 +++++++++++++++++-
6 files changed, 34 insertions(+), 53 deletions(-)

Expand all Fold all

[PATCH v2 0/4] block: minor refactoring in preparation to the block layer API split

Posted by Emanuele Giuseppe Esposito 2 years, 4 months ago

These patches are taken from my old patches and feedback of
my series "block layer: split block APIs in global state and I/O".

The reason for a separate series is that the original one is
already too long, and these patches are just refactoring the code,
mainly deleting or moving functions in blockdev.h and block_int.h.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
v2:
* Apply Philippe comments, instead of renaming a make if_name
  public, create a getter method (discard old patch 2).

Emanuele Giuseppe Esposito (4):
  block_int: make bdrv_backing_overridden static
  include/sysemu/blockdev.c: introduce block_if_name
  include/sysemu/blockdev.h: move drive_add and inline drive_def
  include/sysemu/blockdev.h: remove drive_get_max_devs

 block.c                        |  4 ++-
 block/monitor/block-hmp-cmds.c |  2 +-
 blockdev.c                     | 47 ++++------------------------------
 include/block/block_int.h      |  3 ---
 include/sysemu/blockdev.h      |  6 +----
 softmmu/vl.c                   | 25 +++++++++++++++++-
 6 files changed, 34 insertions(+), 53 deletions(-)

-- 
2.31.1

Re: [PATCH v2 0/4] block: minor refactoring in preparation to the block layer API split

Posted by Stefan Hajnoczi 2 years, 4 months ago

On Tue, Nov 30, 2021 at 04:46:29AM -0500, Emanuele Giuseppe Esposito wrote:
> These patches are taken from my old patches and feedback of
> my series "block layer: split block APIs in global state and I/O".
> 
> The reason for a separate series is that the original one is
> already too long, and these patches are just refactoring the code,
> mainly deleting or moving functions in blockdev.h and block_int.h.
> 
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
> v2:
> * Apply Philippe comments, instead of renaming a make if_name
>   public, create a getter method (discard old patch 2).
> 
> Emanuele Giuseppe Esposito (4):
>   block_int: make bdrv_backing_overridden static
>   include/sysemu/blockdev.c: introduce block_if_name
>   include/sysemu/blockdev.h: move drive_add and inline drive_def
>   include/sysemu/blockdev.h: remove drive_get_max_devs
> 
>  block.c                        |  4 ++-
>  block/monitor/block-hmp-cmds.c |  2 +-
>  blockdev.c                     | 47 ++++------------------------------
>  include/block/block_int.h      |  3 ---
>  include/sysemu/blockdev.h      |  6 +----
>  softmmu/vl.c                   | 25 +++++++++++++++++-
>  6 files changed, 34 insertions(+), 53 deletions(-)
> 
> -- 
> 2.31.1
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>