On Wed, Dec 8, 2021 at 2:40 PM Alistair Francis <alistair23@gmail.com>
wrote:
> On Mon, Nov 29, 2021 at 1:04 PM <frank.chang@sifive.com> wrote:
> >
> > From: Frank Chang <frank.chang@sifive.com>
> >
> > This patchset implements the vector extension v1.0 for RISC-V on QEMU.
> >
> > RVV v1.0 spec is now fronzen for public review:
> > https://github.com/riscv/riscv-v-spec/releases/tag/v1.0
> >
> > The port is available here:
> > https://github.com/sifive/qemu/tree/rvv-1.0-upstream-v10
> >
> > RVV v1.0 can be enabled with -cpu option: v=true and specify vext_spec
> > option to v1.0 (i.e. vext_spec=v1.0)
> >
> > Note: This patchset depends on other patchsets listed in Based-on
> > section below so it is not able to be built unless those patchsets
> > are applied.
>
> I think this is all reviewed now. Once your other patch sets are
> merged just re-send this and I can apply it.
>
> Alistair
>
Hi Alistair,
Thanks for the review.
I think <20211021160847.2748577-1-frank.chang@sifive.com> has already been
applied to your riscv-to-apply.next branch.
I'll rebase <20211021162956.2772656-1-frank.chang@sifive.com> and also this
patchset as well then resend them.
Regards,
Frank Chang
>
> >
> > Changelog:
> >
> > v10
> > * Add ELEN checks for widening and narrowing instructions.
> >
> > v9
> > * Remove explicitly set mstatus.SD patches as mstatus.SD is now
> > set in add_status_sd().
> > * Rebase on riscv-to-apply.next branch.
> >
> > v8
> > * Use {get,dest}_gpr APIs.
> > * remove vector AMO instructions.
> > * rename vpopc.m to vcpop.m.
> > * rename vle1.v and vse1.v to vlm.v and vsm.v.
> > * rename vmandnot.mm and vmornot.mm to vmandn.mm and vmorn.mm.
> >
> > v7
> > * remove hardcoded GDB vector registers list.
> > * add vsetivli instruction.
> > * add vle1.v and vse1.v instructions.
> >
> > v6
> > * add vector floating-point reciprocal estimate instruction.
> > * add vector floating-point reciprocal square-root estimate
> instruction.
> > * update check rules for segment register groups, each segment register
> > group has to follow overlap rules.
> > * update viota.m instruction check rules.
> >
> > v5
> > * refactor RVV v1.0 check functions.
> > (Thanks to Richard Henderson's bitwise tricks.)
> > * relax RV_VLEN_MAX to 1024-bits.
> > * implement vstart CSR's behaviors.
> > * trigger illegal instruction exception if frm is not valid for
> > vector floating-point instructions.
> > * rebase on riscv-to-apply.next.
> >
> > v4
> > * remove explicit float flmul variable in DisasContext.
> > * replace floating-point calculations with shift operations to
> > improve performance.
> > * relax RV_VLEN_MAX to 512-bits.
> >
> > v3
> > * apply nan-box helpers from Richard Henderson.
> > * remove fp16 api changes as they are sent independently in another
> > pathcset by Chih-Min Chao.
> > * remove all tail elements clear functions as tail elements can
> > retain unchanged for either VTA set to undisturbed or agnostic.
> > * add fp16 nan-box check generator function.
> > * add floating-point rounding mode enum.
> > * replace flmul arithmetic with shifts to avoid floating-point
> > conversions.
> > * add Zvqmac extension.
> > * replace gdbstub vector register xml files with dynamic generator.
> > * bumped to RVV v1.0.
> > * RVV v1.0 related changes:
> > * add vl<nf>re<eew>.v and vs<nf>r.v vector whole register
> > load/store instructions
> > * add vrgatherei16 instruction.
> > * rearranged bits in vtype to make vlmul bits into a contiguous
> > field.
> >
> > v2
> > * drop v0.7.1 support.
> > * replace invisible return check macros with functions.
> > * move mark_vs_dirty() to translators.
> > * add SSTATUS_VS flag for s-mode.
> > * nan-box scalar fp register for floating-point operations.
> > * add gdbstub files for vector registers to allow system-mode
> > debugging with GDB.
> >
> > Based-on: <20211021160847.2748577-1-frank.chang@sifive.com>
> > Based-on: <20211021162956.2772656-1-frank.chang@sifive.com>
> >
> > Frank Chang (72):
> > target/riscv: drop vector 0.7.1 and add 1.0 support
> > target/riscv: Use FIELD_EX32() to extract wd field
> > target/riscv: rvv-1.0: set mstatus.SD bit if mstatus.VS is dirty
> > target/riscv: rvv-1.0: introduce writable misa.v field
> > target/riscv: rvv-1.0: add translation-time vector context status
> > target/riscv: rvv-1.0: remove rvv related codes from fcsr registers
> > target/riscv: rvv-1.0: check MSTATUS_VS when accessing vector csr
> > registers
> > target/riscv: rvv-1.0: remove MLEN calculations
> > target/riscv: rvv-1.0: add fractional LMUL
> > target/riscv: rvv-1.0: add VMA and VTA
> > target/riscv: rvv-1.0: update check functions
> > target/riscv: introduce more imm value modes in translator functions
> > target/riscv: rvv:1.0: add translation-time nan-box helper function
> > target/riscv: rvv-1.0: remove amo operations instructions
> > target/riscv: rvv-1.0: configure instructions
> > target/riscv: rvv-1.0: stride load and store instructions
> > target/riscv: rvv-1.0: index load and store instructions
> > target/riscv: rvv-1.0: fix address index overflow bug of indexed
> > load/store insns
> > target/riscv: rvv-1.0: fault-only-first unit stride load
> > target/riscv: rvv-1.0: load/store whole register instructions
> > target/riscv: rvv-1.0: update vext_max_elems() for load/store insns
> > target/riscv: rvv-1.0: take fractional LMUL into vector max elements
> > calculation
> > target/riscv: rvv-1.0: floating-point square-root instruction
> > target/riscv: rvv-1.0: floating-point classify instructions
> > target/riscv: rvv-1.0: count population in mask instruction
> > target/riscv: rvv-1.0: find-first-set mask bit instruction
> > target/riscv: rvv-1.0: set-X-first mask bit instructions
> > target/riscv: rvv-1.0: iota instruction
> > target/riscv: rvv-1.0: element index instruction
> > target/riscv: rvv-1.0: allow load element with sign-extended
> > target/riscv: rvv-1.0: register gather instructions
> > target/riscv: rvv-1.0: integer scalar move instructions
> > target/riscv: rvv-1.0: floating-point move instruction
> > target/riscv: rvv-1.0: floating-point scalar move instructions
> > target/riscv: rvv-1.0: whole register move instructions
> > target/riscv: rvv-1.0: integer extension instructions
> > target/riscv: rvv-1.0: single-width averaging add and subtract
> > instructions
> > target/riscv: rvv-1.0: single-width bit shift instructions
> > target/riscv: rvv-1.0: integer add-with-carry/subtract-with-borrow
> > target/riscv: rvv-1.0: narrowing integer right shift instructions
> > target/riscv: rvv-1.0: widening integer multiply-add instructions
> > target/riscv: rvv-1.0: single-width saturating add and subtract
> > instructions
> > target/riscv: rvv-1.0: integer comparison instructions
> > target/riscv: rvv-1.0: floating-point compare instructions
> > target/riscv: rvv-1.0: mask-register logical instructions
> > target/riscv: rvv-1.0: slide instructions
> > target/riscv: rvv-1.0: floating-point slide instructions
> > target/riscv: rvv-1.0: narrowing fixed-point clip instructions
> > target/riscv: rvv-1.0: single-width floating-point reduction
> > target/riscv: rvv-1.0: widening floating-point reduction instructions
> > target/riscv: rvv-1.0: single-width scaling shift instructions
> > target/riscv: rvv-1.0: remove widening saturating scaled multiply-add
> > target/riscv: rvv-1.0: remove vmford.vv and vmford.vf
> > target/riscv: rvv-1.0: remove integer extract instruction
> > target/riscv: rvv-1.0: floating-point min/max instructions
> > target/riscv: introduce floating-point rounding mode enum
> > target/riscv: rvv-1.0: floating-point/integer type-convert
> > instructions
> > target/riscv: rvv-1.0: widening floating-point/integer type-convert
> > target/riscv: add "set round to odd" rounding mode helper function
> > target/riscv: rvv-1.0: narrowing floating-point/integer type-convert
> > target/riscv: rvv-1.0: relax RV_VLEN_MAX to 1024-bits
> > target/riscv: rvv-1.0: implement vstart CSR
> > target/riscv: rvv-1.0: trigger illegal instruction exception if frm is
> > not valid
> > target/riscv: rvv-1.0: floating-point reciprocal square-root estimate
> > instruction
> > target/riscv: rvv-1.0: floating-point reciprocal estimate instruction
> > target/riscv: rvv-1.0: rename r2_zimm to r2_zimm11
> > target/riscv: rvv-1.0: add vsetivli instruction
> > target/riscv: rvv-1.0: add evl parameter to vext_ldst_us()
> > target/riscv: rvv-1.0: add vector unit-stride mask load/store insns
> > target/riscv: rvv-1.0: rename vmandnot.mm and vmornot.mm to vmandn.mm
> > and vmorn.mm
> > target/riscv: rvv-1.0: update opivv_vadc_check() comment
> > target/riscv: rvv-1.0: Add ELEN checks for widening and narrowing
> > instructions
> >
> > Greentime Hu (1):
> > target/riscv: rvv-1.0: add vlenb register
> >
> > Hsiangkai Wang (1):
> > target/riscv: gdb: support vector registers for rv64 & rv32
> >
> > LIU Zhiwei (3):
> > target/riscv: rvv-1.0: add mstatus VS field
> > target/riscv: rvv-1.0: add sstatus VS field
> > target/riscv: rvv-1.0: add vcsr register
> >
> > target/riscv/cpu.c | 18 +-
> > target/riscv/cpu.h | 61 +-
> > target/riscv/cpu_bits.h | 10 +
> > target/riscv/cpu_helper.c | 39 +-
> > target/riscv/csr.c | 63 +-
> > target/riscv/fpu_helper.c | 17 +-
> > target/riscv/gdbstub.c | 184 ++
> > target/riscv/helper.h | 435 ++-
> > target/riscv/insn32.decode | 294 +-
> > target/riscv/insn_trans/trans_rvv.c.inc | 2429 +++++++++------
> > target/riscv/internals.h | 24 +-
> > target/riscv/translate.c | 73 +-
> > target/riscv/vector_helper.c | 3601 ++++++++++++-----------
> > 13 files changed, 4157 insertions(+), 3091 deletions(-)
> >
> > --
> > 2.25.1
> >
> >
>