change ivshmem endianness to LITTLE_ENDIAN

[PATCH for-7.0 v2 0/2] change ivshmem endianness to LITTLE_ENDIAN

Daniel Henrique Barboza posted 2 patches 2 years, 4 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211124092948.335389-1-danielhb413@gmail.com

Maintainers: Thomas Huth <thuth@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

hw/misc/ivshmem.c          | 2 +-
tests/qtest/ivshmem-test.c | 5 +----
2 files changed, 2 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH for-7.0 v2 0/2] change ivshmem endianness to LITTLE_ENDIAN

Posted by Daniel Henrique Barboza 2 years, 4 months ago

Hi,

This small series fixes an issue reported in Gitlab [1] that
affects PowerPC big-endian and little-endian and probably all
other big-endians in the wild that might use 'ivshmem'.

It's not clear to me who is the maintainer/responsible for this device
(MAINTAINERS doesn't seem to have any 'ivhshmem' entries nor someone
that looks upon all hw/misc/* files) so I didn't add any CC in that
regard. 'qemu-ppc' is being copied for awareness since they are the
folks that are most likely being impacted by the bug.

[1] https://gitlab.com/qemu-project/qemu/-/issues/168

Changes in v2:
- fixed 'endianess' occurrences to 'endianness' in patch 1
- fixed spell errors and added Thomas' ack in patch 2
- added a "for-7.0" marker in the subject
- v1 link: https://lists.gnu.org/archive/html/qemu-devel/2021-11/msg04716.html


Daniel Henrique Barboza (2):
  ivshmem.c: change endianness to LITTLE_ENDIAN
  ivshmem-test.c: enable test_ivshmem_server for ppc64 arch

 hw/misc/ivshmem.c          | 2 +-
 tests/qtest/ivshmem-test.c | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

-- 
2.31.1

Re: [PATCH for-7.0 v2 0/2] change ivshmem endianness to LITTLE_ENDIAN

Posted by Cédric Le Goater 2 years, 4 months ago

On 11/24/21 10:29, Daniel Henrique Barboza wrote:
> Hi,
> 
> This small series fixes an issue reported in Gitlab [1] that
> affects PowerPC big-endian and little-endian and probably all
> other big-endians in the wild that might use 'ivshmem'.
> 
> It's not clear to me who is the maintainer/responsible for this device
> (MAINTAINERS doesn't seem to have any 'ivhshmem' entries nor someone
> that looks upon all hw/misc/* files) so I didn't add any CC in that
> regard. 'qemu-ppc' is being copied for awareness since they are the
> folks that are most likely being impacted by the bug.
> 
> [1] https://gitlab.com/qemu-project/qemu/-/issues/168


Applied to ppc-next.

Thanks,

C.