change IVSHMEM endianess to LITTLE_ENDIAN

[PATCH 0/2] change IVSHMEM endianess to LITTLE_ENDIAN

Posted by Daniel Henrique Barboza 2 years, 4 months ago

Hi,

This small series fixes an issue reported in Gitlab [1] that
affects PowerPC big-endian and little-endian and probably all
other big-endians in the wild that might use 'ivshmem'.

It's not clear to me who is the maintainer/responsible for this device
(MAINTAINERS doesn't seem to have any 'ivhshmem' entries nor someone
that looks upon all hw/misc/* files) so I didn't add any CC in that
regard. 'qemu-ppc' is being copied for awareness since they are the
folks that are most likely being impacted by the bug.

[1] https://gitlab.com/qemu-project/qemu/-/issues/168

Daniel Henrique Barboza (2):
  ivshmem.c: change endianness to LITTLE_ENDIAN
  ivshmem-test.c: enable test_ivshmem_server for ppc64 arch

 hw/misc/ivshmem.c          | 2 +-
 tests/qtest/ivshmem-test.c | 5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

-- 
2.31.1

Re: [PATCH 0/2] change IVSHMEM endianess to LITTLE_ENDIAN

Posted by Cédric Le Goater 2 years, 4 months ago

On 11/23/21 22:19, Daniel Henrique Barboza wrote:
> Hi,
> 
> This small series fixes an issue reported in Gitlab [1] that
> affects PowerPC big-endian and little-endian and probably all
> other big-endians in the wild that might use 'ivshmem'.
> 
> It's not clear to me who is the maintainer/responsible for this device
> (MAINTAINERS doesn't seem to have any 'ivhshmem' entries nor someone
> that looks upon all hw/misc/* files) so I didn't add any CC in that
> regard. 'qemu-ppc' is being copied for awareness since they are the
> folks that are most likely being impacted by the bug.
> 
> [1] https://gitlab.com/qemu-project/qemu/-/issues/168

Do we want these fixes for 6.2 ?

Thanks,

C.

> 
> Daniel Henrique Barboza (2):
>    ivshmem.c: change endianness to LITTLE_ENDIAN
>    ivshmem-test.c: enable test_ivshmem_server for ppc64 arch
> 
>   hw/misc/ivshmem.c          | 2 +-
>   tests/qtest/ivshmem-test.c | 5 +----
>   2 files changed, 2 insertions(+), 5 deletions(-)
>

Re: [PATCH 0/2] change IVSHMEM endianess to LITTLE_ENDIAN

Posted by Daniel Henrique Barboza 2 years, 4 months ago


On 11/23/21 20:22, Cédric Le Goater wrote:
> On 11/23/21 22:19, Daniel Henrique Barboza wrote:
>> Hi,
>>
>> This small series fixes an issue reported in Gitlab [1] that
>> affects PowerPC big-endian and little-endian and probably all
>> other big-endians in the wild that might use 'ivshmem'.
>>
>> It's not clear to me who is the maintainer/responsible for this device
>> (MAINTAINERS doesn't seem to have any 'ivhshmem' entries nor someone
>> that looks upon all hw/misc/* files) so I didn't add any CC in that
>> regard. 'qemu-ppc' is being copied for awareness since they are the
>> folks that are most likely being impacted by the bug.
>>
>> [1] https://gitlab.com/qemu-project/qemu/-/issues/168
> 
> Do we want these fixes for 6.2 ?


No, I don't think it's necessary. Changing endianess is something that I'd rather
do in the start of the 7.0 cycle. This bug has been around for years at this
point. It can wait a couple of months.

I'll re-send these with Thomas' Ack and corrections and with a "for-7.0" subject
for extra clarity.


Thanks,


Daniel



> 
> Thanks,
> 
> C.
> 
>>
>> Daniel Henrique Barboza (2):
>>    ivshmem.c: change endianness to LITTLE_ENDIAN
>>    ivshmem-test.c: enable test_ivshmem_server for ppc64 arch
>>
>>   hw/misc/ivshmem.c          | 2 +-
>>   tests/qtest/ivshmem-test.c | 5 +----
>>   2 files changed, 2 insertions(+), 5 deletions(-)
>>
>