[PATCH 0/2] Fix broken rST conversion of "submitting-a-patch.rst"

Kashyap Chamarthy posted 2 patches 2 years, 6 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211119193118.949698-1-kchamart@redhat.com
docs/devel/submitting-a-patch.rst | 202 ++++++++++++++++++++++--------
1 file changed, 153 insertions(+), 49 deletions(-)
[PATCH 0/2] Fix broken rST conversion of "submitting-a-patch.rst"
Posted by Kashyap Chamarthy 2 years, 6 months ago
I completely botched up the merged[0] rST conversion of this document by
accidentally dropping entire hunks (!) of text. :-(  I made it very hard
for reviewers to spot it, as the omitted text was buried deep in the
document.  To fix my hatchet job, I reconverted the "SubmitAPatch"
wiki[1] page from scratch and replaced the existing rST with it, while
making sure I incorporated previous feedback.  Sorry for the sloppiness.

More details in patch-1.

[0] https://gitlab.com/qemu-project/qemu/-/commit/9f73de8df033

Kashyap Chamarthy (2):
  docs: Fix botched rST conversion of 'submitting-a-patch.rst'
  docs: List more commit-message tags "in submitting-a-patch"

 docs/devel/submitting-a-patch.rst | 202 ++++++++++++++++++++++--------
 1 file changed, 153 insertions(+), 49 deletions(-)

-- 
2.31.1



Re: [PATCH 0/2] Fix broken rST conversion of "submitting-a-patch.rst"
Posted by Eric Blake 2 years, 6 months ago
On Fri, Nov 19, 2021 at 08:31:16PM +0100, Kashyap Chamarthy wrote:
> I completely botched up the merged[0] rST conversion of this document by
> accidentally dropping entire hunks (!) of text. :-(  I made it very hard
> for reviewers to spot it, as the omitted text was buried deep in the
> document.  To fix my hatchet job, I reconverted the "SubmitAPatch"
> wiki[1] page from scratch and replaced the existing rST with it, while
> making sure I incorporated previous feedback.  Sorry for the sloppiness.
> 
> More details in patch-1.
> 
> [0] https://gitlab.com/qemu-project/qemu/-/commit/9f73de8df033
> 
> Kashyap Chamarthy (2):
>   docs: Fix botched rST conversion of 'submitting-a-patch.rst'
>   docs: List more commit-message tags "in submitting-a-patch"

Series:
Reviewed-by: Eric Blake <eblake@redhat.com>


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org