[v5] linux-user: simplify safe signal handling

[PATCH v5 15/17] linux-user: Move thunk.c from top-level

Posted by Richard Henderson 4 years, 2 months ago

So far, linux-user is the only user of these functions.
Clean up the build machinery by restricting it to linux-user.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 meson.build                   | 1 -
 thunk.c => linux-user/thunk.c | 0
 linux-user/meson.build        | 1 +
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename thunk.c => linux-user/thunk.c (100%)

diff --git a/meson.build b/meson.build
index 387f7fe1c9..9f59c57909 100644
--- a/meson.build
+++ b/meson.build
@@ -2614,7 +2614,6 @@ subdir('linux-user')
 
 specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
 
-linux_user_ss.add(files('thunk.c'))
 specific_ss.add_all(when: 'CONFIG_LINUX_USER', if_true: linux_user_ss)
 
 common_user_ss = common_user_ss.apply(config_all, strict: false)
diff --git a/thunk.c b/linux-user/thunk.c
similarity index 100%
rename from thunk.c
rename to linux-user/thunk.c
diff --git a/linux-user/meson.build b/linux-user/meson.build
index bf9d945504..fcf7d40f23 100644
--- a/linux-user/meson.build
+++ b/linux-user/meson.build
@@ -15,6 +15,7 @@ linux_user_ss.add(files(
   'signal.c',
   'strace.c',
   'syscall.c',
+  'thunk.c',
   'uaccess.c',
   'uname.c',
 ))
-- 
2.25.1

Re: [PATCH v5 15/17] linux-user: Move thunk.c from top-level

Posted by Philippe Mathieu-Daudé 4 years, 2 months ago

On 11/17/21 17:04, Richard Henderson wrote:
> So far, linux-user is the only user of these functions.
> Clean up the build machinery by restricting it to linux-user.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  meson.build                   | 1 -
>  thunk.c => linux-user/thunk.c | 0
>  linux-user/meson.build        | 1 +
>  3 files changed, 1 insertion(+), 1 deletion(-)
>  rename thunk.c => linux-user/thunk.c (100%)

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH v5 15/17] linux-user: Move thunk.c from top-level

Posted by Warner Losh 4 years, 2 months ago

On Wed, Nov 17, 2021 at 9:04 AM Richard Henderson <
richard.henderson@linaro.org> wrote:

> So far, linux-user is the only user of these functions.
> Clean up the build machinery by restricting it to linux-user.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  meson.build                   | 1 -
>  thunk.c => linux-user/thunk.c | 0
>  linux-user/meson.build        | 1 +
>  3 files changed, 1 insertion(+), 1 deletion(-)
>  rename thunk.c => linux-user/thunk.c (100%)
>

Reviewed-by: Warner Losh <imp@bsdimp.com>


> diff --git a/meson.build b/meson.build
> index 387f7fe1c9..9f59c57909 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2614,7 +2614,6 @@ subdir('linux-user')
>
>  specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
>
> -linux_user_ss.add(files('thunk.c'))
>  specific_ss.add_all(when: 'CONFIG_LINUX_USER', if_true: linux_user_ss)
>
>  common_user_ss = common_user_ss.apply(config_all, strict: false)
> diff --git a/thunk.c b/linux-user/thunk.c
> similarity index 100%
> rename from thunk.c
> rename to linux-user/thunk.c
> diff --git a/linux-user/meson.build b/linux-user/meson.build
> index bf9d945504..fcf7d40f23 100644
> --- a/linux-user/meson.build
> +++ b/linux-user/meson.build
> @@ -15,6 +15,7 @@ linux_user_ss.add(files(
>    'signal.c',
>    'strace.c',
>    'syscall.c',
> +  'thunk.c',
>    'uaccess.c',
>    'uname.c',
>  ))
> --
> 2.25.1
>
>