hw/net/rocker: Remove unused definitions

[PATCH-for-7.0] hw/net/rocker: Remove unused definitions

Posted by Philippe Mathieu-Daudé 2 years, 5 months ago

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/net/rocker/rocker.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
index 412fa44d017..d22bbd2bf80 100644
--- a/hw/net/rocker/rocker.h
+++ b/hw/net/rocker/rocker.h
@@ -36,13 +36,8 @@ static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...)
 }
 #endif
 
-#define __le16 uint16_t
-#define __le32 uint32_t
-#define __le64 uint64_t
-
 #define __be16 uint16_t
 #define __be32 uint32_t
-#define __be64 uint64_t
 
 static inline bool ipv4_addr_is_multicast(__be32 addr)
 {
-- 
2.31.1

Re: [PATCH-for-7.0] hw/net/rocker: Remove unused definitions

Posted by Richard Henderson 2 years, 4 months ago

On 11/16/21 11:39 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   hw/net/rocker/rocker.h | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
> index 412fa44d017..d22bbd2bf80 100644
> --- a/hw/net/rocker/rocker.h
> +++ b/hw/net/rocker/rocker.h
> @@ -36,13 +36,8 @@ static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...)
>   }
>   #endif
>   
> -#define __le16 uint16_t
> -#define __le32 uint32_t
> -#define __le64 uint64_t
> -
>   #define __be16 uint16_t
>   #define __be32 uint32_t
> -#define __be64 uint64_t

Surely the __beN defines should go away as well.
If they're still used, that seems like a bug itself.


r~

Re: [PATCH-for-7.0] hw/net/rocker: Remove unused definitions

Posted by Philippe Mathieu-Daudé 2 years, 4 months ago

ping for review?

On 11/16/21 20:39, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/net/rocker/rocker.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/hw/net/rocker/rocker.h b/hw/net/rocker/rocker.h
> index 412fa44d017..d22bbd2bf80 100644
> --- a/hw/net/rocker/rocker.h
> +++ b/hw/net/rocker/rocker.h
> @@ -36,13 +36,8 @@ static inline GCC_FMT_ATTR(1, 2) int DPRINTF(const char *fmt, ...)
>  }
>  #endif
>  
> -#define __le16 uint16_t
> -#define __le32 uint32_t
> -#define __le64 uint64_t
> -
>  #define __be16 uint16_t
>  #define __be32 uint32_t
> -#define __be64 uint64_t
>  
>  static inline bool ipv4_addr_is_multicast(__be32 addr)
>  {
>