[v2] linux-user: Fix getdents alignment issues (#704)

[PATCH v2 0/4] linux-user: Fix getdents alignment issues (#704)

Richard Henderson posted 4 patches 2 years, 6 months ago

Diff against v1
Download series mbox

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211114103539.298686-1-richard.henderson@linaro.org

Maintainers: Laurent Vivier <laurent@vivier.eu>

linux-user/syscall_defs.h |  12 +-
linux-user/syscall.c      | 314 +++++++++++++++++++-------------------
2 files changed, 165 insertions(+), 161 deletions(-)

Expand all Fold all

[PATCH v2 0/4] linux-user: Fix getdents alignment issues (#704)

Posted by Richard Henderson 2 years, 6 months ago

There are a number of alignement issues flagged up by clang,
this attempts to fix only one of them: getdents.

Changes for v2:
  * Do not QEMU_BUILD_BUG_ON for size mismatch,
    as this triggers for i386 host.


r~

Richard Henderson (4):
  linux-user: Split out do_getdents, do_getdents64
  linux-user: Always use flexible arrays for dirent d_name
  linux-user: Fix member types of target_dirent64
  linux-user: Rewrite do_getdents, do_getdents64

 linux-user/syscall_defs.h |  12 +-
 linux-user/syscall.c      | 314 +++++++++++++++++++-------------------
 2 files changed, 165 insertions(+), 161 deletions(-)

-- 
2.25.1

Re: [PATCH v2 0/4] linux-user: Fix getdents alignment issues (#704)

Posted by Laurent Vivier 2 years, 5 months ago

Le 14/11/2021 à 11:35, Richard Henderson a écrit :
> There are a number of alignement issues flagged up by clang,
> this attempts to fix only one of them: getdents.
> 
> Changes for v2:
>    * Do not QEMU_BUILD_BUG_ON for size mismatch,
>      as this triggers for i386 host.
> 
> 
> r~
> 
> Richard Henderson (4):
>    linux-user: Split out do_getdents, do_getdents64
>    linux-user: Always use flexible arrays for dirent d_name
>    linux-user: Fix member types of target_dirent64
>    linux-user: Rewrite do_getdents, do_getdents64
> 
>   linux-user/syscall_defs.h |  12 +-
>   linux-user/syscall.c      | 314 +++++++++++++++++++-------------------
>   2 files changed, 165 insertions(+), 161 deletions(-)
> 


Applied to my linux-user-for-6.2 branch.

Thanks,
Laurent