1. Patchew
  2. QEMU
  3. [RFC v2 0/6] linux-user: simplify safe signal handling
  4. View patch

[RFC v2 5/6] common-user/host/mips: create, though mips hosts likely don't work reliably

Warner Losh posted 6 patches 4 years, 2 months ago
Maintainers: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Laurent Vivier <laurent@vivier.eu>
There is a newer version of this series
[RFC v2 5/6] common-user/host/mips: create, though mips hosts likely don't work reliably
Posted by Warner Losh 4 years, 2 months ago 
Signed-off-by: Warner Losh <imp@bsdimp.com>
---
 common-user/host/mips/safe-syscall.inc.S | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 common-user/host/mips/safe-syscall.inc.S

diff --git a/common-user/host/mips/safe-syscall.inc.S b/common-user/host/mips/safe-syscall.inc.S
new file mode 100644
index 0000000000..72d9064acb
--- /dev/null
+++ b/common-user/host/mips/safe-syscall.inc.S
@@ -0,0 +1 @@
+	.asciiz	"This file is not compiled and mips hosts are likely broken"
-- 
2.33.0
Re: [RFC v2 5/6] common-user/host/mips: create, though mips hosts likely don't work reliably
Posted by Richard Henderson 4 years, 2 months ago 
On 11/10/21 5:31 PM, Warner Losh wrote:
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
>   common-user/host/mips/safe-syscall.inc.S | 1 +
>   1 file changed, 1 insertion(+)
>   create mode 100644 common-user/host/mips/safe-syscall.inc.S
> 
> diff --git a/common-user/host/mips/safe-syscall.inc.S b/common-user/host/mips/safe-syscall.inc.S
> new file mode 100644
> index 0000000000..72d9064acb
> --- /dev/null
> +++ b/common-user/host/mips/safe-syscall.inc.S
> @@ -0,0 +1 @@
> +	.asciiz	"This file is not compiled and mips hosts are likely broken"
> 

Let's not include this.  I have created

   https://gitlab.com/qemu-project/qemu/-/issues/713

for tracking.


r~
Re: [RFC v2 5/6] common-user/host/mips: create, though mips hosts likely don't work reliably
Posted by Warner Losh 4 years, 2 months ago 
On Wed, Nov 10, 2021 at 10:00 AM Richard Henderson <
richard.henderson@linaro.org> wrote:

> On 11/10/21 5:31 PM, Warner Losh wrote:
> > Signed-off-by: Warner Losh <imp@bsdimp.com>
> > ---
> >   common-user/host/mips/safe-syscall.inc.S | 1 +
> >   1 file changed, 1 insertion(+)
> >   create mode 100644 common-user/host/mips/safe-syscall.inc.S
> >
> > diff --git a/common-user/host/mips/safe-syscall.inc.S
> b/common-user/host/mips/safe-syscall.inc.S
> > new file mode 100644
> > index 0000000000..72d9064acb
> > --- /dev/null
> > +++ b/common-user/host/mips/safe-syscall.inc.S
> > @@ -0,0 +1 @@
> > +     .asciiz "This file is not compiled and mips hosts are likely
> broken"
> >
>
> Let's not include this.  I have created
>
>    https://gitlab.com/qemu-project/qemu/-/issues/713
>
> for tracking.
>

Without including it, the mips CI jobs will fail. If you are OK with this
and dealing with that
issue in another way, then I'll drop it. It's easy enough.

Warner

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.