tests/avocado: Remove p7zip binary availability check

[PATCH] tests/avocado: Remove p7zip binary availability check

Posted by Philippe Mathieu-Daudé 2 years, 6 months ago

The single use of the 7z binary has been removed in commit a30e114f3
("tests/acceptance: remove Armbian 19.11.3 test for orangepi-pc"),
we don't need to check for this binary availability anymore.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Based-on: <20211105155354.154864-1-willianr@redhat.com>
---
 tests/avocado/boot_linux_console.py | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
index 4ed01ed7893..9c618d4809f 100644
--- a/tests/avocado/boot_linux_console.py
+++ b/tests/avocado/boot_linux_console.py
@@ -22,13 +22,6 @@
 from avocado_qemu import wait_for_console_pattern
 from avocado.utils import process
 from avocado.utils import archive
-from avocado.utils.path import find_command, CmdNotFoundError
-
-P7ZIP_AVAILABLE = True
-try:
-    find_command('7z')
-except CmdNotFoundError:
-    P7ZIP_AVAILABLE = False
 
 """
 Round up to next power of 2
-- 
2.31.1

Re: [PATCH] tests/avocado: Remove p7zip binary availability check

Posted by Joaquin de Andres 2 years, 6 months ago

On 11/6/21 10:10, Philippe Mathieu-Daudé wrote:
> The single use of the 7z binary has been removed in commit a30e114f3
> ("tests/acceptance: remove Armbian 19.11.3 test for orangepi-pc"),
> we don't need to check for this binary availability anymore.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20211105155354.154864-1-willianr@redhat.com>
> ---
>   tests/avocado/boot_linux_console.py | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/tests/avocado/boot_linux_console.py b/tests/avocado/boot_linux_console.py
> index 4ed01ed7893..9c618d4809f 100644
> --- a/tests/avocado/boot_linux_console.py
> +++ b/tests/avocado/boot_linux_console.py
> @@ -22,13 +22,6 @@
>   from avocado_qemu import wait_for_console_pattern
>   from avocado.utils import process
>   from avocado.utils import archive
> -from avocado.utils.path import find_command, CmdNotFoundError
> -
> -P7ZIP_AVAILABLE = True
> -try:
> -    find_command('7z')
> -except CmdNotFoundError:
> -    P7ZIP_AVAILABLE = False
>   
>   """
>   Round up to next power of 2
> 

Reviewed-by: Joaquin de Andres <me@xcancerberox.com.ar>

Re: [PATCH] tests/avocado: Remove p7zip binary availability check

Posted by Philippe Mathieu-Daudé 2 years, 6 months ago

On 11/6/21 10:10, Philippe Mathieu-Daudé wrote:
> The single use of the 7z binary has been removed in commit a30e114f3
> ("tests/acceptance: remove Armbian 19.11.3 test for orangepi-pc"),
> we don't need to check for this binary availability anymore.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20211105155354.154864-1-willianr@redhat.com>
> ---
>  tests/avocado/boot_linux_console.py | 7 -------
>  1 file changed, 7 deletions(-)

Patch queued to avocado-next.

Re: [PATCH] tests/avocado: Remove p7zip binary availability check

Posted by Willian Rampazzo 2 years, 6 months ago

On Sat, Nov 6, 2021 at 3:14 PM Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> The single use of the 7z binary has been removed in commit a30e114f3
> ("tests/acceptance: remove Armbian 19.11.3 test for orangepi-pc"),
> we don't need to check for this binary availability anymore.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20211105155354.154864-1-willianr@redhat.com>
> ---
>  tests/avocado/boot_linux_console.py | 7 -------
>  1 file changed, 7 deletions(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>