docs: adjust for demise of scripts/create_config

[PATCH] docs: adjust for demise of scripts/create_config

Paolo Bonzini posted 1 patch 2 years, 6 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211105124656.512471-1-pbonzini@redhat.com

Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>

docs/devel/build-system.rst | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH] docs: adjust for demise of scripts/create_config

Posted by Paolo Bonzini 2 years, 6 months ago

The config-host.h, $TARGET-NAME/config-target.h, $TARGET-NAME/config-devices.h files
are now generated by configure_file() rather than scripts/create_config.  Adjust
the relevant paragraph in docs/devel/build-system.rst, and take the occasion to
fix a preexisting confusion of *.h vs *.mak.

Reported-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 docs/devel/build-system.rst | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/docs/devel/build-system.rst b/docs/devel/build-system.rst
index 08f49c845d..1a82ce0b9a 100644
--- a/docs/devel/build-system.rst
+++ b/docs/devel/build-system.rst
@@ -463,11 +463,10 @@ Built by Meson:
   scripts/make_device_config.sh program, feeding it the
   default-configs/$TARGET-NAME file as input.
 
-``config-host.h``, ``$TARGET-NAME/config-target.h``, ``$TARGET-NAME/config-devices.h``
-  These files are used by source code to determine what features
-  are enabled.  They are generated from the contents of the corresponding
-  ``*.h`` files using the scripts/create_config program. This extracts
-  relevant variables and formats them as C preprocessor macros.
+``config-host.h``, ``$TARGET_NAME-config-target.h``, ``$TARGET_NAME-config-devices.h``
+  These files are used by source code to determine what features are
+  enabled.  They are generated from the contents of the corresponding
+  ``*.mak`` files using Meson's ``configure_file()`` function.
 
 ``build.ninja``
   The build rules.
-- 
2.33.1

Re: [PATCH] docs: adjust for demise of scripts/create_config

Posted by Markus Armbruster 2 years, 6 months ago

Paolo Bonzini <pbonzini@redhat.com> writes:

> The config-host.h, $TARGET-NAME/config-target.h, $TARGET-NAME/config-devices.h files
> are now generated by configure_file() rather than scripts/create_config.  Adjust
> the relevant paragraph in docs/devel/build-system.rst, and take the occasion to
> fix a preexisting confusion of *.h vs *.mak.

Please wrap commit messages around column 70.

>
> Reported-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks!

Reviewed-by: Markus Armbruster <armbru@redhat.com>