[PATCH] configure: fix --audio-drv-list help message

Paolo Bonzini posted 1 patch 2 years, 6 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211102135645.213417-1-pbonzini@redhat.com
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] configure: fix --audio-drv-list help message
Posted by Paolo Bonzini 2 years, 6 months ago
--audio-drv-list is now establishing which audio drivers to try if -audiodev
is not used; drivers for -audiodev are configured with --enable/--disable
options or possibly --without-default-features.  Adjust the help message
for --audio-drv-list.

Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 4c444e1750..97fee368ee 100755
--- a/configure
+++ b/configure
@@ -1390,7 +1390,7 @@ Advanced options (experts only):
   --disable-strip          disable stripping binaries
   --disable-werror         disable compilation abort on warning
   --disable-stack-protector disable compiler-provided stack protection
-  --audio-drv-list=LIST    set audio drivers list
+  --audio-drv-list=LIST    set audio drivers to try if -audiodev is not used
   --block-drv-whitelist=L  Same as --block-drv-rw-whitelist=L
   --block-drv-rw-whitelist=L
                            set block driver read-write whitelist
-- 
2.31.1


Re: [PATCH] configure: fix --audio-drv-list help message
Posted by Peter Maydell 2 years, 6 months ago
On Tue, 2 Nov 2021 at 13:56, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> --audio-drv-list is now establishing which audio drivers to try if -audiodev
> is not used; drivers for -audiodev are configured with --enable/--disable
> options or possibly --without-default-features.  Adjust the help message
> for --audio-drv-list.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 4c444e1750..97fee368ee 100755
> --- a/configure
> +++ b/configure
> @@ -1390,7 +1390,7 @@ Advanced options (experts only):
>    --disable-strip          disable stripping binaries
>    --disable-werror         disable compilation abort on warning
>    --disable-stack-protector disable compiler-provided stack protection
> -  --audio-drv-list=LIST    set audio drivers list
> +  --audio-drv-list=LIST    set audio drivers to try if -audiodev is not used
>    --block-drv-whitelist=L  Same as --block-drv-rw-whitelist=L
>    --block-drv-rw-whitelist=L
>                             set block driver read-write whitelist

Would --default-audio-drv-list=LIST be a better choice for
an option with these semantics ?

-- PMM