Deprecate -watchdog, cleanup -watchdog-action

[PATCH 0/3] Deprecate -watchdog, cleanup -watchdog-action

Paolo Bonzini posted 3 patches 4 years, 3 months ago

Download series mbox

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211027131239.802564-1-pbonzini@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Andrew Jeffery <andrew@aj.id.au>, "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Christian Borntraeger <borntraeger@de.ibm.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Thomas Huth <thuth@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Joel Stanley <joel@jms.id.au>, "Daniel P. Berrangé" <berrange@redhat.com>

docs/about/deprecated.rst  |  5 +++++
hw/watchdog/sbsa_gwdt.c    |  3 ++-
hw/watchdog/watchdog.c     | 14 --------------
hw/watchdog/wdt_aspeed.c   |  3 ++-
hw/watchdog/wdt_diag288.c  |  3 ++-
hw/watchdog/wdt_i6300esb.c |  3 ++-
hw/watchdog/wdt_ib700.c    |  3 ++-
hw/watchdog/wdt_imx2.c     |  4 ++--
include/hw/qdev-core.h     |  1 +
include/sysemu/watchdog.h  |  1 -
monitor/misc.c             | 15 ++++++++++++---
softmmu/qdev-monitor.c     |  1 +
softmmu/vl.c               | 11 ++++++-----
13 files changed, 37 insertions(+), 30 deletions(-)

Expand all Fold all

[PATCH 0/3] Deprecate -watchdog, cleanup -watchdog-action

Posted by Paolo Bonzini 4 years, 3 months ago

-watchdog is a simple wrapper around -device, but it includes quite
a bit of code to register and list available watchdog devices.
Add a category for watchdogs so that they are listed as such in
'-device help', and deprecate it.

For -watchdog-action, make it 100% a shortcut for "-action watchdog",
instead of calling into watchdog.c from the command line parser.
This is a small improvement because "-watchdog-action" and "-action
watchdog" now override each other based on the position on the
command line; previously, "-action watchdog" always won.

Paolo Bonzini (3):
  watchdog: add information from -watchdog help to -device help
  vl: deprecate -watchdog
  watchdog: remove select_watchdog_action

 docs/about/deprecated.rst  |  5 +++++
 hw/watchdog/sbsa_gwdt.c    |  3 ++-
 hw/watchdog/watchdog.c     | 14 --------------
 hw/watchdog/wdt_aspeed.c   |  3 ++-
 hw/watchdog/wdt_diag288.c  |  3 ++-
 hw/watchdog/wdt_i6300esb.c |  3 ++-
 hw/watchdog/wdt_ib700.c    |  3 ++-
 hw/watchdog/wdt_imx2.c     |  4 ++--
 include/hw/qdev-core.h     |  1 +
 include/sysemu/watchdog.h  |  1 -
 monitor/misc.c             | 15 ++++++++++++---
 softmmu/qdev-monitor.c     |  1 +
 softmmu/vl.c               | 11 ++++++-----
 13 files changed, 37 insertions(+), 30 deletions(-)

-- 
2.31.1