1 | The following changes since commit afc9fcde55296b83f659de9da3cdf044812a6eeb: | 1 | The following changes since commit 804b30d25f8d70dc2dea951883ea92235274a50c: |
---|---|---|---|
2 | 2 | ||
3 | Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-10-20 06:10:51 -0700) | 3 | Merge remote-tracking branch 'remotes/legoater/tags/pull-ppc-20220130' into staging (2022-01-31 11:10:08 +0000) |
4 | 4 | ||
5 | are available in the Git repository at: | 5 | are available in the Git repository at: |
6 | 6 | ||
7 | https://gitlab.com/stefanha/qemu.git tags/block-pull-request | 7 | https://gitlab.com/hreitz/qemu.git tags/pull-block-2022-02-01 |
8 | 8 | ||
9 | for you to fetch changes up to 4b2b3d2653f255ef4259a7689af1956536565901: | 9 | for you to fetch changes up to 751486c18555169ca4baf59440275d5831140822: |
10 | 10 | ||
11 | coroutine: resize pool periodically instead of limiting size (2021-10-21 18:40:07 +0100) | 11 | block.h: remove outdated comment (2022-02-01 13:28:53 +0100) |
12 | 12 | ||
13 | ---------------------------------------------------------------- | 13 | ---------------------------------------------------------------- |
14 | Pull request | 14 | Block patches: |
15 | 15 | - Add support to the iotests to test qcow2's zstd compression mode | |
16 | Performance optimization when guest applications submit a lot of parallel I/O. | 16 | - Fix post-migration block node permissions |
17 | This has also been found to improve clang SafeStack performance. | 17 | - iotests fixes (051 and mirror-ready-cancel-error) |
18 | - Remove an outdated comment | ||
18 | 19 | ||
19 | ---------------------------------------------------------------- | 20 | ---------------------------------------------------------------- |
21 | Emanuele Giuseppe Esposito (1): | ||
22 | block.h: remove outdated comment | ||
20 | 23 | ||
21 | Stefan Hajnoczi (1): | 24 | Hanna Reitz (3): |
22 | coroutine: resize pool periodically instead of limiting size | 25 | iotests/MRCE: Write data to source |
26 | block-backend: Retain permissions after migration | ||
27 | iotests/migration-permissions: New test | ||
23 | 28 | ||
24 | include/qemu/coroutine-pool-timer.h | 36 ++++++++++++++++ | 29 | Thomas Huth (1): |
25 | include/qemu/coroutine.h | 7 ++++ | 30 | tests/qemu-iotests: Fix 051 for binaries without 'lsi53c895a' |
26 | iothread.c | 6 +++ | 31 | |
27 | util/coroutine-pool-timer.c | 35 ++++++++++++++++ | 32 | Vladimir Sementsov-Ogievskiy (19): |
28 | util/main-loop.c | 5 +++ | 33 | iotests.py: img_info_log(): rename imgopts argument |
29 | util/qemu-coroutine.c | 64 ++++++++++++++++------------- | 34 | iotests.py: implement unsupported_imgopts |
30 | util/meson.build | 1 + | 35 | iotests: specify some unsupported_imgopts for python iotests |
31 | 7 files changed, 125 insertions(+), 29 deletions(-) | 36 | iotests.py: qemu_img*("create"): support |
32 | create mode 100644 include/qemu/coroutine-pool-timer.h | 37 | IMGOPTS='compression_type=zstd' |
33 | create mode 100644 util/coroutine-pool-timer.c | 38 | iotests: drop qemu_img_verbose() helper |
39 | iotests.py: rewrite default luks support in qemu_img | ||
40 | iotest 303: explicit compression type | ||
41 | iotest 065: explicit compression type | ||
42 | iotests.py: filter out successful output of qemu-img create | ||
43 | iotests.py: filter compression type out | ||
44 | iotest 302: use img_info_log() helper | ||
45 | qcow2: simple case support for downgrading of qcow2 images with zstd | ||
46 | iotests/common.rc: introduce _qcow2_dump_header helper | ||
47 | iotests: massive use _qcow2_dump_header | ||
48 | iotest 39: use _qcow2_dump_header | ||
49 | iotests: bash tests: filter compression type | ||
50 | iotests 60: more accurate set dirty bit in qcow2 header | ||
51 | iotest 214: explicit compression type | ||
52 | iotests: declare lack of support for compresion_type in IMGOPTS | ||
53 | |||
54 | include/block/block.h | 1 - | ||
55 | block/block-backend.c | 11 ++ | ||
56 | block/qcow2.c | 58 +++++++++- | ||
57 | tests/qemu-iotests/031 | 11 +- | ||
58 | tests/qemu-iotests/036 | 6 +- | ||
59 | tests/qemu-iotests/039 | 22 ++-- | ||
60 | tests/qemu-iotests/044 | 8 +- | ||
61 | tests/qemu-iotests/044.out | 1 + | ||
62 | tests/qemu-iotests/051 | 9 +- | ||
63 | tests/qemu-iotests/060 | 22 ++-- | ||
64 | tests/qemu-iotests/060.out | 2 +- | ||
65 | tests/qemu-iotests/061 | 42 ++++---- | ||
66 | tests/qemu-iotests/061.out | 12 +-- | ||
67 | tests/qemu-iotests/065 | 19 ++-- | ||
68 | tests/qemu-iotests/082.out | 14 +-- | ||
69 | tests/qemu-iotests/112 | 3 +- | ||
70 | tests/qemu-iotests/137 | 2 +- | ||
71 | tests/qemu-iotests/149.out | 21 ---- | ||
72 | tests/qemu-iotests/163 | 3 +- | ||
73 | tests/qemu-iotests/165 | 3 +- | ||
74 | tests/qemu-iotests/196 | 3 +- | ||
75 | tests/qemu-iotests/198.out | 4 +- | ||
76 | tests/qemu-iotests/206.out | 10 +- | ||
77 | tests/qemu-iotests/209 | 7 +- | ||
78 | tests/qemu-iotests/209.out | 2 + | ||
79 | tests/qemu-iotests/210 | 8 +- | ||
80 | tests/qemu-iotests/214 | 2 +- | ||
81 | tests/qemu-iotests/237.out | 3 - | ||
82 | tests/qemu-iotests/242 | 3 +- | ||
83 | tests/qemu-iotests/242.out | 10 +- | ||
84 | tests/qemu-iotests/246 | 3 +- | ||
85 | tests/qemu-iotests/254 | 3 +- | ||
86 | tests/qemu-iotests/255.out | 4 - | ||
87 | tests/qemu-iotests/260 | 3 +- | ||
88 | tests/qemu-iotests/274 | 3 +- | ||
89 | tests/qemu-iotests/274.out | 39 +------ | ||
90 | tests/qemu-iotests/280.out | 1 - | ||
91 | tests/qemu-iotests/281 | 3 +- | ||
92 | tests/qemu-iotests/287 | 8 +- | ||
93 | tests/qemu-iotests/290 | 2 +- | ||
94 | tests/qemu-iotests/296.out | 10 +- | ||
95 | tests/qemu-iotests/302 | 4 +- | ||
96 | tests/qemu-iotests/302.out | 7 +- | ||
97 | tests/qemu-iotests/303 | 26 +++-- | ||
98 | tests/qemu-iotests/303.out | 30 +++++- | ||
99 | tests/qemu-iotests/common.filter | 8 ++ | ||
100 | tests/qemu-iotests/common.rc | 22 ++++ | ||
101 | tests/qemu-iotests/iotests.py | 99 +++++++++++------ | ||
102 | .../tests/migrate-bitmaps-postcopy-test | 3 +- | ||
103 | tests/qemu-iotests/tests/migrate-bitmaps-test | 3 +- | ||
104 | .../qemu-iotests/tests/migration-permissions | 101 ++++++++++++++++++ | ||
105 | .../tests/migration-permissions.out | 5 + | ||
106 | .../tests/mirror-ready-cancel-error | 7 +- | ||
107 | .../tests/remove-bitmap-from-backing | 3 +- | ||
108 | 54 files changed, 483 insertions(+), 236 deletions(-) | ||
109 | create mode 100755 tests/qemu-iotests/tests/migration-permissions | ||
110 | create mode 100644 tests/qemu-iotests/tests/migration-permissions.out | ||
34 | 111 | ||
35 | -- | 112 | -- |
36 | 2.31.1 | 113 | 2.34.1 |
37 | 114 | ||
38 | 115 | ||
39 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Thomas Huth <thuth@redhat.com> | ||
1 | 2 | ||
3 | The lsi53c895a SCSI adaptor might not be enabled in each and every | ||
4 | x86 QEMU binary, e.g. it's disabled in the RHEL/CentOS build. | ||
5 | Thus let's add a check to the 051 test so that it does not fail if | ||
6 | this device is not available. | ||
7 | |||
8 | Signed-off-by: Thomas Huth <thuth@redhat.com> | ||
9 | Message-Id: <20211206143404.247032-1-thuth@redhat.com> | ||
10 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
11 | --- | ||
12 | tests/qemu-iotests/051 | 4 ++++ | ||
13 | 1 file changed, 4 insertions(+) | ||
14 | |||
15 | diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 | ||
16 | index XXXXXXX..XXXXXXX 100755 | ||
17 | --- a/tests/qemu-iotests/051 | ||
18 | +++ b/tests/qemu-iotests/051 | ||
19 | @@ -XXX,XX +XXX,XX @@ _supported_proto file | ||
20 | _unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' data_file | ||
21 | _require_drivers nbd | ||
22 | |||
23 | +if [ "$QEMU_DEFAULT_MACHINE" = "pc" ]; then | ||
24 | + _require_devices lsi53c895a | ||
25 | +fi | ||
26 | + | ||
27 | do_run_qemu() | ||
28 | { | ||
29 | echo Testing: "$@" | ||
30 | -- | ||
31 | 2.34.1 | ||
32 | |||
33 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | This test assumes that mirror flushes the source when entering the READY | ||
2 | state, and that the format level will pass that flush on to the protocol | ||
3 | level (where we intercept it with blkdebug). | ||
1 | 4 | ||
5 | However, apparently that does not happen when using a VMDK image with | ||
6 | zeroed_grain=on, which actually is the default set by testenv.py. Right | ||
7 | now, Python tests ignore IMGOPTS, though, so this has no effect; but | ||
8 | Vladimir has a series that will change this, so we need to fix this test | ||
9 | before that series lands. | ||
10 | |||
11 | We can fix it by writing data to the source before we start the mirror | ||
12 | job; apparently that makes the (VMDK) format layer change its mind and | ||
13 | pass on the pre-READY flush to the protocol level, so the test passes | ||
14 | again. (I presume, without any data written, mirror just does a 64M | ||
15 | zero write on the target, which VMDK with zeroed_grain=on basically just | ||
16 | ignores.) | ||
17 | |||
18 | Without this, we do not get a flush, and so blkdebug only sees a single | ||
19 | flush at the end of the job instead of two, and therefore does not | ||
20 | inject an error, which makes the block job complete instead of raising | ||
21 | an error. | ||
22 | |||
23 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
24 | Message-Id: <20211223165308.103793-1-hreitz@redhat.com> | ||
25 | Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
26 | --- | ||
27 | tests/qemu-iotests/tests/mirror-ready-cancel-error | 7 ++++++- | ||
28 | 1 file changed, 6 insertions(+), 1 deletion(-) | ||
29 | |||
30 | diff --git a/tests/qemu-iotests/tests/mirror-ready-cancel-error b/tests/qemu-iotests/tests/mirror-ready-cancel-error | ||
31 | index XXXXXXX..XXXXXXX 100755 | ||
32 | --- a/tests/qemu-iotests/tests/mirror-ready-cancel-error | ||
33 | +++ b/tests/qemu-iotests/tests/mirror-ready-cancel-error | ||
34 | @@ -XXX,XX +XXX,XX @@ class TestMirrorReadyCancelError(iotests.QMPTestCase): | ||
35 | assert iotests.qemu_img_create('-f', iotests.imgfmt, target, | ||
36 | str(image_size)) == 0 | ||
37 | |||
38 | + # Ensure that mirror will copy something before READY so the | ||
39 | + # target format layer will forward the pre-READY flush to its | ||
40 | + # file child | ||
41 | + assert iotests.qemu_io_silent('-c', 'write -P 1 0 64k', source) == 0 | ||
42 | + | ||
43 | self.vm = iotests.VM() | ||
44 | self.vm.launch() | ||
45 | |||
46 | @@ -XXX,XX +XXX,XX @@ class TestMirrorReadyCancelError(iotests.QMPTestCase): | ||
47 | # Write something so will not leave the job immediately, but | ||
48 | # flush first (which will fail, thanks to blkdebug) | ||
49 | res = self.vm.qmp('human-monitor-command', | ||
50 | - command_line='qemu-io mirror-top "write 0 64k"') | ||
51 | + command_line='qemu-io mirror-top "write -P 2 0 64k"') | ||
52 | self.assert_qmp(res, 'return', '') | ||
53 | |||
54 | # Drain status change events | ||
55 | -- | ||
56 | 2.34.1 | ||
57 | |||
58 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | We are going to support IMGOPTS environment variable like in bash | ||
4 | tests. Corresponding global variable in iotests.py should be called | ||
5 | imgopts. So to not interfere with function argument, rename it in | ||
6 | advance. | ||
7 | |||
8 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
9 | Reviewed-by: Max Reitz <mreitz@redhat.com> | ||
10 | Message-Id: <20211223160144.1097696-2-vsementsov@virtuozzo.com> | ||
11 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
12 | --- | ||
13 | tests/qemu-iotests/210 | 8 ++++---- | ||
14 | tests/qemu-iotests/iotests.py | 5 +++-- | ||
15 | 2 files changed, 7 insertions(+), 6 deletions(-) | ||
16 | |||
17 | diff --git a/tests/qemu-iotests/210 b/tests/qemu-iotests/210 | ||
18 | index XXXXXXX..XXXXXXX 100755 | ||
19 | --- a/tests/qemu-iotests/210 | ||
20 | +++ b/tests/qemu-iotests/210 | ||
21 | @@ -XXX,XX +XXX,XX @@ with iotests.FilePath('t.luks') as disk_path, \ | ||
22 | 'driver=luks,file.driver=file,file.filename=%s,key-secret=keysec0' % (disk_path), | ||
23 | filter_path=disk_path, | ||
24 | extra_args=['--object', 'secret,id=keysec0,data=foo'], | ||
25 | - imgopts=True) | ||
26 | + use_image_opts=True) | ||
27 | |||
28 | # | ||
29 | # Successful image creation (with non-default options) | ||
30 | @@ -XXX,XX +XXX,XX @@ with iotests.FilePath('t.luks') as disk_path, \ | ||
31 | 'driver=luks,file.driver=file,file.filename=%s,key-secret=keysec0' % (disk_path), | ||
32 | filter_path=disk_path, | ||
33 | extra_args=['--object', 'secret,id=keysec0,data=foo'], | ||
34 | - imgopts=True) | ||
35 | + use_image_opts=True) | ||
36 | |||
37 | # | ||
38 | # Invalid BlockdevRef | ||
39 | @@ -XXX,XX +XXX,XX @@ with iotests.FilePath('t.luks') as disk_path, \ | ||
40 | 'driver=luks,file.driver=file,file.filename=%s,key-secret=keysec0' % (disk_path), | ||
41 | filter_path=disk_path, | ||
42 | extra_args=['--object', 'secret,id=keysec0,data=foo'], | ||
43 | - imgopts=True) | ||
44 | + use_image_opts=True) | ||
45 | |||
46 | # | ||
47 | # Invalid sizes | ||
48 | @@ -XXX,XX +XXX,XX @@ with iotests.FilePath('t.luks') as disk_path, \ | ||
49 | 'driver=luks,file.driver=file,file.filename=%s,key-secret=keysec0' % (disk_path), | ||
50 | filter_path=disk_path, | ||
51 | extra_args=['--object', 'secret,id=keysec0,data=foo'], | ||
52 | - imgopts=True) | ||
53 | + use_image_opts=True) | ||
54 | diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py | ||
55 | index XXXXXXX..XXXXXXX 100644 | ||
56 | --- a/tests/qemu-iotests/iotests.py | ||
57 | +++ b/tests/qemu-iotests/iotests.py | ||
58 | @@ -XXX,XX +XXX,XX @@ def qemu_img_log(*args): | ||
59 | log(result, filters=[filter_testfiles]) | ||
60 | return result | ||
61 | |||
62 | -def img_info_log(filename, filter_path=None, imgopts=False, extra_args=()): | ||
63 | +def img_info_log(filename, filter_path=None, use_image_opts=False, | ||
64 | + extra_args=()): | ||
65 | args = ['info'] | ||
66 | - if imgopts: | ||
67 | + if use_image_opts: | ||
68 | args.append('--image-opts') | ||
69 | else: | ||
70 | args += ['-f', imgfmt] | ||
71 | -- | ||
72 | 2.34.1 | ||
73 | |||
74 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | We are going to support some addition IMGOPTS in python iotests like | ||
4 | in bash iotests. Similarly to bash iotests, we want a way to skip some | ||
5 | tests which can't work with specific IMGOPTS. | ||
6 | |||
7 | Globally for python iotests we will not support things like | ||
8 | 'data_file=$TEST_IMG.ext_data_file' in IMGOPTS, so, forbid this | ||
9 | globally in iotests.py. | ||
10 | |||
11 | Suggested-by: Hanna Reitz <hreitz@redhat.com> | ||
12 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
13 | Reviewed-by: Hanna Reitz <hreitz@redhat.com> | ||
14 | Message-Id: <20211223160144.1097696-3-vsementsov@virtuozzo.com> | ||
15 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
16 | --- | ||
17 | tests/qemu-iotests/iotests.py | 15 ++++++++++++++- | ||
18 | 1 file changed, 14 insertions(+), 1 deletion(-) | ||
19 | |||
20 | diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py | ||
21 | index XXXXXXX..XXXXXXX 100644 | ||
22 | --- a/tests/qemu-iotests/iotests.py | ||
23 | +++ b/tests/qemu-iotests/iotests.py | ||
24 | @@ -XXX,XX +XXX,XX @@ def _verify_virtio_scsi_pci_or_ccw() -> None: | ||
25 | notrun('Missing virtio-scsi-pci or virtio-scsi-ccw in QEMU binary') | ||
26 | |||
27 | |||
28 | +def _verify_imgopts(unsupported: Sequence[str] = ()) -> None: | ||
29 | + imgopts = os.environ.get('IMGOPTS') | ||
30 | + # One of usage examples for IMGOPTS is "data_file=$TEST_IMG.ext_data_file" | ||
31 | + # but it supported only for bash tests. We don't have a concept of global | ||
32 | + # TEST_IMG in iotests.py, not saying about somehow parsing $variables. | ||
33 | + # So, for simplicity let's just not support any IMGOPTS with '$' inside. | ||
34 | + unsup = list(unsupported) + ['$'] | ||
35 | + if imgopts and any(x in imgopts for x in unsup): | ||
36 | + notrun(f'not suitable for this imgopts: {imgopts}') | ||
37 | + | ||
38 | + | ||
39 | def supports_quorum(): | ||
40 | return 'quorum' in qemu_img_pipe('--help') | ||
41 | |||
42 | @@ -XXX,XX +XXX,XX @@ def execute_setup_common(supported_fmts: Sequence[str] = (), | ||
43 | unsupported_fmts: Sequence[str] = (), | ||
44 | supported_protocols: Sequence[str] = (), | ||
45 | unsupported_protocols: Sequence[str] = (), | ||
46 | - required_fmts: Sequence[str] = ()) -> bool: | ||
47 | + required_fmts: Sequence[str] = (), | ||
48 | + unsupported_imgopts: Sequence[str] = ()) -> bool: | ||
49 | """ | ||
50 | Perform necessary setup for either script-style or unittest-style tests. | ||
51 | |||
52 | @@ -XXX,XX +XXX,XX @@ def execute_setup_common(supported_fmts: Sequence[str] = (), | ||
53 | _verify_aio_mode(supported_aio_modes) | ||
54 | _verify_formats(required_fmts) | ||
55 | _verify_virtio_blk() | ||
56 | + _verify_imgopts(unsupported_imgopts) | ||
57 | |||
58 | return debug | ||
59 | |||
60 | -- | ||
61 | 2.34.1 | ||
62 | |||
63 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | 1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | |
2 | |||
3 | We are going to support IMGOPTS for python iotests. Still some iotests | ||
4 | will not work with common IMGOPTS used with bash iotests like | ||
5 | specifying refcount_bits and compat qcow2 options. So we | ||
6 | should define corresponding unsupported_imgopts for now. | ||
7 | |||
8 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
9 | Message-Id: <20211223160144.1097696-4-vsementsov@virtuozzo.com> | ||
10 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
11 | --- | ||
12 | tests/qemu-iotests/044 | 3 ++- | ||
13 | tests/qemu-iotests/065 | 3 ++- | ||
14 | tests/qemu-iotests/163 | 3 ++- | ||
15 | tests/qemu-iotests/165 | 3 ++- | ||
16 | tests/qemu-iotests/196 | 3 ++- | ||
17 | tests/qemu-iotests/242 | 3 ++- | ||
18 | tests/qemu-iotests/246 | 3 ++- | ||
19 | tests/qemu-iotests/254 | 3 ++- | ||
20 | tests/qemu-iotests/260 | 3 ++- | ||
21 | tests/qemu-iotests/274 | 3 ++- | ||
22 | tests/qemu-iotests/281 | 3 ++- | ||
23 | tests/qemu-iotests/303 | 3 ++- | ||
24 | tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 3 ++- | ||
25 | tests/qemu-iotests/tests/migrate-bitmaps-test | 3 ++- | ||
26 | tests/qemu-iotests/tests/remove-bitmap-from-backing | 3 ++- | ||
27 | 15 files changed, 30 insertions(+), 15 deletions(-) | ||
28 | |||
29 | diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 | ||
30 | index XXXXXXX..XXXXXXX 100755 | ||
31 | --- a/tests/qemu-iotests/044 | ||
32 | +++ b/tests/qemu-iotests/044 | ||
33 | @@ -XXX,XX +XXX,XX @@ class TestRefcountTableGrowth(iotests.QMPTestCase): | ||
34 | |||
35 | if __name__ == '__main__': | ||
36 | iotests.main(supported_fmts=['qcow2'], | ||
37 | - supported_protocols=['file']) | ||
38 | + supported_protocols=['file'], | ||
39 | + unsupported_imgopts=['refcount_bits']) | ||
40 | diff --git a/tests/qemu-iotests/065 b/tests/qemu-iotests/065 | ||
41 | index XXXXXXX..XXXXXXX 100755 | ||
42 | --- a/tests/qemu-iotests/065 | ||
43 | +++ b/tests/qemu-iotests/065 | ||
44 | @@ -XXX,XX +XXX,XX @@ TestQMP = None | ||
45 | |||
46 | if __name__ == '__main__': | ||
47 | iotests.main(supported_fmts=['qcow2'], | ||
48 | - supported_protocols=['file']) | ||
49 | + supported_protocols=['file'], | ||
50 | + unsupported_imgopts=['refcount_bits']) | ||
51 | diff --git a/tests/qemu-iotests/163 b/tests/qemu-iotests/163 | ||
52 | index XXXXXXX..XXXXXXX 100755 | ||
53 | --- a/tests/qemu-iotests/163 | ||
54 | +++ b/tests/qemu-iotests/163 | ||
55 | @@ -XXX,XX +XXX,XX @@ ShrinkBaseClass = None | ||
56 | |||
57 | if __name__ == '__main__': | ||
58 | iotests.main(supported_fmts=['raw', 'qcow2'], | ||
59 | - supported_protocols=['file']) | ||
60 | + supported_protocols=['file'], | ||
61 | + unsupported_imgopts=['compat']) | ||
62 | diff --git a/tests/qemu-iotests/165 b/tests/qemu-iotests/165 | ||
63 | index XXXXXXX..XXXXXXX 100755 | ||
64 | --- a/tests/qemu-iotests/165 | ||
65 | +++ b/tests/qemu-iotests/165 | ||
66 | @@ -XXX,XX +XXX,XX @@ class TestPersistentDirtyBitmap(iotests.QMPTestCase): | ||
67 | |||
68 | if __name__ == '__main__': | ||
69 | iotests.main(supported_fmts=['qcow2'], | ||
70 | - supported_protocols=['file']) | ||
71 | + supported_protocols=['file'], | ||
72 | + unsupported_imgopts=['compat']) | ||
73 | diff --git a/tests/qemu-iotests/196 b/tests/qemu-iotests/196 | ||
74 | index XXXXXXX..XXXXXXX 100755 | ||
75 | --- a/tests/qemu-iotests/196 | ||
76 | +++ b/tests/qemu-iotests/196 | ||
77 | @@ -XXX,XX +XXX,XX @@ class TestInvalidateAutoclear(iotests.QMPTestCase): | ||
78 | |||
79 | if __name__ == '__main__': | ||
80 | iotests.main(supported_fmts=['qcow2'], | ||
81 | - supported_protocols=['file']) | ||
82 | + supported_protocols=['file'], | ||
83 | + unsupported_imgopts=['compat']) | ||
84 | diff --git a/tests/qemu-iotests/242 b/tests/qemu-iotests/242 | ||
85 | index XXXXXXX..XXXXXXX 100755 | ||
86 | --- a/tests/qemu-iotests/242 | ||
87 | +++ b/tests/qemu-iotests/242 | ||
88 | @@ -XXX,XX +XXX,XX @@ from iotests import qemu_img_create, qemu_io, qemu_img_pipe, \ | ||
89 | file_path, img_info_log, log, filter_qemu_io | ||
90 | |||
91 | iotests.script_initialize(supported_fmts=['qcow2'], | ||
92 | - supported_protocols=['file']) | ||
93 | + supported_protocols=['file'], | ||
94 | + unsupported_imgopts=['refcount_bits', 'compat']) | ||
95 | |||
96 | disk = file_path('disk') | ||
97 | chunk = 256 * 1024 | ||
98 | diff --git a/tests/qemu-iotests/246 b/tests/qemu-iotests/246 | ||
99 | index XXXXXXX..XXXXXXX 100755 | ||
100 | --- a/tests/qemu-iotests/246 | ||
101 | +++ b/tests/qemu-iotests/246 | ||
102 | @@ -XXX,XX +XXX,XX @@ | ||
103 | import iotests | ||
104 | from iotests import log | ||
105 | |||
106 | -iotests.script_initialize(supported_fmts=['qcow2']) | ||
107 | +iotests.script_initialize(supported_fmts=['qcow2'], | ||
108 | + unsupported_imgopts=['compat']) | ||
109 | size = 64 * 1024 * 1024 * 1024 | ||
110 | gran_small = 32 * 1024 | ||
111 | gran_large = 128 * 1024 | ||
112 | diff --git a/tests/qemu-iotests/254 b/tests/qemu-iotests/254 | ||
113 | index XXXXXXX..XXXXXXX 100755 | ||
114 | --- a/tests/qemu-iotests/254 | ||
115 | +++ b/tests/qemu-iotests/254 | ||
116 | @@ -XXX,XX +XXX,XX @@ | ||
117 | import iotests | ||
118 | from iotests import qemu_img_create, file_path, log | ||
119 | |||
120 | -iotests.script_initialize(supported_fmts=['qcow2']) | ||
121 | +iotests.script_initialize(supported_fmts=['qcow2'], | ||
122 | + unsupported_imgopts=['compat']) | ||
123 | |||
124 | disk, top = file_path('disk', 'top') | ||
125 | size = 1024 * 1024 | ||
126 | diff --git a/tests/qemu-iotests/260 b/tests/qemu-iotests/260 | ||
127 | index XXXXXXX..XXXXXXX 100755 | ||
128 | --- a/tests/qemu-iotests/260 | ||
129 | +++ b/tests/qemu-iotests/260 | ||
130 | @@ -XXX,XX +XXX,XX @@ import iotests | ||
131 | from iotests import qemu_img_create, file_path, log, filter_qmp_event | ||
132 | |||
133 | iotests.script_initialize( | ||
134 | - supported_fmts=['qcow2'] | ||
135 | + supported_fmts=['qcow2'], | ||
136 | + unsupported_imgopts=['compat'] | ||
137 | ) | ||
138 | |||
139 | base, top = file_path('base', 'top') | ||
140 | diff --git a/tests/qemu-iotests/274 b/tests/qemu-iotests/274 | ||
141 | index XXXXXXX..XXXXXXX 100755 | ||
142 | --- a/tests/qemu-iotests/274 | ||
143 | +++ b/tests/qemu-iotests/274 | ||
144 | @@ -XXX,XX +XXX,XX @@ | ||
145 | import iotests | ||
146 | |||
147 | iotests.script_initialize(supported_fmts=['qcow2'], | ||
148 | - supported_platforms=['linux']) | ||
149 | + supported_platforms=['linux'], | ||
150 | + unsupported_imgopts=['refcount_bits', 'compat']) | ||
151 | |||
152 | size_short = 1 * 1024 * 1024 | ||
153 | size_long = 2 * 1024 * 1024 | ||
154 | diff --git a/tests/qemu-iotests/281 b/tests/qemu-iotests/281 | ||
155 | index XXXXXXX..XXXXXXX 100755 | ||
156 | --- a/tests/qemu-iotests/281 | ||
157 | +++ b/tests/qemu-iotests/281 | ||
158 | @@ -XXX,XX +XXX,XX @@ class TestBlockdevBackupAbort(iotests.QMPTestCase): | ||
159 | |||
160 | if __name__ == '__main__': | ||
161 | iotests.main(supported_fmts=['qcow2'], | ||
162 | - supported_protocols=['file']) | ||
163 | + supported_protocols=['file'], | ||
164 | + unsupported_imgopts=['compat']) | ||
165 | diff --git a/tests/qemu-iotests/303 b/tests/qemu-iotests/303 | ||
166 | index XXXXXXX..XXXXXXX 100755 | ||
167 | --- a/tests/qemu-iotests/303 | ||
168 | +++ b/tests/qemu-iotests/303 | ||
169 | @@ -XXX,XX +XXX,XX @@ import iotests | ||
170 | import subprocess | ||
171 | from iotests import qemu_img_create, qemu_io, file_path, log, filter_qemu_io | ||
172 | |||
173 | -iotests.script_initialize(supported_fmts=['qcow2']) | ||
174 | +iotests.script_initialize(supported_fmts=['qcow2'], | ||
175 | + unsupported_imgopts=['refcount_bits', 'compat']) | ||
176 | |||
177 | disk = file_path('disk') | ||
178 | chunk = 1024 * 1024 | ||
179 | diff --git a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | ||
180 | index XXXXXXX..XXXXXXX 100755 | ||
181 | --- a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | ||
182 | +++ b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | ||
183 | @@ -XXX,XX +XXX,XX @@ class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase): | ||
184 | |||
185 | |||
186 | if __name__ == '__main__': | ||
187 | - iotests.main(supported_fmts=['qcow2']) | ||
188 | + iotests.main(supported_fmts=['qcow2'], | ||
189 | + unsupported_imgopts=['compat']) | ||
190 | diff --git a/tests/qemu-iotests/tests/migrate-bitmaps-test b/tests/qemu-iotests/tests/migrate-bitmaps-test | ||
191 | index XXXXXXX..XXXXXXX 100755 | ||
192 | --- a/tests/qemu-iotests/tests/migrate-bitmaps-test | ||
193 | +++ b/tests/qemu-iotests/tests/migrate-bitmaps-test | ||
194 | @@ -XXX,XX +XXX,XX @@ def main() -> None: | ||
195 | |||
196 | iotests.main( | ||
197 | supported_fmts=['qcow2'], | ||
198 | - supported_protocols=['file'] | ||
199 | + supported_protocols=['file'], | ||
200 | + unsupported_imgopts=['compat'] | ||
201 | ) | ||
202 | |||
203 | |||
204 | diff --git a/tests/qemu-iotests/tests/remove-bitmap-from-backing b/tests/qemu-iotests/tests/remove-bitmap-from-backing | ||
205 | index XXXXXXX..XXXXXXX 100755 | ||
206 | --- a/tests/qemu-iotests/tests/remove-bitmap-from-backing | ||
207 | +++ b/tests/qemu-iotests/tests/remove-bitmap-from-backing | ||
208 | @@ -XXX,XX +XXX,XX @@ | ||
209 | import iotests | ||
210 | from iotests import log, qemu_img_create, qemu_img, qemu_img_pipe | ||
211 | |||
212 | -iotests.script_initialize(supported_fmts=['qcow2']) | ||
213 | +iotests.script_initialize(supported_fmts=['qcow2'], | ||
214 | + unsupported_imgopts=['compat']) | ||
215 | |||
216 | top, base = iotests.file_path('top', 'base') | ||
217 | size = '1M' | ||
218 | -- | ||
219 | 2.34.1 | ||
220 | |||
221 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | Adding support of IMGOPTS (like in bash tests) allows user to pass a | ||
4 | lot of different options. Still, some may require additional logic. | ||
5 | |||
6 | Now we want compression_type option, so add some smart logic around it: | ||
7 | ignore compression_type=zstd in IMGOPTS, if test want qcow2 in | ||
8 | compatibility mode. As well, ignore compression_type for non-qcow2 | ||
9 | formats. | ||
10 | |||
11 | Note that we may instead add support only to qemu_img_create(), but | ||
12 | that works bad: | ||
13 | |||
14 | 1. We'll have to update a lot of tests to use qemu_img_create instead | ||
15 | of qemu_img('create'). (still, we may want do it anyway, but no | ||
16 | reason to create a dependancy between task of supporting IMGOPTS and | ||
17 | updating a lot of tests) | ||
18 | |||
19 | 2. Some tests use qemu_img_pipe('create', ..) - even more work on | ||
20 | updating | ||
21 | |||
22 | 3. Even if we update all tests to go through qemu_img_create, we'll | ||
23 | need a way to avoid creating new tests using qemu_img*('create') - | ||
24 | add assertions.. That doesn't seem good. | ||
25 | |||
26 | So, let's add support of IMGOPTS to most generic | ||
27 | qemu_img_pipe_and_status(). | ||
28 | |||
29 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
30 | Reviewed-by: Hanna Reitz <hreitz@redhat.com> | ||
31 | Message-Id: <20211223160144.1097696-5-vsementsov@virtuozzo.com> | ||
32 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
33 | --- | ||
34 | tests/qemu-iotests/iotests.py | 27 ++++++++++++++++++++++++++- | ||
35 | 1 file changed, 26 insertions(+), 1 deletion(-) | ||
36 | |||
37 | diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py | ||
38 | index XXXXXXX..XXXXXXX 100644 | ||
39 | --- a/tests/qemu-iotests/iotests.py | ||
40 | +++ b/tests/qemu-iotests/iotests.py | ||
41 | @@ -XXX,XX +XXX,XX @@ | ||
42 | # along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
43 | # | ||
44 | |||
45 | +import argparse | ||
46 | import atexit | ||
47 | import bz2 | ||
48 | from collections import OrderedDict | ||
49 | @@ -XXX,XX +XXX,XX @@ def qemu_tool_pipe_and_status(tool: str, args: Sequence[str], | ||
50 | {-subp.returncode}: {cmd}\n') | ||
51 | return (output, subp.returncode) | ||
52 | |||
53 | +def qemu_img_create_prepare_args(args: List[str]) -> List[str]: | ||
54 | + if not args or args[0] != 'create': | ||
55 | + return list(args) | ||
56 | + args = args[1:] | ||
57 | + | ||
58 | + p = argparse.ArgumentParser(allow_abbrev=False) | ||
59 | + p.add_argument('-f') | ||
60 | + parsed, remaining = p.parse_known_args(args) | ||
61 | + | ||
62 | + result = ['create'] | ||
63 | + if parsed.f is not None: | ||
64 | + result += ['-f', parsed.f] | ||
65 | + | ||
66 | + # IMGOPTS most probably contain options specific for the selected format, | ||
67 | + # like extended_l2 or compression_type for qcow2. Test may want to create | ||
68 | + # additional images in other formats that doesn't support these options. | ||
69 | + # So, use IMGOPTS only for images created in imgfmt format. | ||
70 | + if parsed.f == imgfmt and 'IMGOPTS' in os.environ: | ||
71 | + result += ['-o', os.environ['IMGOPTS']] | ||
72 | + | ||
73 | + result += remaining | ||
74 | + | ||
75 | + return result | ||
76 | + | ||
77 | def qemu_img_pipe_and_status(*args: str) -> Tuple[str, int]: | ||
78 | """ | ||
79 | Run qemu-img and return both its output and its exit code | ||
80 | """ | ||
81 | - full_args = qemu_img_args + list(args) | ||
82 | + full_args = qemu_img_args + qemu_img_create_prepare_args(list(args)) | ||
83 | return qemu_tool_pipe_and_status('qemu-img', full_args) | ||
84 | |||
85 | def qemu_img(*args: str) -> int: | ||
86 | -- | ||
87 | 2.34.1 | ||
88 | |||
89 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | qemu_img_verbose() has a drawback of not going through generic | ||
4 | qemu_img_pipe_and_status(). qemu_img_verbose() is not very popular, so | ||
5 | update the only two users to qemu_img_log() and drop qemu_img_verbose() | ||
6 | at all. | ||
7 | |||
8 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
9 | Reviewed-by: Hanna Reitz <hreitz@redhat.com> | ||
10 | Message-Id: <20211223160144.1097696-6-vsementsov@virtuozzo.com> | ||
11 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
12 | --- | ||
13 | tests/qemu-iotests/044 | 5 +++-- | ||
14 | tests/qemu-iotests/044.out | 1 + | ||
15 | tests/qemu-iotests/209 | 7 ++++--- | ||
16 | tests/qemu-iotests/209.out | 2 ++ | ||
17 | tests/qemu-iotests/iotests.py | 8 -------- | ||
18 | 5 files changed, 10 insertions(+), 13 deletions(-) | ||
19 | |||
20 | diff --git a/tests/qemu-iotests/044 b/tests/qemu-iotests/044 | ||
21 | index XXXXXXX..XXXXXXX 100755 | ||
22 | --- a/tests/qemu-iotests/044 | ||
23 | +++ b/tests/qemu-iotests/044 | ||
24 | @@ -XXX,XX +XXX,XX @@ import os | ||
25 | import qcow2 | ||
26 | from qcow2 import QcowHeader | ||
27 | import iotests | ||
28 | -from iotests import qemu_img, qemu_img_verbose, qemu_io | ||
29 | +from iotests import qemu_img, qemu_img_log, qemu_io | ||
30 | import struct | ||
31 | import subprocess | ||
32 | import sys | ||
33 | @@ -XXX,XX +XXX,XX @@ class TestRefcountTableGrowth(iotests.QMPTestCase): | ||
34 | |||
35 | def test_grow_refcount_table(self): | ||
36 | qemu_io('-c', 'write 3800M 1M', test_img) | ||
37 | - qemu_img_verbose('check' , test_img) | ||
38 | + qemu_img_log('check' , test_img) | ||
39 | pass | ||
40 | |||
41 | if __name__ == '__main__': | ||
42 | + iotests.activate_logging() | ||
43 | iotests.main(supported_fmts=['qcow2'], | ||
44 | supported_protocols=['file'], | ||
45 | unsupported_imgopts=['refcount_bits']) | ||
46 | diff --git a/tests/qemu-iotests/044.out b/tests/qemu-iotests/044.out | ||
47 | index XXXXXXX..XXXXXXX 100644 | ||
48 | --- a/tests/qemu-iotests/044.out | ||
49 | +++ b/tests/qemu-iotests/044.out | ||
50 | @@ -XXX,XX +XXX,XX @@ | ||
51 | No errors were found on the image. | ||
52 | 7292415/33554432 = 21.73% allocated, 0.00% fragmented, 0.00% compressed clusters | ||
53 | Image end offset: 4296217088 | ||
54 | + | ||
55 | . | ||
56 | ---------------------------------------------------------------------- | ||
57 | Ran 1 tests | ||
58 | diff --git a/tests/qemu-iotests/209 b/tests/qemu-iotests/209 | ||
59 | index XXXXXXX..XXXXXXX 100755 | ||
60 | --- a/tests/qemu-iotests/209 | ||
61 | +++ b/tests/qemu-iotests/209 | ||
62 | @@ -XXX,XX +XXX,XX @@ | ||
63 | # | ||
64 | |||
65 | import iotests | ||
66 | -from iotests import qemu_img_create, qemu_io, qemu_img_verbose, qemu_nbd, \ | ||
67 | - file_path | ||
68 | +from iotests import qemu_img_create, qemu_io, qemu_img_log, qemu_nbd, \ | ||
69 | + file_path, log | ||
70 | |||
71 | iotests.script_initialize(supported_fmts=['qcow2']) | ||
72 | |||
73 | @@ -XXX,XX +XXX,XX @@ qemu_img_create('-f', iotests.imgfmt, disk, '1M') | ||
74 | qemu_io('-f', iotests.imgfmt, '-c', 'write 0 512K', disk) | ||
75 | |||
76 | qemu_nbd('-k', nbd_sock, '-x', 'exp', '-f', iotests.imgfmt, disk) | ||
77 | -qemu_img_verbose('map', '-f', 'raw', '--output=json', nbd_uri) | ||
78 | +qemu_img_log('map', '-f', 'raw', '--output=json', nbd_uri) | ||
79 | +log('done.') # avoid new line at the end of output file | ||
80 | diff --git a/tests/qemu-iotests/209.out b/tests/qemu-iotests/209.out | ||
81 | index XXXXXXX..XXXXXXX 100644 | ||
82 | --- a/tests/qemu-iotests/209.out | ||
83 | +++ b/tests/qemu-iotests/209.out | ||
84 | @@ -XXX,XX +XXX,XX @@ | ||
85 | [{ "start": 0, "length": 524288, "depth": 0, "present": true, "zero": false, "data": true, "offset": 0}, | ||
86 | { "start": 524288, "length": 524288, "depth": 0, "present": true, "zero": true, "data": false, "offset": 524288}] | ||
87 | + | ||
88 | +done. | ||
89 | diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py | ||
90 | index XXXXXXX..XXXXXXX 100644 | ||
91 | --- a/tests/qemu-iotests/iotests.py | ||
92 | +++ b/tests/qemu-iotests/iotests.py | ||
93 | @@ -XXX,XX +XXX,XX @@ def qemu_img_measure(*args): | ||
94 | def qemu_img_check(*args): | ||
95 | return json.loads(qemu_img_pipe("check", "--output", "json", *args)) | ||
96 | |||
97 | -def qemu_img_verbose(*args): | ||
98 | - '''Run qemu-img without suppressing its output and return the exit code''' | ||
99 | - exitcode = subprocess.call(qemu_img_args + list(args)) | ||
100 | - if exitcode < 0: | ||
101 | - sys.stderr.write('qemu-img received signal %i: %s\n' | ||
102 | - % (-exitcode, ' '.join(qemu_img_args + list(args)))) | ||
103 | - return exitcode | ||
104 | - | ||
105 | def qemu_img_pipe(*args: str) -> str: | ||
106 | '''Run qemu-img and return its output''' | ||
107 | return qemu_img_pipe_and_status(*args)[0] | ||
108 | -- | ||
109 | 2.34.1 | ||
110 | |||
111 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | Move the logic to more generic qemu_img_pipe_and_status(). Also behave | ||
4 | better when we have several -o options. And reuse argument parser of | ||
5 | course. | ||
6 | |||
7 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
8 | Reviewed-by: Hanna Reitz <hreitz@redhat.com> | ||
9 | Message-Id: <20211223160144.1097696-7-vsementsov@virtuozzo.com> | ||
10 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
11 | --- | ||
12 | tests/qemu-iotests/iotests.py | 36 +++++++++++++++++------------------ | ||
13 | 1 file changed, 17 insertions(+), 19 deletions(-) | ||
14 | |||
15 | diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py | ||
16 | index XXXXXXX..XXXXXXX 100644 | ||
17 | --- a/tests/qemu-iotests/iotests.py | ||
18 | +++ b/tests/qemu-iotests/iotests.py | ||
19 | @@ -XXX,XX +XXX,XX @@ def qemu_img_create_prepare_args(args: List[str]) -> List[str]: | ||
20 | args = args[1:] | ||
21 | |||
22 | p = argparse.ArgumentParser(allow_abbrev=False) | ||
23 | + # -o option may be specified several times | ||
24 | + p.add_argument('-o', action='append', default=[]) | ||
25 | p.add_argument('-f') | ||
26 | parsed, remaining = p.parse_known_args(args) | ||
27 | |||
28 | + opts_list = parsed.o | ||
29 | + | ||
30 | result = ['create'] | ||
31 | if parsed.f is not None: | ||
32 | result += ['-f', parsed.f] | ||
33 | @@ -XXX,XX +XXX,XX @@ def qemu_img_create_prepare_args(args: List[str]) -> List[str]: | ||
34 | # like extended_l2 or compression_type for qcow2. Test may want to create | ||
35 | # additional images in other formats that doesn't support these options. | ||
36 | # So, use IMGOPTS only for images created in imgfmt format. | ||
37 | - if parsed.f == imgfmt and 'IMGOPTS' in os.environ: | ||
38 | - result += ['-o', os.environ['IMGOPTS']] | ||
39 | + imgopts = os.environ.get('IMGOPTS') | ||
40 | + if imgopts and parsed.f == imgfmt: | ||
41 | + opts_list.insert(0, imgopts) | ||
42 | + | ||
43 | + # default luks support | ||
44 | + if parsed.f == 'luks' and \ | ||
45 | + all('key-secret' not in opts for opts in opts_list): | ||
46 | + result += ['--object', luks_default_secret_object] | ||
47 | + opts_list.append(luks_default_key_secret_opt) | ||
48 | + | ||
49 | + for opts in opts_list: | ||
50 | + result += ['-o', opts] | ||
51 | |||
52 | result += remaining | ||
53 | |||
54 | @@ -XXX,XX +XXX,XX @@ def ordered_qmp(qmsg, conv_keys=True): | ||
55 | return qmsg | ||
56 | |||
57 | def qemu_img_create(*args): | ||
58 | - args = list(args) | ||
59 | - | ||
60 | - # default luks support | ||
61 | - if '-f' in args and args[args.index('-f') + 1] == 'luks': | ||
62 | - if '-o' in args: | ||
63 | - i = args.index('-o') | ||
64 | - if 'key-secret' not in args[i + 1]: | ||
65 | - args[i + 1].append(luks_default_key_secret_opt) | ||
66 | - args.insert(i + 2, '--object') | ||
67 | - args.insert(i + 3, luks_default_secret_object) | ||
68 | - else: | ||
69 | - args = ['-o', luks_default_key_secret_opt, | ||
70 | - '--object', luks_default_secret_object] + args | ||
71 | - | ||
72 | - args.insert(0, 'create') | ||
73 | - | ||
74 | - return qemu_img(*args) | ||
75 | + return qemu_img('create', *args) | ||
76 | |||
77 | def qemu_img_measure(*args): | ||
78 | return json.loads(qemu_img_pipe("measure", "--output", "json", *args)) | ||
79 | -- | ||
80 | 2.34.1 | ||
81 | |||
82 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | The test prints qcow2 header fields which depends on chosen compression | ||
4 | type. So, let's be explicit in what compression type we want and | ||
5 | independent of IMGOPTS. Test both existing compression types. | ||
6 | |||
7 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
8 | Reviewed-by: Max Reitz <mreitz@redhat.com> | ||
9 | Message-Id: <20211223160144.1097696-8-vsementsov@virtuozzo.com> | ||
10 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
11 | --- | ||
12 | tests/qemu-iotests/303 | 25 ++++++++++++++++--------- | ||
13 | tests/qemu-iotests/303.out | 30 +++++++++++++++++++++++++++++- | ||
14 | 2 files changed, 45 insertions(+), 10 deletions(-) | ||
15 | |||
16 | diff --git a/tests/qemu-iotests/303 b/tests/qemu-iotests/303 | ||
17 | index XXXXXXX..XXXXXXX 100755 | ||
18 | --- a/tests/qemu-iotests/303 | ||
19 | +++ b/tests/qemu-iotests/303 | ||
20 | @@ -XXX,XX +XXX,XX @@ def add_bitmap(num, begin, end, disabled): | ||
21 | log('') | ||
22 | |||
23 | |||
24 | -qemu_img_create('-f', iotests.imgfmt, disk, '10M') | ||
25 | - | ||
26 | -add_bitmap(1, 0, 6, False) | ||
27 | -add_bitmap(2, 6, 8, True) | ||
28 | -dump = ['./qcow2.py', disk, 'dump-header'] | ||
29 | -subprocess.run(dump) | ||
30 | -# Dump the metadata in JSON format | ||
31 | -dump.append('-j') | ||
32 | -subprocess.run(dump) | ||
33 | +def test(compression_type: str, json_output: bool) -> None: | ||
34 | + qemu_img_create('-f', iotests.imgfmt, | ||
35 | + '-o', f'compression_type={compression_type}', | ||
36 | + disk, '10M') | ||
37 | + add_bitmap(1, 0, 6, False) | ||
38 | + add_bitmap(2, 6, 8, True) | ||
39 | + | ||
40 | + cmd = ['./qcow2.py', disk, 'dump-header'] | ||
41 | + if json_output: | ||
42 | + cmd.append('-j') | ||
43 | + | ||
44 | + subprocess.run(cmd) | ||
45 | + | ||
46 | + | ||
47 | +test('zlib', False) | ||
48 | +test('zstd', True) | ||
49 | diff --git a/tests/qemu-iotests/303.out b/tests/qemu-iotests/303.out | ||
50 | index XXXXXXX..XXXXXXX 100644 | ||
51 | --- a/tests/qemu-iotests/303.out | ||
52 | +++ b/tests/qemu-iotests/303.out | ||
53 | @@ -XXX,XX +XXX,XX @@ extra_data_size 0 | ||
54 | Bitmap table type size offset | ||
55 | 0 all-zeroes 0 0 | ||
56 | |||
57 | +Add bitmap 1 | ||
58 | +wrote 1048576/1048576 bytes at offset 0 | ||
59 | +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
60 | + | ||
61 | +wrote 1048576/1048576 bytes at offset 1048576 | ||
62 | +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
63 | + | ||
64 | +wrote 1048576/1048576 bytes at offset 2097152 | ||
65 | +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
66 | + | ||
67 | +wrote 1048576/1048576 bytes at offset 3145728 | ||
68 | +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
69 | + | ||
70 | +wrote 1048576/1048576 bytes at offset 4194304 | ||
71 | +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
72 | + | ||
73 | +wrote 1048576/1048576 bytes at offset 5242880 | ||
74 | +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
75 | + | ||
76 | + | ||
77 | +Add bitmap 2 | ||
78 | +wrote 1048576/1048576 bytes at offset 6291456 | ||
79 | +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
80 | + | ||
81 | +wrote 1048576/1048576 bytes at offset 7340032 | ||
82 | +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
83 | + | ||
84 | + | ||
85 | { | ||
86 | "magic": 1363560955, | ||
87 | "version": 3, | ||
88 | @@ -XXX,XX +XXX,XX @@ Bitmap table type size offset | ||
89 | "refcount_table_clusters": 1, | ||
90 | "nb_snapshots": 0, | ||
91 | "snapshot_offset": 0, | ||
92 | - "incompatible_features": 0, | ||
93 | + "incompatible_features": 8, | ||
94 | "compatible_features": 0, | ||
95 | "autoclear_features": 1, | ||
96 | "refcount_order": 4, | ||
97 | -- | ||
98 | 2.34.1 | ||
99 | |||
100 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | The test checks different options. It of course fails if set | ||
4 | IMGOPTS='compression_type=zstd'. So, let's be explicit in what | ||
5 | compression type we want and independent of IMGOPTS. Test both existing | ||
6 | compression types. | ||
7 | |||
8 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
9 | Reviewed-by: Hanna Reitz <hreitz@redhat.com> | ||
10 | Message-Id: <20211223160144.1097696-9-vsementsov@virtuozzo.com> | ||
11 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
12 | --- | ||
13 | tests/qemu-iotests/065 | 16 ++++++++-------- | ||
14 | 1 file changed, 8 insertions(+), 8 deletions(-) | ||
15 | |||
16 | diff --git a/tests/qemu-iotests/065 b/tests/qemu-iotests/065 | ||
17 | index XXXXXXX..XXXXXXX 100755 | ||
18 | --- a/tests/qemu-iotests/065 | ||
19 | +++ b/tests/qemu-iotests/065 | ||
20 | @@ -XXX,XX +XXX,XX @@ class TestQMP(TestImageInfoSpecific): | ||
21 | |||
22 | class TestQCow2(TestQemuImgInfo): | ||
23 | '''Testing a qcow2 version 2 image''' | ||
24 | - img_options = 'compat=0.10' | ||
25 | + img_options = 'compat=0.10,compression_type=zlib' | ||
26 | json_compare = { 'compat': '0.10', 'refcount-bits': 16, | ||
27 | 'compression-type': 'zlib' } | ||
28 | human_compare = [ 'compat: 0.10', 'compression type: zlib', | ||
29 | @@ -XXX,XX +XXX,XX @@ class TestQCow2(TestQemuImgInfo): | ||
30 | |||
31 | class TestQCow3NotLazy(TestQemuImgInfo): | ||
32 | '''Testing a qcow2 version 3 image with lazy refcounts disabled''' | ||
33 | - img_options = 'compat=1.1,lazy_refcounts=off' | ||
34 | + img_options = 'compat=1.1,lazy_refcounts=off,compression_type=zstd' | ||
35 | json_compare = { 'compat': '1.1', 'lazy-refcounts': False, | ||
36 | 'refcount-bits': 16, 'corrupt': False, | ||
37 | - 'compression-type': 'zlib', 'extended-l2': False } | ||
38 | - human_compare = [ 'compat: 1.1', 'compression type: zlib', | ||
39 | + 'compression-type': 'zstd', 'extended-l2': False } | ||
40 | + human_compare = [ 'compat: 1.1', 'compression type: zstd', | ||
41 | 'lazy refcounts: false', 'refcount bits: 16', | ||
42 | 'corrupt: false', 'extended l2: false' ] | ||
43 | |||
44 | class TestQCow3Lazy(TestQemuImgInfo): | ||
45 | '''Testing a qcow2 version 3 image with lazy refcounts enabled''' | ||
46 | - img_options = 'compat=1.1,lazy_refcounts=on' | ||
47 | + img_options = 'compat=1.1,lazy_refcounts=on,compression_type=zlib' | ||
48 | json_compare = { 'compat': '1.1', 'lazy-refcounts': True, | ||
49 | 'refcount-bits': 16, 'corrupt': False, | ||
50 | 'compression-type': 'zlib', 'extended-l2': False } | ||
51 | @@ -XXX,XX +XXX,XX @@ class TestQCow3Lazy(TestQemuImgInfo): | ||
52 | class TestQCow3NotLazyQMP(TestQMP): | ||
53 | '''Testing a qcow2 version 3 image with lazy refcounts disabled, opening | ||
54 | with lazy refcounts enabled''' | ||
55 | - img_options = 'compat=1.1,lazy_refcounts=off' | ||
56 | + img_options = 'compat=1.1,lazy_refcounts=off,compression_type=zlib' | ||
57 | qemu_options = 'lazy-refcounts=on' | ||
58 | compare = { 'compat': '1.1', 'lazy-refcounts': False, | ||
59 | 'refcount-bits': 16, 'corrupt': False, | ||
60 | @@ -XXX,XX +XXX,XX @@ class TestQCow3NotLazyQMP(TestQMP): | ||
61 | class TestQCow3LazyQMP(TestQMP): | ||
62 | '''Testing a qcow2 version 3 image with lazy refcounts enabled, opening | ||
63 | with lazy refcounts disabled''' | ||
64 | - img_options = 'compat=1.1,lazy_refcounts=on' | ||
65 | + img_options = 'compat=1.1,lazy_refcounts=on,compression_type=zstd' | ||
66 | qemu_options = 'lazy-refcounts=off' | ||
67 | compare = { 'compat': '1.1', 'lazy-refcounts': True, | ||
68 | 'refcount-bits': 16, 'corrupt': False, | ||
69 | - 'compression-type': 'zlib', 'extended-l2': False } | ||
70 | + 'compression-type': 'zstd', 'extended-l2': False } | ||
71 | |||
72 | TestImageInfoSpecific = None | ||
73 | TestQemuImgInfo = None | ||
74 | -- | ||
75 | 2.34.1 | ||
76 | |||
77 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | The only "feature" of this "Formatting ..." line is that we have to | ||
4 | update it every time we add new option. Let's drop it. | ||
5 | |||
6 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
7 | Reviewed-by: Hanna Reitz <hreitz@redhat.com> | ||
8 | Message-Id: <20211223160144.1097696-10-vsementsov@virtuozzo.com> | ||
9 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
10 | --- | ||
11 | tests/qemu-iotests/149.out | 21 --------------------- | ||
12 | tests/qemu-iotests/237.out | 3 --- | ||
13 | tests/qemu-iotests/255.out | 4 ---- | ||
14 | tests/qemu-iotests/274.out | 29 ----------------------------- | ||
15 | tests/qemu-iotests/280.out | 1 - | ||
16 | tests/qemu-iotests/296.out | 10 +++------- | ||
17 | tests/qemu-iotests/iotests.py | 10 ++++++++-- | ||
18 | 7 files changed, 11 insertions(+), 67 deletions(-) | ||
19 | |||
20 | diff --git a/tests/qemu-iotests/149.out b/tests/qemu-iotests/149.out | ||
21 | index XXXXXXX..XXXXXXX 100644 | ||
22 | --- a/tests/qemu-iotests/149.out | ||
23 | +++ b/tests/qemu-iotests/149.out | ||
24 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-xts-plain64-sha1.img | ||
25 | # ================= qemu-img aes-256-xts-plain64-sha1 ================= | ||
26 | # Create image | ||
27 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-aes-256-xts-plain64-sha1.img 4194304M | ||
28 | -Formatting 'TEST_DIR/luks-aes-256-xts-plain64-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
29 | |||
30 | # Open dev | ||
31 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-xts-plain64-sha1.img qiotest-145-aes-256-xts-plain64-sha1 | ||
32 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-twofish-256-xts-plain64-sha1.img | ||
33 | # ================= qemu-img twofish-256-xts-plain64-sha1 ================= | ||
34 | # Create image | ||
35 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=twofish-256,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-twofish-256-xts-plain64-sha1.img 4194304M | ||
36 | -Formatting 'TEST_DIR/luks-twofish-256-xts-plain64-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=twofish-256 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
37 | |||
38 | # Open dev | ||
39 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-twofish-256-xts-plain64-sha1.img qiotest-145-twofish-256-xts-plain64-sha1 | ||
40 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-serpent-256-xts-plain64-sha1.img | ||
41 | # ================= qemu-img serpent-256-xts-plain64-sha1 ================= | ||
42 | # Create image | ||
43 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=serpent-256,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-serpent-256-xts-plain64-sha1.img 4194304M | ||
44 | -Formatting 'TEST_DIR/luks-serpent-256-xts-plain64-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=serpent-256 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
45 | |||
46 | # Open dev | ||
47 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-serpent-256-xts-plain64-sha1.img qiotest-145-serpent-256-xts-plain64-sha1 | ||
48 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-cast5-128-cbc-plain64-sha1.img | ||
49 | # ================= qemu-img cast5-128-cbc-plain64-sha1 ================= | ||
50 | # Create image | ||
51 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=cast5-128,cipher-mode=cbc,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-cast5-128-cbc-plain64-sha1.img 4194304M | ||
52 | -Formatting 'TEST_DIR/luks-cast5-128-cbc-plain64-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=cast5-128 cipher-mode=cbc ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
53 | |||
54 | # Open dev | ||
55 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-cast5-128-cbc-plain64-sha1.img qiotest-145-cast5-128-cbc-plain64-sha1 | ||
56 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-cbc-plain-sha1.img | ||
57 | # ================= qemu-img aes-256-cbc-plain-sha1 ================= | ||
58 | # Create image | ||
59 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=cbc,ivgen-alg=plain,hash-alg=sha1 TEST_DIR/luks-aes-256-cbc-plain-sha1.img 4194304M | ||
60 | -Formatting 'TEST_DIR/luks-aes-256-cbc-plain-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=cbc ivgen-alg=plain hash-alg=sha1 iter-time=10 | ||
61 | |||
62 | # Open dev | ||
63 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-cbc-plain-sha1.img qiotest-145-aes-256-cbc-plain-sha1 | ||
64 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-cbc-plain64-sha1.img | ||
65 | # ================= qemu-img aes-256-cbc-plain64-sha1 ================= | ||
66 | # Create image | ||
67 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=cbc,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-aes-256-cbc-plain64-sha1.img 4194304M | ||
68 | -Formatting 'TEST_DIR/luks-aes-256-cbc-plain64-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=cbc ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
69 | |||
70 | # Open dev | ||
71 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-cbc-plain64-sha1.img qiotest-145-aes-256-cbc-plain64-sha1 | ||
72 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-cbc-essiv-sha256-sha1.img | ||
73 | # ================= qemu-img aes-256-cbc-essiv-sha256-sha1 ================= | ||
74 | # Create image | ||
75 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=cbc,ivgen-alg=essiv,hash-alg=sha1,ivgen-hash-alg=sha256 TEST_DIR/luks-aes-256-cbc-essiv-sha256-sha1.img 4194304M | ||
76 | -Formatting 'TEST_DIR/luks-aes-256-cbc-essiv-sha256-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=cbc ivgen-alg=essiv ivgen-hash-alg=sha256 hash-alg=sha1 iter-time=10 | ||
77 | |||
78 | # Open dev | ||
79 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-cbc-essiv-sha256-sha1.img qiotest-145-aes-256-cbc-essiv-sha256-sha1 | ||
80 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-xts-essiv-sha256-sha1.img | ||
81 | # ================= qemu-img aes-256-xts-essiv-sha256-sha1 ================= | ||
82 | # Create image | ||
83 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=xts,ivgen-alg=essiv,hash-alg=sha1,ivgen-hash-alg=sha256 TEST_DIR/luks-aes-256-xts-essiv-sha256-sha1.img 4194304M | ||
84 | -Formatting 'TEST_DIR/luks-aes-256-xts-essiv-sha256-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=xts ivgen-alg=essiv ivgen-hash-alg=sha256 hash-alg=sha1 iter-time=10 | ||
85 | |||
86 | # Open dev | ||
87 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-xts-essiv-sha256-sha1.img qiotest-145-aes-256-xts-essiv-sha256-sha1 | ||
88 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-128-xts-plain64-sha256-sha1.img | ||
89 | # ================= qemu-img aes-128-xts-plain64-sha256-sha1 ================= | ||
90 | # Create image | ||
91 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-128,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-aes-128-xts-plain64-sha256-sha1.img 4194304M | ||
92 | -Formatting 'TEST_DIR/luks-aes-128-xts-plain64-sha256-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-128 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
93 | |||
94 | # Open dev | ||
95 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-128-xts-plain64-sha256-sha1.img qiotest-145-aes-128-xts-plain64-sha256-sha1 | ||
96 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-192-xts-plain64-sha256-sha1.img | ||
97 | # ================= qemu-img aes-192-xts-plain64-sha256-sha1 ================= | ||
98 | # Create image | ||
99 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-192,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-aes-192-xts-plain64-sha256-sha1.img 4194304M | ||
100 | -Formatting 'TEST_DIR/luks-aes-192-xts-plain64-sha256-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-192 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
101 | |||
102 | # Open dev | ||
103 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-192-xts-plain64-sha256-sha1.img qiotest-145-aes-192-xts-plain64-sha256-sha1 | ||
104 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-twofish-128-xts-plain64-sha1.img | ||
105 | # ================= qemu-img twofish-128-xts-plain64-sha1 ================= | ||
106 | # Create image | ||
107 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=twofish-128,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-twofish-128-xts-plain64-sha1.img 4194304M | ||
108 | -Formatting 'TEST_DIR/luks-twofish-128-xts-plain64-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=twofish-128 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
109 | |||
110 | # Open dev | ||
111 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-twofish-128-xts-plain64-sha1.img qiotest-145-twofish-128-xts-plain64-sha1 | ||
112 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-serpent-128-xts-plain64-sha1.img | ||
113 | # ================= qemu-img serpent-128-xts-plain64-sha1 ================= | ||
114 | # Create image | ||
115 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=serpent-128,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-serpent-128-xts-plain64-sha1.img 4194304M | ||
116 | -Formatting 'TEST_DIR/luks-serpent-128-xts-plain64-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=serpent-128 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
117 | |||
118 | # Open dev | ||
119 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-serpent-128-xts-plain64-sha1.img qiotest-145-serpent-128-xts-plain64-sha1 | ||
120 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-serpent-192-xts-plain64-sha1.img | ||
121 | # ================= qemu-img serpent-192-xts-plain64-sha1 ================= | ||
122 | # Create image | ||
123 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=serpent-192,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha1 TEST_DIR/luks-serpent-192-xts-plain64-sha1.img 4194304M | ||
124 | -Formatting 'TEST_DIR/luks-serpent-192-xts-plain64-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=serpent-192 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha1 iter-time=10 | ||
125 | |||
126 | # Open dev | ||
127 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-serpent-192-xts-plain64-sha1.img qiotest-145-serpent-192-xts-plain64-sha1 | ||
128 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-xts-plain64-sha224.img | ||
129 | # ================= qemu-img aes-256-xts-plain64-sha224 ================= | ||
130 | # Create image | ||
131 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha224 TEST_DIR/luks-aes-256-xts-plain64-sha224.img 4194304M | ||
132 | -Formatting 'TEST_DIR/luks-aes-256-xts-plain64-sha224.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha224 iter-time=10 | ||
133 | |||
134 | # Open dev | ||
135 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-xts-plain64-sha224.img qiotest-145-aes-256-xts-plain64-sha224 | ||
136 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-xts-plain64-sha256.img | ||
137 | # ================= qemu-img aes-256-xts-plain64-sha256 ================= | ||
138 | # Create image | ||
139 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha256 TEST_DIR/luks-aes-256-xts-plain64-sha256.img 4194304M | ||
140 | -Formatting 'TEST_DIR/luks-aes-256-xts-plain64-sha256.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha256 iter-time=10 | ||
141 | |||
142 | # Open dev | ||
143 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-xts-plain64-sha256.img qiotest-145-aes-256-xts-plain64-sha256 | ||
144 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-xts-plain64-sha384.img | ||
145 | # ================= qemu-img aes-256-xts-plain64-sha384 ================= | ||
146 | # Create image | ||
147 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha384 TEST_DIR/luks-aes-256-xts-plain64-sha384.img 4194304M | ||
148 | -Formatting 'TEST_DIR/luks-aes-256-xts-plain64-sha384.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha384 iter-time=10 | ||
149 | |||
150 | # Open dev | ||
151 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-xts-plain64-sha384.img qiotest-145-aes-256-xts-plain64-sha384 | ||
152 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-xts-plain64-sha512.img | ||
153 | # ================= qemu-img aes-256-xts-plain64-sha512 ================= | ||
154 | # Create image | ||
155 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=xts,ivgen-alg=plain64,hash-alg=sha512 TEST_DIR/luks-aes-256-xts-plain64-sha512.img 4194304M | ||
156 | -Formatting 'TEST_DIR/luks-aes-256-xts-plain64-sha512.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=xts ivgen-alg=plain64 hash-alg=sha512 iter-time=10 | ||
157 | |||
158 | # Open dev | ||
159 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-xts-plain64-sha512.img qiotest-145-aes-256-xts-plain64-sha512 | ||
160 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-xts-plain64-ripemd160.img | ||
161 | # ================= qemu-img aes-256-xts-plain64-ripemd160 ================= | ||
162 | # Create image | ||
163 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=xts,ivgen-alg=plain64,hash-alg=ripemd160 TEST_DIR/luks-aes-256-xts-plain64-ripemd160.img 4194304M | ||
164 | -Formatting 'TEST_DIR/luks-aes-256-xts-plain64-ripemd160.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=xts ivgen-alg=plain64 hash-alg=ripemd160 iter-time=10 | ||
165 | |||
166 | # Open dev | ||
167 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-xts-plain64-ripemd160.img qiotest-145-aes-256-xts-plain64-ripemd160 | ||
168 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-xts-plain-sha1-pwallslots.img | ||
169 | # ================= qemu-img aes-256-xts-plain-sha1-pwallslots ================= | ||
170 | # Create image | ||
171 | qemu-img create -f luks --object secret,id=sec0,data=c2xvdDE=,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=xts,ivgen-alg=plain,hash-alg=sha1 TEST_DIR/luks-aes-256-xts-plain-sha1-pwallslots.img 4194304M | ||
172 | -Formatting 'TEST_DIR/luks-aes-256-xts-plain-sha1-pwallslots.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=xts ivgen-alg=plain hash-alg=sha1 iter-time=10 | ||
173 | |||
174 | # Open dev | ||
175 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-xts-plain-sha1-pwallslots.img qiotest-145-aes-256-xts-plain-sha1-pwallslots | ||
176 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-cbc-essiv-auto-sha1.img | ||
177 | # ================= qemu-img aes-256-cbc-essiv-auto-sha1 ================= | ||
178 | # Create image | ||
179 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=cbc,ivgen-alg=essiv,hash-alg=sha1 TEST_DIR/luks-aes-256-cbc-essiv-auto-sha1.img 4194304M | ||
180 | -Formatting 'TEST_DIR/luks-aes-256-cbc-essiv-auto-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=cbc ivgen-alg=essiv hash-alg=sha1 iter-time=10 | ||
181 | |||
182 | # Open dev | ||
183 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-cbc-essiv-auto-sha1.img qiotest-145-aes-256-cbc-essiv-auto-sha1 | ||
184 | @@ -XXX,XX +XXX,XX @@ unlink TEST_DIR/luks-aes-256-cbc-plain64-sha256-sha1.img | ||
185 | # ================= qemu-img aes-256-cbc-plain64-sha256-sha1 ================= | ||
186 | # Create image | ||
187 | qemu-img create -f luks --object secret,id=sec0,data=MTIzNDU2,format=base64 -o key-secret=sec0,iter-time=10,cipher-alg=aes-256,cipher-mode=cbc,ivgen-alg=plain64,hash-alg=sha1,ivgen-hash-alg=sha256 TEST_DIR/luks-aes-256-cbc-plain64-sha256-sha1.img 4194304M | ||
188 | -Formatting 'TEST_DIR/luks-aes-256-cbc-plain64-sha256-sha1.img', fmt=luks size=4398046511104 key-secret=sec0 cipher-alg=aes-256 cipher-mode=cbc ivgen-alg=plain64 ivgen-hash-alg=sha256 hash-alg=sha1 iter-time=10 | ||
189 | |||
190 | # Open dev | ||
191 | sudo cryptsetup -q -v luksOpen TEST_DIR/luks-aes-256-cbc-plain64-sha256-sha1.img qiotest-145-aes-256-cbc-plain64-sha256-sha1 | ||
192 | diff --git a/tests/qemu-iotests/237.out b/tests/qemu-iotests/237.out | ||
193 | index XXXXXXX..XXXXXXX 100644 | ||
194 | --- a/tests/qemu-iotests/237.out | ||
195 | +++ b/tests/qemu-iotests/237.out | ||
196 | @@ -XXX,XX +XXX,XX @@ Job failed: Cannot find device='this doesn't exist' nor node-name='this doesn't | ||
197 | |||
198 | === Other subformats === | ||
199 | |||
200 | -Formatting 'TEST_DIR/PID-t.vmdk.1', fmt=vmdk size=0 compat6=off hwversion=undefined | ||
201 | |||
202 | -Formatting 'TEST_DIR/PID-t.vmdk.2', fmt=vmdk size=0 compat6=off hwversion=undefined | ||
203 | |||
204 | -Formatting 'TEST_DIR/PID-t.vmdk.3', fmt=vmdk size=0 compat6=off hwversion=undefined | ||
205 | |||
206 | == Missing extent == | ||
207 | |||
208 | diff --git a/tests/qemu-iotests/255.out b/tests/qemu-iotests/255.out | ||
209 | index XXXXXXX..XXXXXXX 100644 | ||
210 | --- a/tests/qemu-iotests/255.out | ||
211 | +++ b/tests/qemu-iotests/255.out | ||
212 | @@ -XXX,XX +XXX,XX @@ Finishing a commit job with background reads | ||
213 | |||
214 | === Create backing chain and start VM === | ||
215 | |||
216 | -Formatting 'TEST_DIR/PID-t.qcow2.mid', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=134217728 lazy_refcounts=off refcount_bits=16 | ||
217 | |||
218 | -Formatting 'TEST_DIR/PID-t.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=134217728 lazy_refcounts=off refcount_bits=16 | ||
219 | |||
220 | === Start background read requests === | ||
221 | |||
222 | @@ -XXX,XX +XXX,XX @@ Closing the VM while a job is being cancelled | ||
223 | |||
224 | === Create images and start VM === | ||
225 | |||
226 | -Formatting 'TEST_DIR/PID-src.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=134217728 lazy_refcounts=off refcount_bits=16 | ||
227 | |||
228 | -Formatting 'TEST_DIR/PID-dst.qcow2', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=134217728 lazy_refcounts=off refcount_bits=16 | ||
229 | |||
230 | wrote 1048576/1048576 bytes at offset 0 | ||
231 | 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
232 | diff --git a/tests/qemu-iotests/274.out b/tests/qemu-iotests/274.out | ||
233 | index XXXXXXX..XXXXXXX 100644 | ||
234 | --- a/tests/qemu-iotests/274.out | ||
235 | +++ b/tests/qemu-iotests/274.out | ||
236 | @@ -XXX,XX +XXX,XX @@ | ||
237 | == Commit tests == | ||
238 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 lazy_refcounts=off refcount_bits=16 | ||
239 | |||
240 | -Formatting 'TEST_DIR/PID-mid', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=1048576 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
241 | |||
242 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 backing_file=TEST_DIR/PID-mid backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
243 | |||
244 | wrote 2097152/2097152 bytes at offset 0 | ||
245 | 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
246 | @@ -XXX,XX +XXX,XX @@ read 1048576/1048576 bytes at offset 1048576 | ||
247 | 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
248 | |||
249 | === Testing HMP commit (top -> mid) === | ||
250 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 lazy_refcounts=off refcount_bits=16 | ||
251 | |||
252 | -Formatting 'TEST_DIR/PID-mid', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=1048576 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
253 | |||
254 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 backing_file=TEST_DIR/PID-mid backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
255 | |||
256 | wrote 2097152/2097152 bytes at offset 0 | ||
257 | 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
258 | @@ -XXX,XX +XXX,XX @@ read 1048576/1048576 bytes at offset 1048576 | ||
259 | 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
260 | |||
261 | === Testing QMP active commit (top -> mid) === | ||
262 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 lazy_refcounts=off refcount_bits=16 | ||
263 | |||
264 | -Formatting 'TEST_DIR/PID-mid', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=1048576 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
265 | |||
266 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 backing_file=TEST_DIR/PID-mid backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
267 | |||
268 | wrote 2097152/2097152 bytes at offset 0 | ||
269 | 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
270 | @@ -XXX,XX +XXX,XX @@ read 1048576/1048576 bytes at offset 1048576 | ||
271 | 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
272 | |||
273 | === Testing qemu-img commit (top -> base) === | ||
274 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 lazy_refcounts=off refcount_bits=16 | ||
275 | |||
276 | -Formatting 'TEST_DIR/PID-mid', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=1048576 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
277 | |||
278 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 backing_file=TEST_DIR/PID-mid backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
279 | |||
280 | wrote 2097152/2097152 bytes at offset 0 | ||
281 | 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
282 | @@ -XXX,XX +XXX,XX @@ read 1048576/1048576 bytes at offset 1048576 | ||
283 | 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
284 | |||
285 | === Testing QMP active commit (top -> base) === | ||
286 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 lazy_refcounts=off refcount_bits=16 | ||
287 | |||
288 | -Formatting 'TEST_DIR/PID-mid', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=1048576 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
289 | |||
290 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=2097152 backing_file=TEST_DIR/PID-mid backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
291 | |||
292 | wrote 2097152/2097152 bytes at offset 0 | ||
293 | 2 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
294 | @@ -XXX,XX +XXX,XX @@ read 1048576/1048576 bytes at offset 1048576 | ||
295 | |||
296 | == Resize tests == | ||
297 | === preallocation=off === | ||
298 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=6442450944 lazy_refcounts=off refcount_bits=16 | ||
299 | |||
300 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=1073741824 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
301 | |||
302 | wrote 65536/65536 bytes at offset 5368709120 | ||
303 | 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
304 | @@ -XXX,XX +XXX,XX @@ read 65536/65536 bytes at offset 5368709120 | ||
305 | { "start": 1073741824, "length": 7516192768, "depth": 0, "present": true, "zero": true, "data": false}] | ||
306 | |||
307 | === preallocation=metadata === | ||
308 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=34359738368 lazy_refcounts=off refcount_bits=16 | ||
309 | |||
310 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=32212254720 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
311 | |||
312 | wrote 65536/65536 bytes at offset 33285996544 | ||
313 | 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
314 | @@ -XXX,XX +XXX,XX @@ read 65536/65536 bytes at offset 33285996544 | ||
315 | { "start": 34896609280, "length": 536870912, "depth": 0, "present": true, "zero": true, "data": false, "offset": 2685075456}] | ||
316 | |||
317 | === preallocation=falloc === | ||
318 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=10485760 lazy_refcounts=off refcount_bits=16 | ||
319 | |||
320 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=5242880 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
321 | |||
322 | wrote 65536/65536 bytes at offset 9437184 | ||
323 | 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
324 | @@ -XXX,XX +XXX,XX @@ read 65536/65536 bytes at offset 9437184 | ||
325 | { "start": 5242880, "length": 10485760, "depth": 0, "present": true, "zero": false, "data": true, "offset": 327680}] | ||
326 | |||
327 | === preallocation=full === | ||
328 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=16777216 lazy_refcounts=off refcount_bits=16 | ||
329 | |||
330 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=8388608 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
331 | |||
332 | wrote 65536/65536 bytes at offset 11534336 | ||
333 | 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
334 | @@ -XXX,XX +XXX,XX @@ read 65536/65536 bytes at offset 11534336 | ||
335 | { "start": 8388608, "length": 4194304, "depth": 0, "present": true, "zero": false, "data": true, "offset": 327680}] | ||
336 | |||
337 | === preallocation=off === | ||
338 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=393216 lazy_refcounts=off refcount_bits=16 | ||
339 | |||
340 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=259072 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
341 | |||
342 | wrote 65536/65536 bytes at offset 259072 | ||
343 | 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
344 | @@ -XXX,XX +XXX,XX @@ read 65536/65536 bytes at offset 259072 | ||
345 | { "start": 262144, "length": 262144, "depth": 0, "present": true, "zero": true, "data": false}] | ||
346 | |||
347 | === preallocation=off === | ||
348 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=409600 lazy_refcounts=off refcount_bits=16 | ||
349 | |||
350 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=262144 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
351 | |||
352 | wrote 65536/65536 bytes at offset 344064 | ||
353 | 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
354 | @@ -XXX,XX +XXX,XX @@ read 65536/65536 bytes at offset 344064 | ||
355 | { "start": 262144, "length": 262144, "depth": 0, "present": true, "zero": true, "data": false}] | ||
356 | |||
357 | === preallocation=off === | ||
358 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=524288 lazy_refcounts=off refcount_bits=16 | ||
359 | |||
360 | -Formatting 'TEST_DIR/PID-top', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=262144 backing_file=TEST_DIR/PID-base backing_fmt=qcow2 lazy_refcounts=off refcount_bits=16 | ||
361 | |||
362 | wrote 65536/65536 bytes at offset 446464 | ||
363 | 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) | ||
364 | diff --git a/tests/qemu-iotests/280.out b/tests/qemu-iotests/280.out | ||
365 | index XXXXXXX..XXXXXXX 100644 | ||
366 | --- a/tests/qemu-iotests/280.out | ||
367 | +++ b/tests/qemu-iotests/280.out | ||
368 | @@ -XXX,XX +XXX,XX @@ | ||
369 | -Formatting 'TEST_DIR/PID-base', fmt=qcow2 cluster_size=65536 extended_l2=off compression_type=zlib size=67108864 lazy_refcounts=off refcount_bits=16 | ||
370 | |||
371 | === Launch VM === | ||
372 | Enabling migration QMP events on VM... | ||
373 | diff --git a/tests/qemu-iotests/296.out b/tests/qemu-iotests/296.out | ||
374 | index XXXXXXX..XXXXXXX 100644 | ||
375 | --- a/tests/qemu-iotests/296.out | ||
376 | +++ b/tests/qemu-iotests/296.out | ||
377 | @@ -XXX,XX +XXX,XX @@ | ||
378 | -Formatting 'TEST_DIR/test.img', fmt=luks size=1048576 key-secret=keysec0 iter-time=10 | ||
379 | |||
380 | {"execute": "job-dismiss", "arguments": {"id": "job0"}} | ||
381 | {"return": {}} | ||
382 | @@ -XXX,XX +XXX,XX @@ Job failed: Failed to get shared "consistent read" lock | ||
383 | qemu-img: Failed to get shared "consistent read" lock | ||
384 | Is another process using the image [TEST_DIR/test.img]? | ||
385 | |||
386 | -.Formatting 'TEST_DIR/test.img', fmt=luks size=1048576 key-secret=keysec0 iter-time=10 | ||
387 | - | ||
388 | +. | ||
389 | Job failed: Block node is read-only | ||
390 | {"execute": "job-dismiss", "arguments": {"id": "job0"}} | ||
391 | {"return": {}} | ||
392 | @@ -XXX,XX +XXX,XX @@ Job failed: Failed to get shared "consistent read" lock | ||
393 | {"return": {}} | ||
394 | {"execute": "job-dismiss", "arguments": {"id": "job0"}} | ||
395 | {"return": {}} | ||
396 | -.Formatting 'TEST_DIR/test.img', fmt=luks size=1048576 key-secret=keysec0 iter-time=10 | ||
397 | - | ||
398 | +. | ||
399 | {"return": {}} | ||
400 | {"error": {"class": "GenericError", "desc": "Failed to get \"write\" lock"}} | ||
401 | -.Formatting 'TEST_DIR/test.img', fmt=luks size=1048576 key-secret=keysec0 iter-time=10 | ||
402 | - | ||
403 | +. | ||
404 | {"return": {}} | ||
405 | {"return": {}} | ||
406 | . | ||
407 | diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py | ||
408 | index XXXXXXX..XXXXXXX 100644 | ||
409 | --- a/tests/qemu-iotests/iotests.py | ||
410 | +++ b/tests/qemu-iotests/iotests.py | ||
411 | @@ -XXX,XX +XXX,XX @@ def qemu_tool_popen(args: Sequence[str], | ||
412 | |||
413 | |||
414 | def qemu_tool_pipe_and_status(tool: str, args: Sequence[str], | ||
415 | - connect_stderr: bool = True) -> Tuple[str, int]: | ||
416 | + connect_stderr: bool = True, | ||
417 | + drop_successful_output: bool = False) \ | ||
418 | + -> Tuple[str, int]: | ||
419 | """ | ||
420 | Run a tool and return both its output and its exit code | ||
421 | """ | ||
422 | @@ -XXX,XX +XXX,XX @@ def qemu_tool_pipe_and_status(tool: str, args: Sequence[str], | ||
423 | cmd = ' '.join(args) | ||
424 | sys.stderr.write(f'{tool} received signal \ | ||
425 | {-subp.returncode}: {cmd}\n') | ||
426 | + if drop_successful_output and subp.returncode == 0: | ||
427 | + output = '' | ||
428 | return (output, subp.returncode) | ||
429 | |||
430 | def qemu_img_create_prepare_args(args: List[str]) -> List[str]: | ||
431 | @@ -XXX,XX +XXX,XX @@ def qemu_img_pipe_and_status(*args: str) -> Tuple[str, int]: | ||
432 | """ | ||
433 | Run qemu-img and return both its output and its exit code | ||
434 | """ | ||
435 | + is_create = bool(args and args[0] == 'create') | ||
436 | full_args = qemu_img_args + qemu_img_create_prepare_args(list(args)) | ||
437 | - return qemu_tool_pipe_and_status('qemu-img', full_args) | ||
438 | + return qemu_tool_pipe_and_status('qemu-img', full_args, | ||
439 | + drop_successful_output=is_create) | ||
440 | |||
441 | def qemu_img(*args: str) -> int: | ||
442 | '''Run qemu-img and return the exit code''' | ||
443 | -- | ||
444 | 2.34.1 | ||
445 | |||
446 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | We want iotests pass with both the default zlib compression and with | ||
4 | IMGOPTS='compression_type=zstd'. | ||
5 | |||
6 | Actually the only test that is interested in real compression type in | ||
7 | test output is 287 (test for qcow2 compression type) and it's in bash. | ||
8 | So for now we can safely filter out compression type in all qcow2 | ||
9 | tests. | ||
10 | |||
11 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
12 | Reviewed-by: Hanna Reitz <hreitz@redhat.com> | ||
13 | Message-Id: <20211223160144.1097696-11-vsementsov@virtuozzo.com> | ||
14 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
15 | --- | ||
16 | tests/qemu-iotests/206.out | 10 +++++----- | ||
17 | tests/qemu-iotests/242.out | 10 +++++----- | ||
18 | tests/qemu-iotests/274.out | 10 +++++----- | ||
19 | tests/qemu-iotests/iotests.py | 2 ++ | ||
20 | 4 files changed, 17 insertions(+), 15 deletions(-) | ||
21 | |||
22 | diff --git a/tests/qemu-iotests/206.out b/tests/qemu-iotests/206.out | ||
23 | index XXXXXXX..XXXXXXX 100644 | ||
24 | --- a/tests/qemu-iotests/206.out | ||
25 | +++ b/tests/qemu-iotests/206.out | ||
26 | @@ -XXX,XX +XXX,XX @@ virtual size: 128 MiB (134217728 bytes) | ||
27 | cluster_size: 65536 | ||
28 | Format specific information: | ||
29 | compat: 1.1 | ||
30 | - compression type: zlib | ||
31 | + compression type: COMPRESSION_TYPE | ||
32 | lazy refcounts: false | ||
33 | refcount bits: 16 | ||
34 | corrupt: false | ||
35 | @@ -XXX,XX +XXX,XX @@ virtual size: 64 MiB (67108864 bytes) | ||
36 | cluster_size: 65536 | ||
37 | Format specific information: | ||
38 | compat: 1.1 | ||
39 | - compression type: zlib | ||
40 | + compression type: COMPRESSION_TYPE | ||
41 | lazy refcounts: false | ||
42 | refcount bits: 16 | ||
43 | corrupt: false | ||
44 | @@ -XXX,XX +XXX,XX @@ virtual size: 32 MiB (33554432 bytes) | ||
45 | cluster_size: 2097152 | ||
46 | Format specific information: | ||
47 | compat: 1.1 | ||
48 | - compression type: zlib | ||
49 | + compression type: COMPRESSION_TYPE | ||
50 | lazy refcounts: true | ||
51 | refcount bits: 1 | ||
52 | corrupt: false | ||
53 | @@ -XXX,XX +XXX,XX @@ backing file: TEST_IMG.base | ||
54 | backing file format: IMGFMT | ||
55 | Format specific information: | ||
56 | compat: 0.10 | ||
57 | - compression type: zlib | ||
58 | + compression type: COMPRESSION_TYPE | ||
59 | refcount bits: 16 | ||
60 | |||
61 | === Successful image creation (encrypted) === | ||
62 | @@ -XXX,XX +XXX,XX @@ encrypted: yes | ||
63 | cluster_size: 65536 | ||
64 | Format specific information: | ||
65 | compat: 1.1 | ||
66 | - compression type: zlib | ||
67 | + compression type: COMPRESSION_TYPE | ||
68 | lazy refcounts: false | ||
69 | refcount bits: 16 | ||
70 | encrypt: | ||
71 | diff --git a/tests/qemu-iotests/242.out b/tests/qemu-iotests/242.out | ||
72 | index XXXXXXX..XXXXXXX 100644 | ||
73 | --- a/tests/qemu-iotests/242.out | ||
74 | +++ b/tests/qemu-iotests/242.out | ||
75 | @@ -XXX,XX +XXX,XX @@ virtual size: 1 MiB (1048576 bytes) | ||
76 | cluster_size: 65536 | ||
77 | Format specific information: | ||
78 | compat: 1.1 | ||
79 | - compression type: zlib | ||
80 | + compression type: COMPRESSION_TYPE | ||
81 | lazy refcounts: false | ||
82 | refcount bits: 16 | ||
83 | corrupt: false | ||
84 | @@ -XXX,XX +XXX,XX @@ virtual size: 1 MiB (1048576 bytes) | ||
85 | cluster_size: 65536 | ||
86 | Format specific information: | ||
87 | compat: 1.1 | ||
88 | - compression type: zlib | ||
89 | + compression type: COMPRESSION_TYPE | ||
90 | lazy refcounts: false | ||
91 | bitmaps: | ||
92 | [0]: | ||
93 | @@ -XXX,XX +XXX,XX @@ virtual size: 1 MiB (1048576 bytes) | ||
94 | cluster_size: 65536 | ||
95 | Format specific information: | ||
96 | compat: 1.1 | ||
97 | - compression type: zlib | ||
98 | + compression type: COMPRESSION_TYPE | ||
99 | lazy refcounts: false | ||
100 | bitmaps: | ||
101 | [0]: | ||
102 | @@ -XXX,XX +XXX,XX @@ virtual size: 1 MiB (1048576 bytes) | ||
103 | cluster_size: 65536 | ||
104 | Format specific information: | ||
105 | compat: 1.1 | ||
106 | - compression type: zlib | ||
107 | + compression type: COMPRESSION_TYPE | ||
108 | lazy refcounts: false | ||
109 | bitmaps: | ||
110 | [0]: | ||
111 | @@ -XXX,XX +XXX,XX @@ virtual size: 1 MiB (1048576 bytes) | ||
112 | cluster_size: 65536 | ||
113 | Format specific information: | ||
114 | compat: 1.1 | ||
115 | - compression type: zlib | ||
116 | + compression type: COMPRESSION_TYPE | ||
117 | lazy refcounts: false | ||
118 | bitmaps: | ||
119 | [0]: | ||
120 | diff --git a/tests/qemu-iotests/274.out b/tests/qemu-iotests/274.out | ||
121 | index XXXXXXX..XXXXXXX 100644 | ||
122 | --- a/tests/qemu-iotests/274.out | ||
123 | +++ b/tests/qemu-iotests/274.out | ||
124 | @@ -XXX,XX +XXX,XX @@ backing file: TEST_DIR/PID-base | ||
125 | backing file format: IMGFMT | ||
126 | Format specific information: | ||
127 | compat: 1.1 | ||
128 | - compression type: zlib | ||
129 | + compression type: COMPRESSION_TYPE | ||
130 | lazy refcounts: false | ||
131 | refcount bits: 16 | ||
132 | corrupt: false | ||
133 | @@ -XXX,XX +XXX,XX @@ backing file: TEST_DIR/PID-base | ||
134 | backing file format: IMGFMT | ||
135 | Format specific information: | ||
136 | compat: 1.1 | ||
137 | - compression type: zlib | ||
138 | + compression type: COMPRESSION_TYPE | ||
139 | lazy refcounts: false | ||
140 | refcount bits: 16 | ||
141 | corrupt: false | ||
142 | @@ -XXX,XX +XXX,XX @@ backing file: TEST_DIR/PID-base | ||
143 | backing file format: IMGFMT | ||
144 | Format specific information: | ||
145 | compat: 1.1 | ||
146 | - compression type: zlib | ||
147 | + compression type: COMPRESSION_TYPE | ||
148 | lazy refcounts: false | ||
149 | refcount bits: 16 | ||
150 | corrupt: false | ||
151 | @@ -XXX,XX +XXX,XX @@ virtual size: 2 MiB (2097152 bytes) | ||
152 | cluster_size: 65536 | ||
153 | Format specific information: | ||
154 | compat: 1.1 | ||
155 | - compression type: zlib | ||
156 | + compression type: COMPRESSION_TYPE | ||
157 | lazy refcounts: false | ||
158 | refcount bits: 16 | ||
159 | corrupt: false | ||
160 | @@ -XXX,XX +XXX,XX @@ backing file: TEST_DIR/PID-base | ||
161 | backing file format: IMGFMT | ||
162 | Format specific information: | ||
163 | compat: 1.1 | ||
164 | - compression type: zlib | ||
165 | + compression type: COMPRESSION_TYPE | ||
166 | lazy refcounts: false | ||
167 | refcount bits: 16 | ||
168 | corrupt: false | ||
169 | diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py | ||
170 | index XXXXXXX..XXXXXXX 100644 | ||
171 | --- a/tests/qemu-iotests/iotests.py | ||
172 | +++ b/tests/qemu-iotests/iotests.py | ||
173 | @@ -XXX,XX +XXX,XX @@ def filter_img_info(output, filename): | ||
174 | 'uuid: XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX', | ||
175 | line) | ||
176 | line = re.sub('cid: [0-9]+', 'cid: XXXXXXXXXX', line) | ||
177 | + line = re.sub('(compression type: )(zlib|zstd)', r'\1COMPRESSION_TYPE', | ||
178 | + line) | ||
179 | lines.append(line) | ||
180 | return '\n'.join(lines) | ||
181 | |||
182 | -- | ||
183 | 2.34.1 | ||
184 | |||
185 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | Instead of qemu_img_log("info", ..) use generic helper img_info_log(). | ||
4 | |||
5 | img_info_log() has smarter logic. For example it use filter_img_info() | ||
6 | to filter output, which in turns filter a compression type. So it will | ||
7 | help us in future when we implement a possibility to use zstd | ||
8 | compression by default (with help of some runtime config file or maybe | ||
9 | build option). For now to test you should recompile qemu with a small | ||
10 | addition into block/qcow2.c before | ||
11 | "if (qcow2_opts->has_compression_type": | ||
12 | |||
13 | if (!qcow2_opts->has_compression_type && version >= 3) { | ||
14 | qcow2_opts->has_compression_type = true; | ||
15 | qcow2_opts->compression_type = QCOW2_COMPRESSION_TYPE_ZSTD; | ||
16 | } | ||
17 | |||
18 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
19 | Reviewed-by: Max Reitz <mreitz@redhat.com> | ||
20 | Message-Id: <20211223160144.1097696-12-vsementsov@virtuozzo.com> | ||
21 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
22 | --- | ||
23 | tests/qemu-iotests/302 | 4 +++- | ||
24 | tests/qemu-iotests/302.out | 7 +++---- | ||
25 | 2 files changed, 6 insertions(+), 5 deletions(-) | ||
26 | |||
27 | diff --git a/tests/qemu-iotests/302 b/tests/qemu-iotests/302 | ||
28 | index XXXXXXX..XXXXXXX 100755 | ||
29 | --- a/tests/qemu-iotests/302 | ||
30 | +++ b/tests/qemu-iotests/302 | ||
31 | @@ -XXX,XX +XXX,XX @@ from iotests import ( | ||
32 | qemu_img_measure, | ||
33 | qemu_io, | ||
34 | qemu_nbd_popen, | ||
35 | + img_info_log, | ||
36 | ) | ||
37 | |||
38 | iotests.script_initialize(supported_fmts=["qcow2"]) | ||
39 | @@ -XXX,XX +XXX,XX @@ with tarfile.open(tar_file, "w") as tar: | ||
40 | tar_file): | ||
41 | |||
42 | iotests.log("=== Target image info ===") | ||
43 | + # Not img_info_log as it enforces imgfmt, but now we print info on raw | ||
44 | qemu_img_log("info", nbd_uri) | ||
45 | |||
46 | qemu_img( | ||
47 | @@ -XXX,XX +XXX,XX @@ with tarfile.open(tar_file, "w") as tar: | ||
48 | nbd_uri) | ||
49 | |||
50 | iotests.log("=== Converted image info ===") | ||
51 | - qemu_img_log("info", nbd_uri) | ||
52 | + img_info_log(nbd_uri) | ||
53 | |||
54 | iotests.log("=== Converted image check ===") | ||
55 | qemu_img_log("check", nbd_uri) | ||
56 | diff --git a/tests/qemu-iotests/302.out b/tests/qemu-iotests/302.out | ||
57 | index XXXXXXX..XXXXXXX 100644 | ||
58 | --- a/tests/qemu-iotests/302.out | ||
59 | +++ b/tests/qemu-iotests/302.out | ||
60 | @@ -XXX,XX +XXX,XX @@ virtual size: 448 KiB (458752 bytes) | ||
61 | disk size: unavailable | ||
62 | |||
63 | === Converted image info === | ||
64 | -image: nbd+unix:///exp?socket=SOCK_DIR/PID-nbd-sock | ||
65 | -file format: qcow2 | ||
66 | +image: TEST_IMG | ||
67 | +file format: IMGFMT | ||
68 | virtual size: 1 GiB (1073741824 bytes) | ||
69 | -disk size: unavailable | ||
70 | cluster_size: 65536 | ||
71 | Format specific information: | ||
72 | compat: 1.1 | ||
73 | - compression type: zlib | ||
74 | + compression type: COMPRESSION_TYPE | ||
75 | lazy refcounts: false | ||
76 | refcount bits: 16 | ||
77 | corrupt: false | ||
78 | -- | ||
79 | 2.34.1 | ||
80 | |||
81 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | If image doesn't have any compressed cluster we can easily switch to | ||
4 | zlib compression, which may allow to downgrade the image. | ||
5 | |||
6 | That's mostly needed to support IMGOPTS='compression_type=zstd' in some | ||
7 | iotests which do qcow2 downgrade. | ||
8 | |||
9 | While being here also fix checkpatch complain against '#' in printf | ||
10 | formatting. | ||
11 | |||
12 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
13 | Reviewed-by: Max Reitz <mreitz@redhat.com> | ||
14 | Message-Id: <20211223160144.1097696-13-vsementsov@virtuozzo.com> | ||
15 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
16 | --- | ||
17 | block/qcow2.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++-- | ||
18 | 1 file changed, 56 insertions(+), 2 deletions(-) | ||
19 | |||
20 | diff --git a/block/qcow2.c b/block/qcow2.c | ||
21 | index XXXXXXX..XXXXXXX 100644 | ||
22 | --- a/block/qcow2.c | ||
23 | +++ b/block/qcow2.c | ||
24 | @@ -XXX,XX +XXX,XX @@ static int qcow2_load_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, | ||
25 | return bs->drv->bdrv_co_preadv_part(bs, offset, qiov->size, qiov, 0, 0); | ||
26 | } | ||
27 | |||
28 | +static int qcow2_has_compressed_clusters(BlockDriverState *bs) | ||
29 | +{ | ||
30 | + int64_t offset = 0; | ||
31 | + int64_t bytes = bdrv_getlength(bs); | ||
32 | + | ||
33 | + if (bytes < 0) { | ||
34 | + return bytes; | ||
35 | + } | ||
36 | + | ||
37 | + while (bytes != 0) { | ||
38 | + int ret; | ||
39 | + QCow2SubclusterType type; | ||
40 | + unsigned int cur_bytes = MIN(INT_MAX, bytes); | ||
41 | + uint64_t host_offset; | ||
42 | + | ||
43 | + ret = qcow2_get_host_offset(bs, offset, &cur_bytes, &host_offset, | ||
44 | + &type); | ||
45 | + if (ret < 0) { | ||
46 | + return ret; | ||
47 | + } | ||
48 | + | ||
49 | + if (type == QCOW2_SUBCLUSTER_COMPRESSED) { | ||
50 | + return 1; | ||
51 | + } | ||
52 | + | ||
53 | + offset += cur_bytes; | ||
54 | + bytes -= cur_bytes; | ||
55 | + } | ||
56 | + | ||
57 | + return 0; | ||
58 | +} | ||
59 | + | ||
60 | /* | ||
61 | * Downgrades an image's version. To achieve this, any incompatible features | ||
62 | * have to be removed. | ||
63 | @@ -XXX,XX +XXX,XX @@ static int qcow2_downgrade(BlockDriverState *bs, int target_version, | ||
64 | * the first place; if that happens nonetheless, returning -ENOTSUP is the | ||
65 | * best thing to do anyway */ | ||
66 | |||
67 | - if (s->incompatible_features) { | ||
68 | + if (s->incompatible_features & ~QCOW2_INCOMPAT_COMPRESSION) { | ||
69 | error_setg(errp, "Cannot downgrade an image with incompatible features " | ||
70 | - "%#" PRIx64 " set", s->incompatible_features); | ||
71 | + "0x%" PRIx64 " set", | ||
72 | + s->incompatible_features & ~QCOW2_INCOMPAT_COMPRESSION); | ||
73 | return -ENOTSUP; | ||
74 | } | ||
75 | |||
76 | @@ -XXX,XX +XXX,XX @@ static int qcow2_downgrade(BlockDriverState *bs, int target_version, | ||
77 | return ret; | ||
78 | } | ||
79 | |||
80 | + if (s->incompatible_features & QCOW2_INCOMPAT_COMPRESSION) { | ||
81 | + ret = qcow2_has_compressed_clusters(bs); | ||
82 | + if (ret < 0) { | ||
83 | + error_setg(errp, "Failed to check block status"); | ||
84 | + return -EINVAL; | ||
85 | + } | ||
86 | + if (ret) { | ||
87 | + error_setg(errp, "Cannot downgrade an image with zstd compression " | ||
88 | + "type and existing compressed clusters"); | ||
89 | + return -ENOTSUP; | ||
90 | + } | ||
91 | + /* | ||
92 | + * No compressed clusters for now, so just chose default zlib | ||
93 | + * compression. | ||
94 | + */ | ||
95 | + s->incompatible_features &= ~QCOW2_INCOMPAT_COMPRESSION; | ||
96 | + s->compression_type = QCOW2_COMPRESSION_TYPE_ZLIB; | ||
97 | + } | ||
98 | + | ||
99 | + assert(s->incompatible_features == 0); | ||
100 | + | ||
101 | s->qcow_version = target_version; | ||
102 | ret = qcow2_update_header(bs); | ||
103 | if (ret < 0) { | ||
104 | -- | ||
105 | 2.34.1 | ||
106 | |||
107 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | We'll use it in tests instead of explicit qcow2.py. Then we are going | ||
4 | to add some filtering in _qcow2_dump_header. | ||
5 | |||
6 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
7 | Reviewed-by: Max Reitz <mreitz@redhat.com> | ||
8 | Message-Id: <20211223160144.1097696-14-vsementsov@virtuozzo.com> | ||
9 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
10 | --- | ||
11 | tests/qemu-iotests/common.rc | 10 ++++++++++ | ||
12 | 1 file changed, 10 insertions(+) | ||
13 | |||
14 | diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc | ||
15 | index XXXXXXX..XXXXXXX 100644 | ||
16 | --- a/tests/qemu-iotests/common.rc | ||
17 | +++ b/tests/qemu-iotests/common.rc | ||
18 | @@ -XXX,XX +XXX,XX @@ _require_one_device_of() | ||
19 | _notrun "$* not available" | ||
20 | } | ||
21 | |||
22 | +_qcow2_dump_header() | ||
23 | +{ | ||
24 | + img="$1" | ||
25 | + if [ -z "$img" ]; then | ||
26 | + img="$TEST_IMG" | ||
27 | + fi | ||
28 | + | ||
29 | + $PYTHON qcow2.py "$img" dump-header | ||
30 | +} | ||
31 | + | ||
32 | # make sure this script returns success | ||
33 | true | ||
34 | -- | ||
35 | 2.34.1 | ||
36 | |||
37 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | 1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | |
2 | |||
3 | We are going to add filtering in _qcow2_dump_header and want all tests | ||
4 | use it. | ||
5 | |||
6 | The patch is generated by commands: | ||
7 | cd tests/qemu-iotests | ||
8 | sed -ie 's/$PYTHON qcow2.py "$TEST_IMG" dump-header\($\| \)/_qcow2_dump_header\1/' ??? tests/* | ||
9 | |||
10 | (the difficulty is to avoid converting dump-header-exts) | ||
11 | |||
12 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
13 | Reviewed-by: Max Reitz <mreitz@redhat.com> | ||
14 | Message-Id: <20211223160144.1097696-15-vsementsov@virtuozzo.com> | ||
15 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
16 | --- | ||
17 | tests/qemu-iotests/031 | 6 +++--- | ||
18 | tests/qemu-iotests/036 | 6 +++--- | ||
19 | tests/qemu-iotests/039 | 20 ++++++++++---------- | ||
20 | tests/qemu-iotests/060 | 20 ++++++++++---------- | ||
21 | tests/qemu-iotests/061 | 36 ++++++++++++++++++------------------ | ||
22 | tests/qemu-iotests/137 | 2 +- | ||
23 | tests/qemu-iotests/287 | 8 ++++---- | ||
24 | 7 files changed, 49 insertions(+), 49 deletions(-) | ||
25 | |||
26 | diff --git a/tests/qemu-iotests/031 b/tests/qemu-iotests/031 | ||
27 | index XXXXXXX..XXXXXXX 100755 | ||
28 | --- a/tests/qemu-iotests/031 | ||
29 | +++ b/tests/qemu-iotests/031 | ||
30 | @@ -XXX,XX +XXX,XX @@ for compat in "compat=0.10" "compat=1.1"; do | ||
31 | echo | ||
32 | _make_test_img -o $compat 64M | ||
33 | $PYTHON qcow2.py "$TEST_IMG" add-header-ext 0x12345678 "This is a test header extension" | ||
34 | - $PYTHON qcow2.py "$TEST_IMG" dump-header | ||
35 | + _qcow2_dump_header | ||
36 | _check_test_img | ||
37 | |||
38 | echo | ||
39 | echo === Rewrite header with no backing file === | ||
40 | echo | ||
41 | $QEMU_IMG rebase -u -b "" "$TEST_IMG" | ||
42 | - $PYTHON qcow2.py "$TEST_IMG" dump-header | ||
43 | + _qcow2_dump_header | ||
44 | _check_test_img | ||
45 | |||
46 | echo | ||
47 | echo === Add a backing file and format === | ||
48 | echo | ||
49 | $QEMU_IMG rebase -u -b "/some/backing/file/path" -F host_device "$TEST_IMG" | ||
50 | - $PYTHON qcow2.py "$TEST_IMG" dump-header | ||
51 | + _qcow2_dump_header | ||
52 | done | ||
53 | |||
54 | # success, all done | ||
55 | diff --git a/tests/qemu-iotests/036 b/tests/qemu-iotests/036 | ||
56 | index XXXXXXX..XXXXXXX 100755 | ||
57 | --- a/tests/qemu-iotests/036 | ||
58 | +++ b/tests/qemu-iotests/036 | ||
59 | @@ -XXX,XX +XXX,XX @@ $PYTHON qcow2.py "$TEST_IMG" set-feature-bit incompatible 63 | ||
60 | |||
61 | # Without feature table | ||
62 | $PYTHON qcow2.py "$TEST_IMG" del-header-ext 0x6803f857 | ||
63 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep features | ||
64 | +_qcow2_dump_header | grep features | ||
65 | $PYTHON qcow2.py "$TEST_IMG" dump-header-exts | ||
66 | _img_info | ||
67 | |||
68 | @@ -XXX,XX +XXX,XX @@ echo === Create image with unknown autoclear feature bit === | ||
69 | echo | ||
70 | _make_test_img 64M | ||
71 | $PYTHON qcow2.py "$TEST_IMG" set-feature-bit autoclear 63 | ||
72 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep features | ||
73 | +_qcow2_dump_header | grep features | ||
74 | $PYTHON qcow2.py "$TEST_IMG" dump-header-exts | ||
75 | |||
76 | echo | ||
77 | @@ -XXX,XX +XXX,XX @@ echo === Repair image === | ||
78 | echo | ||
79 | _check_test_img -r all | ||
80 | |||
81 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep features | ||
82 | +_qcow2_dump_header | grep features | ||
83 | $PYTHON qcow2.py "$TEST_IMG" dump-header-exts | ||
84 | |||
85 | # success, all done | ||
86 | diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039 | ||
87 | index XXXXXXX..XXXXXXX 100755 | ||
88 | --- a/tests/qemu-iotests/039 | ||
89 | +++ b/tests/qemu-iotests/039 | ||
90 | @@ -XXX,XX +XXX,XX @@ _make_test_img -o "compat=1.1,lazy_refcounts=on" $size | ||
91 | $QEMU_IO -c "write -P 0x5a 0 512" "$TEST_IMG" | _filter_qemu_io | ||
92 | |||
93 | # The dirty bit must not be set | ||
94 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
95 | +_qcow2_dump_header | grep incompatible_features | ||
96 | _check_test_img | ||
97 | |||
98 | echo | ||
99 | @@ -XXX,XX +XXX,XX @@ $QEMU_IO -c "write -P 0x5a 0 512" \ | ||
100 | | _filter_qemu_io | ||
101 | |||
102 | # The dirty bit must be set | ||
103 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
104 | +_qcow2_dump_header | grep incompatible_features | ||
105 | _check_test_img | ||
106 | |||
107 | echo | ||
108 | @@ -XXX,XX +XXX,XX @@ echo "== Read-only access must still work ==" | ||
109 | $QEMU_IO -r -c "read -P 0x5a 0 512" "$TEST_IMG" | _filter_qemu_io | ||
110 | |||
111 | # The dirty bit must be set | ||
112 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
113 | +_qcow2_dump_header | grep incompatible_features | ||
114 | |||
115 | echo | ||
116 | echo "== Repairing the image file must succeed ==" | ||
117 | @@ -XXX,XX +XXX,XX @@ echo "== Repairing the image file must succeed ==" | ||
118 | _check_test_img -r all | ||
119 | |||
120 | # The dirty bit must not be set | ||
121 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
122 | +_qcow2_dump_header | grep incompatible_features | ||
123 | |||
124 | echo | ||
125 | echo "== Data should still be accessible after repair ==" | ||
126 | @@ -XXX,XX +XXX,XX @@ $QEMU_IO -c "write -P 0x5a 0 512" \ | ||
127 | | _filter_qemu_io | ||
128 | |||
129 | # The dirty bit must be set | ||
130 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
131 | +_qcow2_dump_header | grep incompatible_features | ||
132 | |||
133 | $QEMU_IO -c "write 0 512" "$TEST_IMG" | _filter_qemu_io | ||
134 | |||
135 | # The dirty bit must not be set | ||
136 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
137 | +_qcow2_dump_header | grep incompatible_features | ||
138 | |||
139 | echo | ||
140 | echo "== Creating an image file with lazy_refcounts=off ==" | ||
141 | @@ -XXX,XX +XXX,XX @@ $QEMU_IO -c "write -P 0x5a 0 512" \ | ||
142 | | _filter_qemu_io | ||
143 | |||
144 | # The dirty bit must not be set since lazy_refcounts=off | ||
145 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
146 | +_qcow2_dump_header | grep incompatible_features | ||
147 | _check_test_img | ||
148 | |||
149 | echo | ||
150 | @@ -XXX,XX +XXX,XX @@ $QEMU_IO -c "write 0 512" "$TEST_IMG" | _filter_qemu_io | ||
151 | $QEMU_IMG commit "$TEST_IMG" | ||
152 | |||
153 | # The dirty bit must not be set | ||
154 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
155 | +_qcow2_dump_header | grep incompatible_features | ||
156 | $PYTHON qcow2.py "$TEST_IMG".base dump-header | grep incompatible_features | ||
157 | |||
158 | _check_test_img | ||
159 | @@ -XXX,XX +XXX,XX @@ $QEMU_IO -c "reopen -o lazy-refcounts=on" \ | ||
160 | | _filter_qemu_io | ||
161 | |||
162 | # The dirty bit must be set | ||
163 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
164 | +_qcow2_dump_header | grep incompatible_features | ||
165 | _check_test_img | ||
166 | |||
167 | _make_test_img -o "compat=1.1,lazy_refcounts=on" $size | ||
168 | @@ -XXX,XX +XXX,XX @@ $QEMU_IO -c "reopen -o lazy-refcounts=off" \ | ||
169 | | _filter_qemu_io | ||
170 | |||
171 | # The dirty bit must not be set | ||
172 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
173 | +_qcow2_dump_header | grep incompatible_features | ||
174 | _check_test_img | ||
175 | |||
176 | |||
177 | diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060 | ||
178 | index XXXXXXX..XXXXXXX 100755 | ||
179 | --- a/tests/qemu-iotests/060 | ||
180 | +++ b/tests/qemu-iotests/060 | ||
181 | @@ -XXX,XX +XXX,XX @@ poke_file "$TEST_IMG" "$l1_offset" "\x80\x00\x00\x00\x00\x03\x00\x00" | ||
182 | _check_test_img | ||
183 | |||
184 | # The corrupt bit should not be set anyway | ||
185 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
186 | +_qcow2_dump_header | grep incompatible_features | ||
187 | |||
188 | # Try to write something, thereby forcing the corrupt bit to be set | ||
189 | $QEMU_IO -c "$OPEN_RW" -c "write -P 0x2a 0 512" | _filter_qemu_io | ||
190 | |||
191 | # The corrupt bit must now be set | ||
192 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
193 | +_qcow2_dump_header | grep incompatible_features | ||
194 | |||
195 | # This information should be available through qemu-img info | ||
196 | _img_info --format-specific | ||
197 | @@ -XXX,XX +XXX,XX @@ poke_file "$TEST_IMG" "$(($rb_offset+8))" "\x00\x01" | ||
198 | # Redirect new data cluster onto refcount block | ||
199 | poke_file "$TEST_IMG" "$l2_offset" "\x80\x00\x00\x00\x00\x02\x00\x00" | ||
200 | _check_test_img | ||
201 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
202 | +_qcow2_dump_header | grep incompatible_features | ||
203 | $QEMU_IO -c "$OPEN_RW" -c "write -P 0x2a 0 512" | _filter_qemu_io | ||
204 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
205 | +_qcow2_dump_header | grep incompatible_features | ||
206 | |||
207 | # Try to fix it | ||
208 | _check_test_img -r all | ||
209 | |||
210 | # The corrupt bit should be cleared | ||
211 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
212 | +_qcow2_dump_header | grep incompatible_features | ||
213 | |||
214 | # Look if it's really really fixed | ||
215 | $QEMU_IO -c "$OPEN_RW" -c "write -P 0x2a 0 512" | _filter_qemu_io | ||
216 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
217 | +_qcow2_dump_header | grep incompatible_features | ||
218 | |||
219 | echo | ||
220 | echo "=== Testing cluster data reference into inactive L2 table ===" | ||
221 | @@ -XXX,XX +XXX,XX @@ $QEMU_IO -c "$OPEN_RW" -c "write -P 2 0 512" | _filter_qemu_io | ||
222 | poke_file "$TEST_IMG" "$l2_offset_after_snapshot" \ | ||
223 | "\x80\x00\x00\x00\x00\x04\x00\x00" | ||
224 | _check_test_img | ||
225 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
226 | +_qcow2_dump_header | grep incompatible_features | ||
227 | $QEMU_IO -c "$OPEN_RW" -c "write -P 3 0 512" | _filter_qemu_io | ||
228 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
229 | +_qcow2_dump_header | grep incompatible_features | ||
230 | _check_test_img -r all | ||
231 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
232 | +_qcow2_dump_header | grep incompatible_features | ||
233 | $QEMU_IO -c "$OPEN_RW" -c "write -P 4 0 512" | _filter_qemu_io | ||
234 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
235 | +_qcow2_dump_header | grep incompatible_features | ||
236 | |||
237 | # Check data | ||
238 | $QEMU_IO -c "$OPEN_RO" -c "read -P 4 0 512" | _filter_qemu_io | ||
239 | diff --git a/tests/qemu-iotests/061 b/tests/qemu-iotests/061 | ||
240 | index XXXXXXX..XXXXXXX 100755 | ||
241 | --- a/tests/qemu-iotests/061 | ||
242 | +++ b/tests/qemu-iotests/061 | ||
243 | @@ -XXX,XX +XXX,XX @@ echo "=== Testing version downgrade with zero expansion ===" | ||
244 | echo | ||
245 | _make_test_img -o "compat=1.1,lazy_refcounts=on" 64M | ||
246 | $QEMU_IO -c "write -z 0 128k" "$TEST_IMG" | _filter_qemu_io | ||
247 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
248 | +_qcow2_dump_header | ||
249 | $QEMU_IMG amend -o "compat=0.10" "$TEST_IMG" | ||
250 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
251 | +_qcow2_dump_header | ||
252 | $QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io | ||
253 | _check_test_img | ||
254 | |||
255 | @@ -XXX,XX +XXX,XX @@ _make_test_img -o "compat=1.1,lazy_refcounts=on" 64M | ||
256 | $QEMU_IO -c "write -z 0 128k" "$TEST_IMG" | _filter_qemu_io | ||
257 | $QEMU_IO -c "write -z 32M 128k" "$TEST_IMG" | _filter_qemu_io | ||
258 | $QEMU_IO -c map "$TEST_IMG" | _filter_qemu_io | ||
259 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
260 | +_qcow2_dump_header | ||
261 | $QEMU_IMG amend -o "compat=0.10" --image-opts \ | ||
262 | driver=qcow2,file.filename=$TEST_IMG,l2-cache-entry-size=4096 | ||
263 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
264 | +_qcow2_dump_header | ||
265 | $QEMU_IO -c "read -P 0 0 128k" "$TEST_IMG" | _filter_qemu_io | ||
266 | $QEMU_IO -c "read -P 0 32M 128k" "$TEST_IMG" | _filter_qemu_io | ||
267 | $QEMU_IO -c map "$TEST_IMG" | _filter_qemu_io | ||
268 | @@ -XXX,XX +XXX,XX @@ _make_test_img -o "compat=1.1,lazy_refcounts=on" 64M | ||
269 | _NO_VALGRIND \ | ||
270 | $QEMU_IO -c "write -P 0x2a 0 128k" -c flush \ | ||
271 | -c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 | _filter_qemu_io | ||
272 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
273 | +_qcow2_dump_header | ||
274 | $QEMU_IMG amend -o "compat=0.10" "$TEST_IMG" | ||
275 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
276 | +_qcow2_dump_header | ||
277 | $QEMU_IO -c "read -P 0x2a 0 128k" "$TEST_IMG" | _filter_qemu_io | ||
278 | _check_test_img | ||
279 | |||
280 | @@ -XXX,XX +XXX,XX @@ echo | ||
281 | _make_test_img -o "compat=1.1" 64M | ||
282 | $PYTHON qcow2.py "$TEST_IMG" set-feature-bit compatible 42 | ||
283 | $PYTHON qcow2.py "$TEST_IMG" set-feature-bit autoclear 42 | ||
284 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
285 | +_qcow2_dump_header | ||
286 | $QEMU_IMG amend -o "compat=0.10" "$TEST_IMG" | ||
287 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
288 | +_qcow2_dump_header | ||
289 | _check_test_img | ||
290 | |||
291 | echo | ||
292 | @@ -XXX,XX +XXX,XX @@ echo "=== Testing version upgrade and resize ===" | ||
293 | echo | ||
294 | _make_test_img -o "compat=0.10" 64M | ||
295 | $QEMU_IO -c "write -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io | ||
296 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
297 | +_qcow2_dump_header | ||
298 | $QEMU_IMG amend -o "compat=1.1,lazy_refcounts=on,size=128M" "$TEST_IMG" | ||
299 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
300 | +_qcow2_dump_header | ||
301 | $QEMU_IO -c "read -P 0x2a 42M 64k" "$TEST_IMG" | _filter_qemu_io | ||
302 | _check_test_img | ||
303 | |||
304 | @@ -XXX,XX +XXX,XX @@ $QEMU_IO -c "write -P 0x2a 24M 64k" "$TEST_IMG" | _filter_qemu_io | ||
305 | $QEMU_IMG snapshot -c foo "$TEST_IMG" | ||
306 | $QEMU_IMG resize "$TEST_IMG" 64M && | ||
307 | echo "unexpected pass" | ||
308 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)' | ||
309 | +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' | ||
310 | |||
311 | $QEMU_IMG amend -o "compat=1.1,size=128M" "$TEST_IMG" || | ||
312 | echo "unexpected fail" | ||
313 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)' | ||
314 | +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' | ||
315 | |||
316 | $QEMU_IMG snapshot -c bar "$TEST_IMG" | ||
317 | $QEMU_IMG resize --shrink "$TEST_IMG" 64M || | ||
318 | echo "unexpected fail" | ||
319 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)' | ||
320 | +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' | ||
321 | |||
322 | $QEMU_IMG amend -o "compat=0.10,size=32M" "$TEST_IMG" && | ||
323 | echo "unexpected pass" | ||
324 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)' | ||
325 | +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' | ||
326 | |||
327 | $QEMU_IMG snapshot -a bar "$TEST_IMG" || | ||
328 | echo "unexpected fail" | ||
329 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)' | ||
330 | +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' | ||
331 | |||
332 | $QEMU_IMG snapshot -d bar "$TEST_IMG" | ||
333 | $QEMU_IMG amend -o "compat=0.10,size=32M" "$TEST_IMG" || | ||
334 | echo "unexpected fail" | ||
335 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep '^\(version\|size\|nb_snap\)' | ||
336 | +_qcow2_dump_header | grep '^\(version\|size\|nb_snap\)' | ||
337 | |||
338 | _check_test_img | ||
339 | |||
340 | @@ -XXX,XX +XXX,XX @@ _make_test_img -o "compat=1.1,lazy_refcounts=on" 64M | ||
341 | _NO_VALGRIND \ | ||
342 | $QEMU_IO -c "write -P 0x2a 0 128k" -c flush \ | ||
343 | -c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 | _filter_qemu_io | ||
344 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
345 | +_qcow2_dump_header | ||
346 | $QEMU_IMG amend -o "lazy_refcounts=off" "$TEST_IMG" | ||
347 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | ||
348 | +_qcow2_dump_header | ||
349 | $QEMU_IO -c "read -P 0x2a 0 128k" "$TEST_IMG" | _filter_qemu_io | ||
350 | _check_test_img | ||
351 | |||
352 | diff --git a/tests/qemu-iotests/137 b/tests/qemu-iotests/137 | ||
353 | index XXXXXXX..XXXXXXX 100755 | ||
354 | --- a/tests/qemu-iotests/137 | ||
355 | +++ b/tests/qemu-iotests/137 | ||
356 | @@ -XXX,XX +XXX,XX @@ $QEMU_IO \ | ||
357 | |||
358 | # The dirty bit must not be set | ||
359 | # (Filter the external data file bit) | ||
360 | -if $PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features \ | ||
361 | +if _qcow2_dump_header | grep incompatible_features \ | ||
362 | | grep -q '\<0\>' | ||
363 | then | ||
364 | echo 'ERROR: Dirty bit set' | ||
365 | diff --git a/tests/qemu-iotests/287 b/tests/qemu-iotests/287 | ||
366 | index XXXXXXX..XXXXXXX 100755 | ||
367 | --- a/tests/qemu-iotests/287 | ||
368 | +++ b/tests/qemu-iotests/287 | ||
369 | @@ -XXX,XX +XXX,XX @@ echo | ||
370 | echo "=== Testing compression type incompatible bit setting for zlib ===" | ||
371 | echo | ||
372 | _make_test_img -o compression_type=zlib 64M | ||
373 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
374 | +_qcow2_dump_header | grep incompatible_features | ||
375 | |||
376 | echo | ||
377 | echo "=== Testing compression type incompatible bit setting for zstd ===" | ||
378 | echo | ||
379 | _make_test_img -o compression_type=zstd 64M | ||
380 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
381 | +_qcow2_dump_header | grep incompatible_features | ||
382 | |||
383 | echo | ||
384 | echo "=== Testing zlib with incompatible bit set ===" | ||
385 | @@ -XXX,XX +XXX,XX @@ echo | ||
386 | _make_test_img -o compression_type=zlib 64M | ||
387 | $PYTHON qcow2.py "$TEST_IMG" set-feature-bit incompatible 3 | ||
388 | # to make sure the bit was actually set | ||
389 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
390 | +_qcow2_dump_header | grep incompatible_features | ||
391 | |||
392 | if $QEMU_IMG info "$TEST_IMG" >/dev/null 2>&1 ; then | ||
393 | echo "Error: The image opened successfully. The image must not be opened." | ||
394 | @@ -XXX,XX +XXX,XX @@ echo | ||
395 | _make_test_img -o compression_type=zstd 64M | ||
396 | $PYTHON qcow2.py "$TEST_IMG" set-header incompatible_features 0 | ||
397 | # to make sure the bit was actually unset | ||
398 | -$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features | ||
399 | +_qcow2_dump_header | grep incompatible_features | ||
400 | |||
401 | if $QEMU_IMG info "$TEST_IMG" >/dev/null 2>&1 ; then | ||
402 | echo "Error: The image opened successfully. The image must not be opened." | ||
403 | -- | ||
404 | 2.34.1 | ||
405 | |||
406 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | _qcow2_dump_header has filter for compression type, so this change | ||
4 | makes test pass with IMGOPTS='compression_type=zstd'. | ||
5 | |||
6 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
7 | Reviewed-by: Max Reitz <mreitz@redhat.com> | ||
8 | Message-Id: <20211223160144.1097696-16-vsementsov@virtuozzo.com> | ||
9 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
10 | --- | ||
11 | tests/qemu-iotests/039 | 2 +- | ||
12 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
13 | |||
14 | diff --git a/tests/qemu-iotests/039 b/tests/qemu-iotests/039 | ||
15 | index XXXXXXX..XXXXXXX 100755 | ||
16 | --- a/tests/qemu-iotests/039 | ||
17 | +++ b/tests/qemu-iotests/039 | ||
18 | @@ -XXX,XX +XXX,XX @@ $QEMU_IMG commit "$TEST_IMG" | ||
19 | |||
20 | # The dirty bit must not be set | ||
21 | _qcow2_dump_header | grep incompatible_features | ||
22 | -$PYTHON qcow2.py "$TEST_IMG".base dump-header | grep incompatible_features | ||
23 | +_qcow2_dump_header "$TEST_IMG".base | grep incompatible_features | ||
24 | |||
25 | _check_test_img | ||
26 | TEST_IMG="$TEST_IMG".base _check_test_img | ||
27 | -- | ||
28 | 2.34.1 | ||
29 | |||
30 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | 1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | |
2 | |||
3 | We want iotests pass with both the default zlib compression and with | ||
4 | IMGOPTS='compression_type=zstd'. | ||
5 | |||
6 | Actually the only test that is interested in real compression type in | ||
7 | test output is 287 (test for qcow2 compression type), so implement | ||
8 | specific option for it. | ||
9 | |||
10 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
11 | Reviewed-by: Hanna Reitz <hreitz@redhat.com> | ||
12 | Message-Id: <20211223160144.1097696-17-vsementsov@virtuozzo.com> | ||
13 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
14 | --- | ||
15 | tests/qemu-iotests/060.out | 2 +- | ||
16 | tests/qemu-iotests/061.out | 12 ++++++------ | ||
17 | tests/qemu-iotests/082.out | 14 +++++++------- | ||
18 | tests/qemu-iotests/198.out | 4 ++-- | ||
19 | tests/qemu-iotests/287 | 8 ++++---- | ||
20 | tests/qemu-iotests/common.filter | 8 ++++++++ | ||
21 | tests/qemu-iotests/common.rc | 14 +++++++++++++- | ||
22 | 7 files changed, 41 insertions(+), 21 deletions(-) | ||
23 | |||
24 | diff --git a/tests/qemu-iotests/060.out b/tests/qemu-iotests/060.out | ||
25 | index XXXXXXX..XXXXXXX 100644 | ||
26 | --- a/tests/qemu-iotests/060.out | ||
27 | +++ b/tests/qemu-iotests/060.out | ||
28 | @@ -XXX,XX +XXX,XX @@ virtual size: 64 MiB (67108864 bytes) | ||
29 | cluster_size: 65536 | ||
30 | Format specific information: | ||
31 | compat: 1.1 | ||
32 | - compression type: zlib | ||
33 | + compression type: COMPRESSION_TYPE | ||
34 | lazy refcounts: false | ||
35 | refcount bits: 16 | ||
36 | corrupt: true | ||
37 | diff --git a/tests/qemu-iotests/061.out b/tests/qemu-iotests/061.out | ||
38 | index XXXXXXX..XXXXXXX 100644 | ||
39 | --- a/tests/qemu-iotests/061.out | ||
40 | +++ b/tests/qemu-iotests/061.out | ||
41 | @@ -XXX,XX +XXX,XX @@ virtual size: 64 MiB (67108864 bytes) | ||
42 | cluster_size: 65536 | ||
43 | Format specific information: | ||
44 | compat: 1.1 | ||
45 | - compression type: zlib | ||
46 | + compression type: COMPRESSION_TYPE | ||
47 | lazy refcounts: false | ||
48 | refcount bits: 16 | ||
49 | data file: TEST_DIR/t.IMGFMT.data | ||
50 | @@ -XXX,XX +XXX,XX @@ virtual size: 64 MiB (67108864 bytes) | ||
51 | cluster_size: 65536 | ||
52 | Format specific information: | ||
53 | compat: 1.1 | ||
54 | - compression type: zlib | ||
55 | + compression type: COMPRESSION_TYPE | ||
56 | lazy refcounts: false | ||
57 | refcount bits: 16 | ||
58 | data file: foo | ||
59 | @@ -XXX,XX +XXX,XX @@ virtual size: 64 MiB (67108864 bytes) | ||
60 | cluster_size: 65536 | ||
61 | Format specific information: | ||
62 | compat: 1.1 | ||
63 | - compression type: zlib | ||
64 | + compression type: COMPRESSION_TYPE | ||
65 | lazy refcounts: false | ||
66 | refcount bits: 16 | ||
67 | data file raw: false | ||
68 | @@ -XXX,XX +XXX,XX @@ virtual size: 64 MiB (67108864 bytes) | ||
69 | cluster_size: 65536 | ||
70 | Format specific information: | ||
71 | compat: 1.1 | ||
72 | - compression type: zlib | ||
73 | + compression type: COMPRESSION_TYPE | ||
74 | lazy refcounts: false | ||
75 | refcount bits: 16 | ||
76 | data file: TEST_DIR/t.IMGFMT.data | ||
77 | @@ -XXX,XX +XXX,XX @@ virtual size: 64 MiB (67108864 bytes) | ||
78 | cluster_size: 65536 | ||
79 | Format specific information: | ||
80 | compat: 1.1 | ||
81 | - compression type: zlib | ||
82 | + compression type: COMPRESSION_TYPE | ||
83 | lazy refcounts: false | ||
84 | refcount bits: 16 | ||
85 | data file: TEST_DIR/t.IMGFMT.data | ||
86 | @@ -XXX,XX +XXX,XX @@ virtual size: 64 MiB (67108864 bytes) | ||
87 | cluster_size: 65536 | ||
88 | Format specific information: | ||
89 | compat: 1.1 | ||
90 | - compression type: zlib | ||
91 | + compression type: COMPRESSION_TYPE | ||
92 | lazy refcounts: false | ||
93 | refcount bits: 16 | ||
94 | data file: TEST_DIR/t.IMGFMT.data | ||
95 | diff --git a/tests/qemu-iotests/082.out b/tests/qemu-iotests/082.out | ||
96 | index XXXXXXX..XXXXXXX 100644 | ||
97 | --- a/tests/qemu-iotests/082.out | ||
98 | +++ b/tests/qemu-iotests/082.out | ||
99 | @@ -XXX,XX +XXX,XX @@ virtual size: 128 MiB (134217728 bytes) | ||
100 | cluster_size: 4096 | ||
101 | Format specific information: | ||
102 | compat: 1.1 | ||
103 | - compression type: zlib | ||
104 | + compression type: COMPRESSION_TYPE | ||
105 | lazy refcounts: true | ||
106 | refcount bits: 16 | ||
107 | corrupt: false | ||
108 | @@ -XXX,XX +XXX,XX @@ virtual size: 128 MiB (134217728 bytes) | ||
109 | cluster_size: 8192 | ||
110 | Format specific information: | ||
111 | compat: 1.1 | ||
112 | - compression type: zlib | ||
113 | + compression type: COMPRESSION_TYPE | ||
114 | lazy refcounts: true | ||
115 | refcount bits: 16 | ||
116 | corrupt: false | ||
117 | @@ -XXX,XX +XXX,XX @@ virtual size: 128 MiB (134217728 bytes) | ||
118 | cluster_size: 4096 | ||
119 | Format specific information: | ||
120 | compat: 1.1 | ||
121 | - compression type: zlib | ||
122 | + compression type: COMPRESSION_TYPE | ||
123 | lazy refcounts: true | ||
124 | refcount bits: 16 | ||
125 | corrupt: false | ||
126 | @@ -XXX,XX +XXX,XX @@ virtual size: 128 MiB (134217728 bytes) | ||
127 | cluster_size: 8192 | ||
128 | Format specific information: | ||
129 | compat: 1.1 | ||
130 | - compression type: zlib | ||
131 | + compression type: COMPRESSION_TYPE | ||
132 | lazy refcounts: true | ||
133 | refcount bits: 16 | ||
134 | corrupt: false | ||
135 | @@ -XXX,XX +XXX,XX @@ virtual size: 128 MiB (134217728 bytes) | ||
136 | cluster_size: 65536 | ||
137 | Format specific information: | ||
138 | compat: 1.1 | ||
139 | - compression type: zlib | ||
140 | + compression type: COMPRESSION_TYPE | ||
141 | lazy refcounts: true | ||
142 | refcount bits: 16 | ||
143 | corrupt: false | ||
144 | @@ -XXX,XX +XXX,XX @@ virtual size: 130 MiB (136314880 bytes) | ||
145 | cluster_size: 65536 | ||
146 | Format specific information: | ||
147 | compat: 1.1 | ||
148 | - compression type: zlib | ||
149 | + compression type: COMPRESSION_TYPE | ||
150 | lazy refcounts: false | ||
151 | refcount bits: 16 | ||
152 | corrupt: false | ||
153 | @@ -XXX,XX +XXX,XX @@ virtual size: 132 MiB (138412032 bytes) | ||
154 | cluster_size: 65536 | ||
155 | Format specific information: | ||
156 | compat: 1.1 | ||
157 | - compression type: zlib | ||
158 | + compression type: COMPRESSION_TYPE | ||
159 | lazy refcounts: true | ||
160 | refcount bits: 16 | ||
161 | corrupt: false | ||
162 | diff --git a/tests/qemu-iotests/198.out b/tests/qemu-iotests/198.out | ||
163 | index XXXXXXX..XXXXXXX 100644 | ||
164 | --- a/tests/qemu-iotests/198.out | ||
165 | +++ b/tests/qemu-iotests/198.out | ||
166 | @@ -XXX,XX +XXX,XX @@ image: json:{ /* filtered */ } | ||
167 | file format: IMGFMT | ||
168 | virtual size: 16 MiB (16777216 bytes) | ||
169 | Format specific information: | ||
170 | - compression type: zlib | ||
171 | + compression type: COMPRESSION_TYPE | ||
172 | encrypt: | ||
173 | ivgen alg: plain64 | ||
174 | hash alg: sha256 | ||
175 | @@ -XXX,XX +XXX,XX @@ virtual size: 16 MiB (16777216 bytes) | ||
176 | backing file: TEST_DIR/t.IMGFMT.base | ||
177 | backing file format: IMGFMT | ||
178 | Format specific information: | ||
179 | - compression type: zlib | ||
180 | + compression type: COMPRESSION_TYPE | ||
181 | encrypt: | ||
182 | ivgen alg: plain64 | ||
183 | hash alg: sha256 | ||
184 | diff --git a/tests/qemu-iotests/287 b/tests/qemu-iotests/287 | ||
185 | index XXXXXXX..XXXXXXX 100755 | ||
186 | --- a/tests/qemu-iotests/287 | ||
187 | +++ b/tests/qemu-iotests/287 | ||
188 | @@ -XXX,XX +XXX,XX @@ echo | ||
189 | echo "=== Testing compression type incompatible bit setting for zlib ===" | ||
190 | echo | ||
191 | _make_test_img -o compression_type=zlib 64M | ||
192 | -_qcow2_dump_header | grep incompatible_features | ||
193 | +_qcow2_dump_header --no-filter-compression | grep incompatible_features | ||
194 | |||
195 | echo | ||
196 | echo "=== Testing compression type incompatible bit setting for zstd ===" | ||
197 | echo | ||
198 | _make_test_img -o compression_type=zstd 64M | ||
199 | -_qcow2_dump_header | grep incompatible_features | ||
200 | +_qcow2_dump_header --no-filter-compression | grep incompatible_features | ||
201 | |||
202 | echo | ||
203 | echo "=== Testing zlib with incompatible bit set ===" | ||
204 | @@ -XXX,XX +XXX,XX @@ echo | ||
205 | _make_test_img -o compression_type=zlib 64M | ||
206 | $PYTHON qcow2.py "$TEST_IMG" set-feature-bit incompatible 3 | ||
207 | # to make sure the bit was actually set | ||
208 | -_qcow2_dump_header | grep incompatible_features | ||
209 | +_qcow2_dump_header --no-filter-compression | grep incompatible_features | ||
210 | |||
211 | if $QEMU_IMG info "$TEST_IMG" >/dev/null 2>&1 ; then | ||
212 | echo "Error: The image opened successfully. The image must not be opened." | ||
213 | @@ -XXX,XX +XXX,XX @@ echo | ||
214 | _make_test_img -o compression_type=zstd 64M | ||
215 | $PYTHON qcow2.py "$TEST_IMG" set-header incompatible_features 0 | ||
216 | # to make sure the bit was actually unset | ||
217 | -_qcow2_dump_header | grep incompatible_features | ||
218 | +_qcow2_dump_header --no-filter-compression | grep incompatible_features | ||
219 | |||
220 | if $QEMU_IMG info "$TEST_IMG" >/dev/null 2>&1 ; then | ||
221 | echo "Error: The image opened successfully. The image must not be opened." | ||
222 | diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter | ||
223 | index XXXXXXX..XXXXXXX 100644 | ||
224 | --- a/tests/qemu-iotests/common.filter | ||
225 | +++ b/tests/qemu-iotests/common.filter | ||
226 | @@ -XXX,XX +XXX,XX @@ _filter_img_info() | ||
227 | -e "/block_state_zero: \\(on\\|off\\)/d" \ | ||
228 | -e "/log_size: [0-9]\\+/d" \ | ||
229 | -e "s/iters: [0-9]\\+/iters: 1024/" \ | ||
230 | + -e 's/\(compression type: \)\(zlib\|zstd\)/\1COMPRESSION_TYPE/' \ | ||
231 | -e "s/uuid: [-a-f0-9]\\+/uuid: 00000000-0000-0000-0000-000000000000/" | \ | ||
232 | while IFS='' read -r line; do | ||
233 | if [[ $format_specific == 1 ]]; then | ||
234 | @@ -XXX,XX +XXX,XX @@ _filter_authz_check_tls() | ||
235 | $SED -e 's/TLS x509 authz check for .* is denied/TLS x509 authz check for DISTINGUISHED-NAME is denied/' | ||
236 | } | ||
237 | |||
238 | +_filter_qcow2_compression_type_bit() | ||
239 | +{ | ||
240 | + $SED -e 's/\(incompatible_features\s\+\)\[3\(, \)\?/\1[/' \ | ||
241 | + -e 's/\(incompatible_features.*\), 3\]/\1]/' \ | ||
242 | + -e 's/\(incompatible_features.*\), 3\(,.*\)/\1\2/' | ||
243 | +} | ||
244 | + | ||
245 | # make sure this script returns success | ||
246 | true | ||
247 | diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc | ||
248 | index XXXXXXX..XXXXXXX 100644 | ||
249 | --- a/tests/qemu-iotests/common.rc | ||
250 | +++ b/tests/qemu-iotests/common.rc | ||
251 | @@ -XXX,XX +XXX,XX @@ _img_info() | ||
252 | -e "s#$TEST_DIR#TEST_DIR#g" \ | ||
253 | -e "s#$SOCK_DIR/fuse-#TEST_DIR/#g" \ | ||
254 | -e "s#$IMGFMT#IMGFMT#g" \ | ||
255 | + -e 's/\(compression type: \)\(zlib\|zstd\)/\1COMPRESSION_TYPE/' \ | ||
256 | -e "/^disk size:/ D" \ | ||
257 | -e "/actual-size/ D" | \ | ||
258 | while IFS='' read -r line; do | ||
259 | @@ -XXX,XX +XXX,XX @@ _require_one_device_of() | ||
260 | |||
261 | _qcow2_dump_header() | ||
262 | { | ||
263 | + if [[ "$1" == "--no-filter-compression" ]]; then | ||
264 | + local filter_compression=0 | ||
265 | + shift | ||
266 | + else | ||
267 | + local filter_compression=1 | ||
268 | + fi | ||
269 | + | ||
270 | img="$1" | ||
271 | if [ -z "$img" ]; then | ||
272 | img="$TEST_IMG" | ||
273 | fi | ||
274 | |||
275 | - $PYTHON qcow2.py "$img" dump-header | ||
276 | + if [[ $filter_compression == 0 ]]; then | ||
277 | + $PYTHON qcow2.py "$img" dump-header | ||
278 | + else | ||
279 | + $PYTHON qcow2.py "$img" dump-header | _filter_qcow2_compression_type_bit | ||
280 | + fi | ||
281 | } | ||
282 | |||
283 | # make sure this script returns success | ||
284 | -- | ||
285 | 2.34.1 | ||
286 | |||
287 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | Don't touch other incompatible bits, like compression-type. This makes | ||
4 | the test pass with IMGOPTS='compression_type=zstd'. | ||
5 | |||
6 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
7 | Reviewed-by: Max Reitz <mreitz@redhat.com> | ||
8 | Message-Id: <20211223160144.1097696-18-vsementsov@virtuozzo.com> | ||
9 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
10 | --- | ||
11 | tests/qemu-iotests/060 | 2 +- | ||
12 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
13 | |||
14 | diff --git a/tests/qemu-iotests/060 b/tests/qemu-iotests/060 | ||
15 | index XXXXXXX..XXXXXXX 100755 | ||
16 | --- a/tests/qemu-iotests/060 | ||
17 | +++ b/tests/qemu-iotests/060 | ||
18 | @@ -XXX,XX +XXX,XX @@ _make_test_img 64M | ||
19 | # Let the refblock appear unaligned | ||
20 | poke_file "$TEST_IMG" "$rt_offset" "\x00\x00\x00\x00\xff\xff\x2a\x00" | ||
21 | # Mark the image dirty, thus forcing an automatic check when opening it | ||
22 | -poke_file "$TEST_IMG" 72 "\x00\x00\x00\x00\x00\x00\x00\x01" | ||
23 | +$PYTHON qcow2.py "$TEST_IMG" set-feature-bit incompatible 0 | ||
24 | # Open the image (qemu should refuse to do so) | ||
25 | $QEMU_IO -c close "$TEST_IMG" 2>&1 | _filter_testdir | _filter_imgfmt | ||
26 | |||
27 | -- | ||
28 | 2.34.1 | ||
29 | |||
30 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | The test-case "Corrupted size field in compressed cluster descriptor" | ||
4 | heavily depends on zlib compression type. So, make it explicit. This | ||
5 | way test passes with IMGOPTS='compression_type=zstd'. | ||
6 | |||
7 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
8 | Reviewed-by: Max Reitz <mreitz@redhat.com> | ||
9 | Message-Id: <20211223160144.1097696-19-vsementsov@virtuozzo.com> | ||
10 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
11 | --- | ||
12 | tests/qemu-iotests/214 | 2 +- | ||
13 | 1 file changed, 1 insertion(+), 1 deletion(-) | ||
14 | |||
15 | diff --git a/tests/qemu-iotests/214 b/tests/qemu-iotests/214 | ||
16 | index XXXXXXX..XXXXXXX 100755 | ||
17 | --- a/tests/qemu-iotests/214 | ||
18 | +++ b/tests/qemu-iotests/214 | ||
19 | @@ -XXX,XX +XXX,XX @@ echo | ||
20 | # The L2 entries of the two compressed clusters are located at | ||
21 | # 0x800000 and 0x800008, their original values are 0x4008000000a00000 | ||
22 | # and 0x4008000000a00802 (5 sectors for compressed data each). | ||
23 | -_make_test_img 8M -o cluster_size=2M | ||
24 | +_make_test_img 8M -o cluster_size=2M,compression_type=zlib | ||
25 | $QEMU_IO -c "write -c -P 0x11 0 2M" -c "write -c -P 0x11 2M 2M" "$TEST_IMG" \ | ||
26 | 2>&1 | _filter_qemu_io | _filter_testdir | ||
27 | |||
28 | -- | ||
29 | 2.34.1 | ||
30 | |||
31 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
1 | 2 | ||
3 | compression_type can't be used if we want to create image with | ||
4 | compat=0.10. So, skip these tests, not many of them. | ||
5 | |||
6 | Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | ||
7 | Reviewed-by: Hanna Reitz <hreitz@redhat.com> | ||
8 | Message-Id: <20211223160144.1097696-20-vsementsov@virtuozzo.com> | ||
9 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
10 | --- | ||
11 | tests/qemu-iotests/031 | 5 +++-- | ||
12 | tests/qemu-iotests/051 | 5 +++-- | ||
13 | tests/qemu-iotests/061 | 6 +++++- | ||
14 | tests/qemu-iotests/112 | 3 ++- | ||
15 | tests/qemu-iotests/290 | 2 +- | ||
16 | 5 files changed, 14 insertions(+), 7 deletions(-) | ||
17 | |||
18 | diff --git a/tests/qemu-iotests/031 b/tests/qemu-iotests/031 | ||
19 | index XXXXXXX..XXXXXXX 100755 | ||
20 | --- a/tests/qemu-iotests/031 | ||
21 | +++ b/tests/qemu-iotests/031 | ||
22 | @@ -XXX,XX +XXX,XX @@ trap "_cleanup; exit \$status" 0 1 2 3 15 | ||
23 | _supported_fmt qcow2 | ||
24 | _supported_proto file fuse | ||
25 | # We want to test compat=0.10, which does not support external data | ||
26 | -# files or refcount widths other than 16 | ||
27 | -_unsupported_imgopts data_file 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' | ||
28 | +# files or refcount widths other than 16 or compression type | ||
29 | +_unsupported_imgopts data_file compression_type \ | ||
30 | + 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' | ||
31 | |||
32 | CLUSTER_SIZE=65536 | ||
33 | |||
34 | diff --git a/tests/qemu-iotests/051 b/tests/qemu-iotests/051 | ||
35 | index XXXXXXX..XXXXXXX 100755 | ||
36 | --- a/tests/qemu-iotests/051 | ||
37 | +++ b/tests/qemu-iotests/051 | ||
38 | @@ -XXX,XX +XXX,XX @@ _supported_fmt qcow2 | ||
39 | _supported_proto file | ||
40 | # A compat=0.10 image is created in this test which does not support anything | ||
41 | # other than refcount_bits=16; | ||
42 | -# it also will not support an external data file | ||
43 | -_unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' data_file | ||
44 | +# it also will not support an external data file and compression type | ||
45 | +_unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' data_file \ | ||
46 | + compression_type | ||
47 | _require_drivers nbd | ||
48 | |||
49 | if [ "$QEMU_DEFAULT_MACHINE" = "pc" ]; then | ||
50 | diff --git a/tests/qemu-iotests/061 b/tests/qemu-iotests/061 | ||
51 | index XXXXXXX..XXXXXXX 100755 | ||
52 | --- a/tests/qemu-iotests/061 | ||
53 | +++ b/tests/qemu-iotests/061 | ||
54 | @@ -XXX,XX +XXX,XX @@ _supported_os Linux | ||
55 | # not work with it; | ||
56 | # we have explicit tests for various cluster sizes, the remaining tests | ||
57 | # require the default 64k cluster | ||
58 | -_unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' data_file cluster_size | ||
59 | +# we don't have explicit tests for zstd qcow2 compression type, as zstd may be | ||
60 | +# not compiled in. And we can't create compat images with comression type | ||
61 | +# extension | ||
62 | +_unsupported_imgopts 'refcount_bits=\([^1]\|.\([^6]\|$\)\)' data_file \ | ||
63 | + cluster_size compression_type | ||
64 | |||
65 | echo | ||
66 | echo "=== Testing version downgrade with zero expansion ===" | ||
67 | diff --git a/tests/qemu-iotests/112 b/tests/qemu-iotests/112 | ||
68 | index XXXXXXX..XXXXXXX 100755 | ||
69 | --- a/tests/qemu-iotests/112 | ||
70 | +++ b/tests/qemu-iotests/112 | ||
71 | @@ -XXX,XX +XXX,XX @@ _supported_proto file fuse | ||
72 | # This test will set refcount_bits on its own which would conflict with the | ||
73 | # manual setting; compat will be overridden as well; | ||
74 | # and external data files do not work well with our refcount testing | ||
75 | -_unsupported_imgopts refcount_bits 'compat=0.10' data_file | ||
76 | +# also, compression type is not supported with compat=0.10 used in test | ||
77 | +_unsupported_imgopts refcount_bits 'compat=0.10' data_file compression_type | ||
78 | |||
79 | print_refcount_bits() | ||
80 | { | ||
81 | diff --git a/tests/qemu-iotests/290 b/tests/qemu-iotests/290 | ||
82 | index XXXXXXX..XXXXXXX 100755 | ||
83 | --- a/tests/qemu-iotests/290 | ||
84 | +++ b/tests/qemu-iotests/290 | ||
85 | @@ -XXX,XX +XXX,XX @@ trap "_cleanup; exit \$status" 0 1 2 3 15 | ||
86 | _supported_fmt qcow2 | ||
87 | _supported_proto file fuse | ||
88 | _supported_os Linux | ||
89 | -_unsupported_imgopts 'compat=0.10' refcount_bits data_file | ||
90 | +_unsupported_imgopts 'compat=0.10' refcount_bits data_file compression_type | ||
91 | |||
92 | echo | ||
93 | echo "### Test 'qemu-io -c discard' on a QCOW2 image without a backing file" | ||
94 | -- | ||
95 | 2.34.1 | ||
96 | |||
97 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | After migration, the permissions the guest device wants to impose on its | ||
2 | BlockBackend are stored in blk->perm and blk->shared_perm. In | ||
3 | blk_root_activate(), we take our permissions, but keep all shared | ||
4 | permissions open by calling `blk_set_perm(blk->perm, BLK_PERM_ALL)`. | ||
1 | 5 | ||
6 | Only afterwards (immediately or later, depending on the runstate) do we | ||
7 | restrict the shared permissions by calling | ||
8 | `blk_set_perm(blk->perm, blk->shared_perm)`. Unfortunately, our first | ||
9 | call with shared_perm=BLK_PERM_ALL has overwritten blk->shared_perm to | ||
10 | be BLK_PERM_ALL, so this is a no-op and the set of shared permissions is | ||
11 | not restricted. | ||
12 | |||
13 | Fix this bug by saving the set of shared permissions before invoking | ||
14 | blk_set_perm() with BLK_PERM_ALL and restoring it afterwards. | ||
15 | |||
16 | Fixes: 5f7772c4d0cf32f4e779fcd5a69ae4dae24aeebf | ||
17 | ("block-backend: Defer shared_perm tightening migration | ||
18 | completion") | ||
19 | Reported-by: Peng Liang <liangpeng10@huawei.com> | ||
20 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
21 | Message-Id: <20211125135317.186576-2-hreitz@redhat.com> | ||
22 | Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> | ||
23 | Tested-by: Peng Liang <liangpeng10@huawei.com> | ||
24 | --- | ||
25 | block/block-backend.c | 11 +++++++++++ | ||
26 | 1 file changed, 11 insertions(+) | ||
27 | |||
28 | diff --git a/block/block-backend.c b/block/block-backend.c | ||
29 | index XXXXXXX..XXXXXXX 100644 | ||
30 | --- a/block/block-backend.c | ||
31 | +++ b/block/block-backend.c | ||
32 | @@ -XXX,XX +XXX,XX @@ static void blk_root_activate(BdrvChild *child, Error **errp) | ||
33 | { | ||
34 | BlockBackend *blk = child->opaque; | ||
35 | Error *local_err = NULL; | ||
36 | + uint64_t saved_shared_perm; | ||
37 | |||
38 | if (!blk->disable_perm) { | ||
39 | return; | ||
40 | @@ -XXX,XX +XXX,XX @@ static void blk_root_activate(BdrvChild *child, Error **errp) | ||
41 | |||
42 | blk->disable_perm = false; | ||
43 | |||
44 | + /* | ||
45 | + * blk->shared_perm contains the permissions we want to share once | ||
46 | + * migration is really completely done. For now, we need to share | ||
47 | + * all; but we also need to retain blk->shared_perm, which is | ||
48 | + * overwritten by a successful blk_set_perm() call. Save it and | ||
49 | + * restore it below. | ||
50 | + */ | ||
51 | + saved_shared_perm = blk->shared_perm; | ||
52 | + | ||
53 | blk_set_perm(blk, blk->perm, BLK_PERM_ALL, &local_err); | ||
54 | if (local_err) { | ||
55 | error_propagate(errp, local_err); | ||
56 | blk->disable_perm = true; | ||
57 | return; | ||
58 | } | ||
59 | + blk->shared_perm = saved_shared_perm; | ||
60 | |||
61 | if (runstate_check(RUN_STATE_INMIGRATE)) { | ||
62 | /* Activation can happen when migration process is still active, for | ||
63 | -- | ||
64 | 2.34.1 | ||
65 | |||
66 | diff view generated by jsdifflib |
1 | It was reported that enabling SafeStack reduces IOPS significantly | 1 | This test checks that a raw image in use by a virtio-blk device does not |
---|---|---|---|
2 | (>25%) with the following fio benchmark on virtio-blk using a NVMe host | 2 | share the WRITE permission both before and after migration. |
3 | block device: | ||
4 | 3 | ||
5 | # fio --rw=randrw --bs=4k --iodepth=64 --runtime=1m --direct=1 \ | 4 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> |
6 | --filename=/dev/vdb --name=job1 --ioengine=libaio --thread \ | 5 | --- |
7 | --group_reporting --numjobs=16 --time_based \ | 6 | .../qemu-iotests/tests/migration-permissions | 101 ++++++++++++++++++ |
8 | --output=/tmp/fio_result | 7 | .../tests/migration-permissions.out | 5 + |
8 | 2 files changed, 106 insertions(+) | ||
9 | create mode 100755 tests/qemu-iotests/tests/migration-permissions | ||
10 | create mode 100644 tests/qemu-iotests/tests/migration-permissions.out | ||
9 | 11 | ||
10 | Serge Guelton and I found that SafeStack is not really at fault, it just | 12 | diff --git a/tests/qemu-iotests/tests/migration-permissions b/tests/qemu-iotests/tests/migration-permissions |
11 | increases the cost of coroutine creation. This fio workload exhausts the | 13 | new file mode 100755 |
12 | coroutine pool and coroutine creation becomes a bottleneck. Previous | 14 | index XXXXXXX..XXXXXXX |
13 | work by Honghao Wang also pointed to excessive coroutine creation. | 15 | --- /dev/null |
14 | 16 | +++ b/tests/qemu-iotests/tests/migration-permissions | |
15 | Creating new coroutines is expensive due to allocating new stacks with | 17 | @@ -XXX,XX +XXX,XX @@ |
16 | mmap(2) and mprotect(2). Currently there are thread-local and global | 18 | +#!/usr/bin/env python3 |
17 | pools that recycle old Coroutine objects and their stacks but the | 19 | +# group: migration |
18 | hardcoded size limit of 64 for thread-local pools and 128 for the global | 20 | +# |
19 | pool is insufficient for the fio benchmark shown above. | 21 | +# Copyright (C) 2021 Red Hat, Inc. |
20 | 22 | +# | |
21 | This patch changes the coroutine pool algorithm to a simple thread-local | 23 | +# This program is free software; you can redistribute it and/or modify |
22 | pool without a maximum size limit. Threads periodically shrink the pool | 24 | +# it under the terms of the GNU General Public License as published by |
23 | down to a size sufficient for the maximum observed number of coroutines. | 25 | +# the Free Software Foundation; either version 2 of the License, or |
24 | 26 | +# (at your option) any later version. | |
25 | The global pool is removed by this patch. It can help to hide the fact | 27 | +# |
26 | that local pools are easily exhausted, but it's doesn't fix the root | 28 | +# This program is distributed in the hope that it will be useful, |
27 | cause. I don't think there is a need for a global pool because QEMU's | 29 | +# but WITHOUT ANY WARRANTY; without even the implied warranty of |
28 | threads are long-lived, so let's keep things simple. | 30 | +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
29 | 31 | +# GNU General Public License for more details. | |
30 | Performance of the above fio benchmark is as follows: | 32 | +# |
31 | 33 | +# You should have received a copy of the GNU General Public License | |
32 | Before After | 34 | +# along with this program. If not, see <http://www.gnu.org/licenses/>. |
33 | IOPS 60k 97k | 35 | +# |
34 | 36 | + | |
35 | Memory usage varies over time as needed by the workload: | 37 | +import os |
36 | 38 | +import iotests | |
37 | VSZ (KB) RSS (KB) | 39 | +from iotests import imgfmt, qemu_img_create, qemu_io |
38 | Before fio 4705248 843128 | 40 | + |
39 | During fio 5747668 (+ ~100 MB) 849280 | 41 | + |
40 | After fio 4694996 (- ~100 MB) 845184 | 42 | +test_img = os.path.join(iotests.test_dir, 'test.img') |
41 | 43 | +mig_sock = os.path.join(iotests.sock_dir, 'mig.sock') | |
42 | This confirms that coroutines are indeed being freed when no longer | 44 | + |
43 | needed. | 45 | + |
44 | 46 | +class TestMigrationPermissions(iotests.QMPTestCase): | |
45 | Thanks to Serge Guelton for working on identifying the bottleneck with | 47 | + def setUp(self): |
46 | me! | 48 | + qemu_img_create('-f', imgfmt, test_img, '1M') |
47 | 49 | + | |
48 | Reported-by: Tingting Mao <timao@redhat.com> | 50 | + # Set up two VMs (source and destination) accessing the same raw |
49 | Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> | 51 | + # image file with a virtio-blk device; prepare the destination for |
50 | Message-id: 20210913153524.1190696-1-stefanha@redhat.com | 52 | + # migration with .add_incoming() and enable migration events |
51 | Cc: Serge Guelton <sguelton@redhat.com> | 53 | + vms = [None, None] |
52 | Cc: Honghao Wang <wanghonghao@bytedance.com> | 54 | + for i in range(2): |
53 | Cc: Paolo Bonzini <pbonzini@redhat.com> | 55 | + vms[i] = iotests.VM(path_suffix=f'{i}') |
54 | Cc: Daniele Buono <dbuono@linux.vnet.ibm.com> | 56 | + vms[i].add_blockdev(f'file,node-name=prot,filename={test_img}') |
55 | Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> | 57 | + vms[i].add_blockdev(f'{imgfmt},node-name=fmt,file=prot') |
56 | 58 | + vms[i].add_device('virtio-blk,drive=fmt') | |
57 | [Moved atexit notifier to coroutine_delete() after GitLab CI reported a | 59 | + |
58 | memory leak in tests/unit/test-aio-multithread because the Coroutine | 60 | + if i == 1: |
59 | object was created in the main thread but runs in an IOThread (where | 61 | + vms[i].add_incoming(f'unix:{mig_sock}') |
60 | it's also deleted). | 62 | + |
61 | --Stefan] | 63 | + vms[i].launch() |
62 | --- | 64 | + |
63 | include/qemu/coroutine-pool-timer.h | 36 ++++++++++++++++ | 65 | + result = vms[i].qmp('migrate-set-capabilities', |
64 | include/qemu/coroutine.h | 7 ++++ | 66 | + capabilities=[ |
65 | iothread.c | 6 +++ | 67 | + {'capability': 'events', 'state': True} |
66 | util/coroutine-pool-timer.c | 35 ++++++++++++++++ | 68 | + ]) |
67 | util/main-loop.c | 5 +++ | 69 | + self.assert_qmp(result, 'return', {}) |
68 | util/qemu-coroutine.c | 64 ++++++++++++++++------------- | 70 | + |
69 | util/meson.build | 1 + | 71 | + self.vm_s = vms[0] |
70 | 7 files changed, 125 insertions(+), 29 deletions(-) | 72 | + self.vm_d = vms[1] |
71 | create mode 100644 include/qemu/coroutine-pool-timer.h | 73 | + |
72 | create mode 100644 util/coroutine-pool-timer.c | 74 | + def tearDown(self): |
73 | 75 | + self.vm_s.shutdown() | |
74 | diff --git a/include/qemu/coroutine-pool-timer.h b/include/qemu/coroutine-pool-timer.h | 76 | + self.vm_d.shutdown() |
77 | + try: | ||
78 | + os.remove(mig_sock) | ||
79 | + except FileNotFoundError: | ||
80 | + pass | ||
81 | + os.remove(test_img) | ||
82 | + | ||
83 | + # Migrate an image in use by a virtio-blk device to another VM and | ||
84 | + # verify that the WRITE permission is unshared both before and after | ||
85 | + # migration | ||
86 | + def test_post_migration_permissions(self): | ||
87 | + # Try to access the image R/W, which should fail because virtio-blk | ||
88 | + # has not been configured with share-rw=on | ||
89 | + log = qemu_io('-f', imgfmt, '-c', 'quit', test_img) | ||
90 | + if not log.strip(): | ||
91 | + print('ERROR (pre-migration): qemu-io should not be able to ' | ||
92 | + 'access this image, but it reported no error') | ||
93 | + else: | ||
94 | + # This is the expected output | ||
95 | + assert 'Is another process using the image' in log | ||
96 | + | ||
97 | + # Now migrate the VM | ||
98 | + self.vm_s.qmp('migrate', uri=f'unix:{mig_sock}') | ||
99 | + assert self.vm_s.wait_migration(None) | ||
100 | + assert self.vm_d.wait_migration(None) | ||
101 | + | ||
102 | + # Try the same qemu-io access again, verifying that the WRITE | ||
103 | + # permission remains unshared | ||
104 | + log = qemu_io('-f', imgfmt, '-c', 'quit', test_img) | ||
105 | + if not log.strip(): | ||
106 | + print('ERROR (post-migration): qemu-io should not be able to ' | ||
107 | + 'access this image, but it reported no error') | ||
108 | + else: | ||
109 | + # This is the expected output | ||
110 | + assert 'Is another process using the image' in log | ||
111 | + | ||
112 | + | ||
113 | +if __name__ == '__main__': | ||
114 | + # Only works with raw images because we are testing the | ||
115 | + # BlockBackend permissions; image format drivers may additionally | ||
116 | + # unshare permissions and thus tamper with the result | ||
117 | + iotests.main(supported_fmts=['raw'], | ||
118 | + supported_protocols=['file']) | ||
119 | diff --git a/tests/qemu-iotests/tests/migration-permissions.out b/tests/qemu-iotests/tests/migration-permissions.out | ||
75 | new file mode 100644 | 120 | new file mode 100644 |
76 | index XXXXXXX..XXXXXXX | 121 | index XXXXXXX..XXXXXXX |
77 | --- /dev/null | 122 | --- /dev/null |
78 | +++ b/include/qemu/coroutine-pool-timer.h | 123 | +++ b/tests/qemu-iotests/tests/migration-permissions.out |
79 | @@ -XXX,XX +XXX,XX @@ | 124 | @@ -XXX,XX +XXX,XX @@ |
80 | +/* | 125 | +. |
81 | + * QEMU coroutine pool timer | 126 | +---------------------------------------------------------------------- |
82 | + * | 127 | +Ran 1 tests |
83 | + * Copyright (c) 2021 Red Hat, Inc. | ||
84 | + * | ||
85 | + * SPDX-License-Identifier: LGPL-2.1-or-later | ||
86 | + * | ||
87 | + * This work is licensed under the terms of the GNU LGPL, version 2.1 or later. | ||
88 | + * See the COPYING.LIB file in the top-level directory. | ||
89 | + * | ||
90 | + */ | ||
91 | +#ifndef COROUTINE_POOL_TIMER_H | ||
92 | +#define COROUTINE_POOL_TIMER_H | ||
93 | + | 128 | + |
94 | +#include "qemu/osdep.h" | 129 | +OK |
95 | +#include "block/aio.h" | ||
96 | + | ||
97 | +/** | ||
98 | + * A timer that periodically resizes this thread's coroutine pool, freeing | ||
99 | + * memory if there are too many unused coroutines. | ||
100 | + * | ||
101 | + * Threads that make heavy use of coroutines should use this. Failure to resize | ||
102 | + * the coroutine pool can lead to large amounts of memory sitting idle and | ||
103 | + * never being used after the first time. | ||
104 | + */ | ||
105 | +typedef struct { | ||
106 | + QEMUTimer *timer; | ||
107 | +} CoroutinePoolTimer; | ||
108 | + | ||
109 | +/* Call this before the thread runs the AioContext */ | ||
110 | +void coroutine_pool_timer_init(CoroutinePoolTimer *pt, AioContext *ctx); | ||
111 | + | ||
112 | +/* Call this before the AioContext from the init function is destroyed */ | ||
113 | +void coroutine_pool_timer_cleanup(CoroutinePoolTimer *pt); | ||
114 | + | ||
115 | +#endif /* COROUTINE_POOL_TIMER_H */ | ||
116 | diff --git a/include/qemu/coroutine.h b/include/qemu/coroutine.h | ||
117 | index XXXXXXX..XXXXXXX 100644 | ||
118 | --- a/include/qemu/coroutine.h | ||
119 | +++ b/include/qemu/coroutine.h | ||
120 | @@ -XXX,XX +XXX,XX @@ bool qemu_in_coroutine(void); | ||
121 | */ | ||
122 | bool qemu_coroutine_entered(Coroutine *co); | ||
123 | |||
124 | +/** | ||
125 | + * Optionally call this function periodically to shrink the thread-local pool | ||
126 | + * down. Spiky workloads can create many coroutines and then never reach that | ||
127 | + * level again. Shrinking the pool reclaims memory in this case. | ||
128 | + */ | ||
129 | +void qemu_coroutine_pool_periodic_resize(void); | ||
130 | + | ||
131 | /** | ||
132 | * Provides a mutex that can be used to synchronise coroutines | ||
133 | */ | ||
134 | diff --git a/iothread.c b/iothread.c | ||
135 | index XXXXXXX..XXXXXXX 100644 | ||
136 | --- a/iothread.c | ||
137 | +++ b/iothread.c | ||
138 | @@ -XXX,XX +XXX,XX @@ | ||
139 | #include "qemu/error-report.h" | ||
140 | #include "qemu/rcu.h" | ||
141 | #include "qemu/main-loop.h" | ||
142 | +#include "qemu/coroutine-pool-timer.h" | ||
143 | |||
144 | typedef ObjectClass IOThreadClass; | ||
145 | |||
146 | @@ -XXX,XX +XXX,XX @@ DECLARE_CLASS_CHECKERS(IOThreadClass, IOTHREAD, | ||
147 | static void *iothread_run(void *opaque) | ||
148 | { | ||
149 | IOThread *iothread = opaque; | ||
150 | + CoroutinePoolTimer co_pool_timer; | ||
151 | |||
152 | rcu_register_thread(); | ||
153 | /* | ||
154 | @@ -XXX,XX +XXX,XX @@ static void *iothread_run(void *opaque) | ||
155 | iothread->thread_id = qemu_get_thread_id(); | ||
156 | qemu_sem_post(&iothread->init_done_sem); | ||
157 | |||
158 | + coroutine_pool_timer_init(&co_pool_timer, iothread->ctx); | ||
159 | + | ||
160 | while (iothread->running) { | ||
161 | /* | ||
162 | * Note: from functional-wise the g_main_loop_run() below can | ||
163 | @@ -XXX,XX +XXX,XX @@ static void *iothread_run(void *opaque) | ||
164 | } | ||
165 | } | ||
166 | |||
167 | + coroutine_pool_timer_cleanup(&co_pool_timer); | ||
168 | + | ||
169 | g_main_context_pop_thread_default(iothread->worker_context); | ||
170 | rcu_unregister_thread(); | ||
171 | return NULL; | ||
172 | diff --git a/util/coroutine-pool-timer.c b/util/coroutine-pool-timer.c | ||
173 | new file mode 100644 | ||
174 | index XXXXXXX..XXXXXXX | ||
175 | --- /dev/null | ||
176 | +++ b/util/coroutine-pool-timer.c | ||
177 | @@ -XXX,XX +XXX,XX @@ | ||
178 | +/* | ||
179 | + * QEMU coroutine pool timer | ||
180 | + * | ||
181 | + * Copyright (c) 2021 Red Hat, Inc. | ||
182 | + * | ||
183 | + * SPDX-License-Identifier: LGPL-2.1-or-later | ||
184 | + * | ||
185 | + * This work is licensed under the terms of the GNU LGPL, version 2.1 or later. | ||
186 | + * See the COPYING.LIB file in the top-level directory. | ||
187 | + * | ||
188 | + */ | ||
189 | +#include "qemu/coroutine-pool-timer.h" | ||
190 | + | ||
191 | +static void coroutine_pool_timer_cb(void *opaque) | ||
192 | +{ | ||
193 | + CoroutinePoolTimer *pt = opaque; | ||
194 | + int64_t expiry_time_ns = qemu_clock_get_ns(QEMU_CLOCK_REALTIME) + | ||
195 | + 15 * NANOSECONDS_PER_SECOND; | ||
196 | + | ||
197 | + qemu_coroutine_pool_periodic_resize(); | ||
198 | + timer_mod(pt->timer, expiry_time_ns); | ||
199 | +} | ||
200 | + | ||
201 | +void coroutine_pool_timer_init(CoroutinePoolTimer *pt, AioContext *ctx) | ||
202 | +{ | ||
203 | + pt->timer = aio_timer_new(ctx, QEMU_CLOCK_REALTIME, SCALE_NS, | ||
204 | + coroutine_pool_timer_cb, pt); | ||
205 | + coroutine_pool_timer_cb(pt); | ||
206 | +} | ||
207 | + | ||
208 | +void coroutine_pool_timer_cleanup(CoroutinePoolTimer *pt) | ||
209 | +{ | ||
210 | + timer_free(pt->timer); | ||
211 | + pt->timer = NULL; | ||
212 | +} | ||
213 | diff --git a/util/main-loop.c b/util/main-loop.c | ||
214 | index XXXXXXX..XXXXXXX 100644 | ||
215 | --- a/util/main-loop.c | ||
216 | +++ b/util/main-loop.c | ||
217 | @@ -XXX,XX +XXX,XX @@ | ||
218 | #include "qemu/error-report.h" | ||
219 | #include "qemu/queue.h" | ||
220 | #include "qemu/compiler.h" | ||
221 | +#include "qemu/coroutine-pool-timer.h" | ||
222 | |||
223 | #ifndef _WIN32 | ||
224 | #include <sys/wait.h> | ||
225 | @@ -XXX,XX +XXX,XX @@ static int qemu_signal_init(Error **errp) | ||
226 | |||
227 | static AioContext *qemu_aio_context; | ||
228 | static QEMUBH *qemu_notify_bh; | ||
229 | +static CoroutinePoolTimer main_loop_co_pool_timer; | ||
230 | |||
231 | static void notify_event_cb(void *opaque) | ||
232 | { | ||
233 | @@ -XXX,XX +XXX,XX @@ int qemu_init_main_loop(Error **errp) | ||
234 | g_source_set_name(src, "io-handler"); | ||
235 | g_source_attach(src, NULL); | ||
236 | g_source_unref(src); | ||
237 | + | ||
238 | + coroutine_pool_timer_init(&main_loop_co_pool_timer, qemu_aio_context); | ||
239 | + | ||
240 | return 0; | ||
241 | } | ||
242 | |||
243 | diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c | ||
244 | index XXXXXXX..XXXXXXX 100644 | ||
245 | --- a/util/qemu-coroutine.c | ||
246 | +++ b/util/qemu-coroutine.c | ||
247 | @@ -XXX,XX +XXX,XX @@ | ||
248 | #include "block/aio.h" | ||
249 | |||
250 | enum { | ||
251 | - POOL_BATCH_SIZE = 64, | ||
252 | + /* | ||
253 | + * qemu_coroutine_pool_periodic_resize() keeps at least this many | ||
254 | + * coroutines around. | ||
255 | + */ | ||
256 | + ALLOC_POOL_MIN = 64, | ||
257 | }; | ||
258 | |||
259 | + | ||
260 | /** Free list to speed up creation */ | ||
261 | -static QSLIST_HEAD(, Coroutine) release_pool = QSLIST_HEAD_INITIALIZER(pool); | ||
262 | -static unsigned int release_pool_size; | ||
263 | static __thread QSLIST_HEAD(, Coroutine) alloc_pool = QSLIST_HEAD_INITIALIZER(pool); | ||
264 | static __thread unsigned int alloc_pool_size; | ||
265 | +static __thread unsigned int num_coroutines; | ||
266 | +static __thread unsigned int max_coroutines_this_slice; | ||
267 | static __thread Notifier coroutine_pool_cleanup_notifier; | ||
268 | |||
269 | static void coroutine_pool_cleanup(Notifier *n, void *value) | ||
270 | @@ -XXX,XX +XXX,XX @@ Coroutine *qemu_coroutine_create(CoroutineEntry *entry, void *opaque) | ||
271 | |||
272 | if (CONFIG_COROUTINE_POOL) { | ||
273 | co = QSLIST_FIRST(&alloc_pool); | ||
274 | - if (!co) { | ||
275 | - if (release_pool_size > POOL_BATCH_SIZE) { | ||
276 | - /* Slow path; a good place to register the destructor, too. */ | ||
277 | - if (!coroutine_pool_cleanup_notifier.notify) { | ||
278 | - coroutine_pool_cleanup_notifier.notify = coroutine_pool_cleanup; | ||
279 | - qemu_thread_atexit_add(&coroutine_pool_cleanup_notifier); | ||
280 | - } | ||
281 | - | ||
282 | - /* This is not exact; there could be a little skew between | ||
283 | - * release_pool_size and the actual size of release_pool. But | ||
284 | - * it is just a heuristic, it does not need to be perfect. | ||
285 | - */ | ||
286 | - alloc_pool_size = qatomic_xchg(&release_pool_size, 0); | ||
287 | - QSLIST_MOVE_ATOMIC(&alloc_pool, &release_pool); | ||
288 | - co = QSLIST_FIRST(&alloc_pool); | ||
289 | - } | ||
290 | - } | ||
291 | if (co) { | ||
292 | QSLIST_REMOVE_HEAD(&alloc_pool, pool_next); | ||
293 | alloc_pool_size--; | ||
294 | } | ||
295 | + | ||
296 | + num_coroutines++; | ||
297 | + if (num_coroutines > max_coroutines_this_slice) { | ||
298 | + max_coroutines_this_slice = num_coroutines; | ||
299 | + } | ||
300 | } | ||
301 | |||
302 | if (!co) { | ||
303 | @@ -XXX,XX +XXX,XX @@ static void coroutine_delete(Coroutine *co) | ||
304 | co->caller = NULL; | ||
305 | |||
306 | if (CONFIG_COROUTINE_POOL) { | ||
307 | - if (release_pool_size < POOL_BATCH_SIZE * 2) { | ||
308 | - QSLIST_INSERT_HEAD_ATOMIC(&release_pool, co, pool_next); | ||
309 | - qatomic_inc(&release_pool_size); | ||
310 | - return; | ||
311 | - } | ||
312 | - if (alloc_pool_size < POOL_BATCH_SIZE) { | ||
313 | - QSLIST_INSERT_HEAD(&alloc_pool, co, pool_next); | ||
314 | - alloc_pool_size++; | ||
315 | - return; | ||
316 | + if (!coroutine_pool_cleanup_notifier.notify) { | ||
317 | + coroutine_pool_cleanup_notifier.notify = coroutine_pool_cleanup; | ||
318 | + qemu_thread_atexit_add(&coroutine_pool_cleanup_notifier); | ||
319 | } | ||
320 | + | ||
321 | + num_coroutines--; | ||
322 | + QSLIST_INSERT_HEAD(&alloc_pool, co, pool_next); | ||
323 | + alloc_pool_size++; | ||
324 | + return; | ||
325 | } | ||
326 | |||
327 | qemu_coroutine_delete(co); | ||
328 | } | ||
329 | |||
330 | +void qemu_coroutine_pool_periodic_resize(void) | ||
331 | +{ | ||
332 | + unsigned pool_size_target = | ||
333 | + MAX(ALLOC_POOL_MIN, max_coroutines_this_slice) - num_coroutines; | ||
334 | + max_coroutines_this_slice = num_coroutines; | ||
335 | + | ||
336 | + while (alloc_pool_size > pool_size_target) { | ||
337 | + Coroutine *co = QSLIST_FIRST(&alloc_pool); | ||
338 | + QSLIST_REMOVE_HEAD(&alloc_pool, pool_next); | ||
339 | + qemu_coroutine_delete(co); | ||
340 | + alloc_pool_size--; | ||
341 | + } | ||
342 | +} | ||
343 | + | ||
344 | void qemu_aio_coroutine_enter(AioContext *ctx, Coroutine *co) | ||
345 | { | ||
346 | QSIMPLEQ_HEAD(, Coroutine) pending = QSIMPLEQ_HEAD_INITIALIZER(pending); | ||
347 | diff --git a/util/meson.build b/util/meson.build | ||
348 | index XXXXXXX..XXXXXXX 100644 | ||
349 | --- a/util/meson.build | ||
350 | +++ b/util/meson.build | ||
351 | @@ -XXX,XX +XXX,XX @@ if have_block | ||
352 | util_ss.add(files('buffer.c')) | ||
353 | util_ss.add(files('bufferiszero.c')) | ||
354 | util_ss.add(files('coroutine-@0@.c'.format(config_host['CONFIG_COROUTINE_BACKEND']))) | ||
355 | + util_ss.add(files('coroutine-pool-timer.c')) | ||
356 | util_ss.add(files('hbitmap.c')) | ||
357 | util_ss.add(files('hexdump.c')) | ||
358 | util_ss.add(files('iova-tree.c')) | ||
359 | -- | 130 | -- |
360 | 2.31.1 | 131 | 2.34.1 |
361 | 132 | ||
362 | 133 | diff view generated by jsdifflib |
New patch | |||
---|---|---|---|
1 | From: Emanuele Giuseppe Esposito <eesposit@redhat.com> | ||
1 | 2 | ||
3 | The comment "disk I/O throttling" doesn't make any sense at all | ||
4 | any more. It was added in commit 0563e191516 to describe | ||
5 | bdrv_io_limits_enable()/disable(), which were removed in commit | ||
6 | 97148076, so the comment is just a forgotten leftover. | ||
7 | |||
8 | Suggested-by: Kevin Wolf <kwolf@redhat.com> | ||
9 | Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com> | ||
10 | Message-Id: <20220131125615.74612-1-eesposit@redhat.com> | ||
11 | Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> | ||
12 | Signed-off-by: Hanna Reitz <hreitz@redhat.com> | ||
13 | --- | ||
14 | include/block/block.h | 1 - | ||
15 | 1 file changed, 1 deletion(-) | ||
16 | |||
17 | diff --git a/include/block/block.h b/include/block/block.h | ||
18 | index XXXXXXX..XXXXXXX 100644 | ||
19 | --- a/include/block/block.h | ||
20 | +++ b/include/block/block.h | ||
21 | @@ -XXX,XX +XXX,XX @@ typedef unsigned int BdrvChildRole; | ||
22 | char *bdrv_perm_names(uint64_t perm); | ||
23 | uint64_t bdrv_qapi_perm_to_blk_perm(BlockPermission qapi_perm); | ||
24 | |||
25 | -/* disk I/O throttling */ | ||
26 | void bdrv_init(void); | ||
27 | void bdrv_init_with_whitelist(void); | ||
28 | bool bdrv_uses_whitelist(void); | ||
29 | -- | ||
30 | 2.34.1 | ||
31 | |||
32 | diff view generated by jsdifflib |