[PATCH v6 5/5] docs: add deprecation note about 'set_password' param 'connected'

Stefan Reiter posted 5 patches 4 years, 3 months ago
There is a newer version of this series
[PATCH v6 5/5] docs: add deprecation note about 'set_password' param 'connected'
Posted by Stefan Reiter 4 years, 3 months ago
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---

Seperate patch since it read a bit unsure in the review, feel free to either
drop or squash this.

 docs/about/deprecated.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 0bed6ecb1d..1ad08e57d2 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -228,6 +228,12 @@ Use the more generic commands ``block-export-add`` and ``block-export-del``
 instead.  As part of this deprecation, where ``nbd-server-add`` used a
 single ``bitmap``, the new ``block-export-add`` uses a list of ``bitmaps``.
 
+``set_password`` argument ``connected`` for VNC protocol (since 6.2)
+''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Only the value ``keep`` is and was ever supported for VNC. It is recommended to
+just drop the argument.
+
 System accelerators
 -------------------
 
-- 
2.30.2



Re: [PATCH v6 5/5] docs: add deprecation note about 'set_password' param 'connected'
Posted by Markus Armbruster 4 years, 3 months ago
Stefan Reiter <s.reiter@proxmox.com> writes:

> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> Seperate patch since it read a bit unsure in the review, feel free to either
> drop or squash this.
>
>  docs/about/deprecated.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 0bed6ecb1d..1ad08e57d2 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -228,6 +228,12 @@ Use the more generic commands ``block-export-add`` and ``block-export-del``
>  instead.  As part of this deprecation, where ``nbd-server-add`` used a
>  single ``bitmap``, the new ``block-export-add`` uses a list of ``bitmaps``.
>  
> +``set_password`` argument ``connected`` for VNC protocol (since 6.2)
> +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> +
> +Only the value ``keep`` is and was ever supported for VNC. It is recommended to
> +just drop the argument.
> +
>  System accelerators
>  -------------------

This is okay.  Possibly clearer:

   Only the value ``keep`` is and was ever supported for VNC.  The
   (useless) argument will be dropped in a future version of QEMU.

Either phrasing is
Reviewed-by: Markus Armbruster <armbru@redhat.com>