hw/nvram: Fix Memory Leaks in Xilinx eFUSE

[PATCH 0/3] hw/nvram: Fix Memory Leaks in Xilinx eFUSE

Posted by Tong Ho 2 years, 6 months ago

This series fixes memory leaks in Xilinx eFUSE devices for
the Versal and ZynqMP product families.

The leaks result from failing to free memory allocated
by object_get_canonical_path().

Tong Ho (3):
  hw/nvram: Fix Memory Leak in Xilinx eFuse QOM
  hw/nvram: Fix Memory Leak in Xilinx Versal eFuse device
  hw/nvram: Fix Memory Leak in Xilinx ZynqMP eFuse device

 hw/nvram/xlnx-efuse.c             |  9 ++++++---
 hw/nvram/xlnx-versal-efuse-ctrl.c | 20 +++++++++++++++-----
 hw/nvram/xlnx-zynqmp-efuse.c      | 18 ++++++++++++------
 3 files changed, 33 insertions(+), 14 deletions(-)

-- 
2.25.1

Re: [PATCH 0/3] hw/nvram: Fix Memory Leaks in Xilinx eFUSE

Posted by Philippe Mathieu-Daudé 2 years, 6 months ago

Cc'ing qemu-trivial@

On 10/15/21 22:35, Tong Ho wrote:
> This series fixes memory leaks in Xilinx eFUSE devices for
> the Versal and ZynqMP product families.
> 
> The leaks result from failing to free memory allocated
> by object_get_canonical_path().
> 
> Tong Ho (3):
>   hw/nvram: Fix Memory Leak in Xilinx eFuse QOM
>   hw/nvram: Fix Memory Leak in Xilinx Versal eFuse device
>   hw/nvram: Fix Memory Leak in Xilinx ZynqMP eFuse device
> 
>  hw/nvram/xlnx-efuse.c             |  9 ++++++---
>  hw/nvram/xlnx-versal-efuse-ctrl.c | 20 +++++++++++++++-----
>  hw/nvram/xlnx-zynqmp-efuse.c      | 18 ++++++++++++------
>  3 files changed, 33 insertions(+), 14 deletions(-)
> 

Series:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Re: [PATCH 0/3] hw/nvram: Fix Memory Leaks in Xilinx eFUSE

Posted by Edgar E. Iglesias 2 years, 6 months ago

On Mon, Oct 18, 2021 at 12:31:44PM +0200, Philippe Mathieu-Daudé wrote:
> Cc'ing qemu-trivial@
> 
> On 10/15/21 22:35, Tong Ho wrote:
> > This series fixes memory leaks in Xilinx eFUSE devices for
> > the Versal and ZynqMP product families.
> > 
> > The leaks result from failing to free memory allocated
> > by object_get_canonical_path().
> > 
> > Tong Ho (3):
> >   hw/nvram: Fix Memory Leak in Xilinx eFuse QOM
> >   hw/nvram: Fix Memory Leak in Xilinx Versal eFuse device
> >   hw/nvram: Fix Memory Leak in Xilinx ZynqMP eFuse device
> > 
> >  hw/nvram/xlnx-efuse.c             |  9 ++++++---
> >  hw/nvram/xlnx-versal-efuse-ctrl.c | 20 +++++++++++++++-----
> >  hw/nvram/xlnx-zynqmp-efuse.c      | 18 ++++++++++++------
> >  3 files changed, 33 insertions(+), 14 deletions(-)
> > 
> 
> Series:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> 

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Re: [PATCH 0/3] hw/nvram: Fix Memory Leaks in Xilinx eFUSE

Posted by Laurent Vivier 2 years, 6 months ago

Le 15/10/2021 à 22:35, Tong Ho a écrit :
> This series fixes memory leaks in Xilinx eFUSE devices for
> the Versal and ZynqMP product families.
> 
> The leaks result from failing to free memory allocated
> by object_get_canonical_path().
> 
> Tong Ho (3):
>   hw/nvram: Fix Memory Leak in Xilinx eFuse QOM
>   hw/nvram: Fix Memory Leak in Xilinx Versal eFuse device
>   hw/nvram: Fix Memory Leak in Xilinx ZynqMP eFuse device
> 
>  hw/nvram/xlnx-efuse.c             |  9 ++++++---
>  hw/nvram/xlnx-versal-efuse-ctrl.c | 20 +++++++++++++++-----
>  hw/nvram/xlnx-zynqmp-efuse.c      | 18 ++++++++++++------
>  3 files changed, 33 insertions(+), 14 deletions(-)
> 

Applied to my trivial-patches branch.

Thanks,
Laurent