target/s390x/cpu.h: Remove unused SIGP_MODE defines

[PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines

Thomas Huth posted 1 patch 2 years, 6 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211015124219.1330830-1-thuth@redhat.com

Maintainers: Cornelia Huck <cohuck@redhat.com>, Thomas Huth <thuth@redhat.com>, David Hildenbrand <david@redhat.com>, Richard Henderson <richard.henderson@linaro.org>

target/s390x/cpu.h | 5 -----
1 file changed, 5 deletions(-)

Expand all Fold all

[PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines

Posted by Thomas Huth 2 years, 6 months ago

These are unused since commit 075e52b816648f21 ("s390x/cpumodel:
we are always in zarchitecture mode") and it's unlikely that we
will ever need them again. So let's simply remove them now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 target/s390x/cpu.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 3153d053e9..ca3845d023 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -674,11 +674,6 @@ QEMU_BUILD_BUG_ON(sizeof(SysIB) != 4096);
 #define SIGP_STAT_INVALID_ORDER     0x00000002UL
 #define SIGP_STAT_RECEIVER_CHECK    0x00000001UL
 
-/* SIGP SET ARCHITECTURE modes */
-#define SIGP_MODE_ESA_S390 0
-#define SIGP_MODE_Z_ARCH_TRANS_ALL_PSW 1
-#define SIGP_MODE_Z_ARCH_TRANS_CUR_PSW 2
-
 /* SIGP order code mask corresponding to bit positions 56-63 */
 #define SIGP_ORDER_MASK 0x000000ff
 
-- 
2.27.0

Re: [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines

Posted by David Hildenbrand 2 years, 6 months ago

On 15.10.21 14:42, Thomas Huth wrote:
> These are unused since commit 075e52b816648f21 ("s390x/cpumodel:
> we are always in zarchitecture mode") and it's unlikely that we
> will ever need them again. So let's simply remove them now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  target/s390x/cpu.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
> index 3153d053e9..ca3845d023 100644
> --- a/target/s390x/cpu.h
> +++ b/target/s390x/cpu.h
> @@ -674,11 +674,6 @@ QEMU_BUILD_BUG_ON(sizeof(SysIB) != 4096);
>  #define SIGP_STAT_INVALID_ORDER     0x00000002UL
>  #define SIGP_STAT_RECEIVER_CHECK    0x00000001UL
>  
> -/* SIGP SET ARCHITECTURE modes */
> -#define SIGP_MODE_ESA_S390 0
> -#define SIGP_MODE_Z_ARCH_TRANS_ALL_PSW 1
> -#define SIGP_MODE_Z_ARCH_TRANS_CUR_PSW 2
> -
>  /* SIGP order code mask corresponding to bit positions 56-63 */
>  #define SIGP_ORDER_MASK 0x000000ff
>  
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb

Re: [PATCH] target/s390x/cpu.h: Remove unused SIGP_MODE defines

Posted by Philippe Mathieu-Daudé 2 years, 6 months ago

On 10/15/21 14:42, Thomas Huth wrote:
> These are unused since commit 075e52b816648f21 ("s390x/cpumodel:
> we are always in zarchitecture mode") and it's unlikely that we
> will ever need them again. So let's simply remove them now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  target/s390x/cpu.h | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>