[v5] user-only: Cleanup SIGSEGV and SIGBUS handling

[PATCH v5 16/67] target/arm: Fixup comment re handle_cpu_signal

Richard Henderson posted 67 patches 4 years, 3 months ago

Diff against v6 v7
Download mbox

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Taylor Simpson <tsimpson@quicinc.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, David Hildenbrand <david@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Greg Kurz <groug@kaod.org>, Cornelia Huck <cohuck@redhat.com>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Richard Henderson <richard.henderson@linaro.org>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Thomas Huth <thuth@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Artyom Tarasenko <atar4qemu@gmail.com>, Laurent Vivier <laurent@vivier.eu>, Aurelien Jarno <aurelien@aurel32.net>, Eduardo Habkost <ehabkost@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Riku Voipio <riku.voipio@iki.fi>, Peter Maydell <peter.maydell@linaro.org>, Yoshinori Sato <ysato@users.sourceforge.jp>, Jiaxun Yang <jiaxun.yang@flygoat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>

There is a newer version of this series

Expand all Fold all

[PATCH v5 16/67] target/arm: Fixup comment re handle_cpu_signal

Posted by Richard Henderson 4 years, 3 months ago

The named function no longer exists.
Refer to host_signal_handler instead.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/sve_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
index dab5f1d1cd..07be55b7e1 100644
--- a/target/arm/sve_helper.c
+++ b/target/arm/sve_helper.c
@@ -6118,7 +6118,7 @@ DO_LDN_2(4, dd, MO_64)
  * linux-user/ in its get_user/put_user macros.
  *
  * TODO: Construct some helpers, written in assembly, that interact with
- * handle_cpu_signal to produce memory ops which can properly report errors
+ * host_signal_handler to produce memory ops which can properly report errors
  * without racing.
  */
 
-- 
2.25.1

Re: [PATCH v5 16/67] target/arm: Fixup comment re handle_cpu_signal

Posted by Warner Losh 4 years, 3 months ago

On Thu, Oct 14, 2021 at 10:11 PM Richard Henderson <
richard.henderson@linaro.org> wrote:

> The named function no longer exists.
> Refer to host_signal_handler instead.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/sve_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Warner Losh <imp@bsdimp.com>


> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
> index dab5f1d1cd..07be55b7e1 100644
> --- a/target/arm/sve_helper.c
> +++ b/target/arm/sve_helper.c
> @@ -6118,7 +6118,7 @@ DO_LDN_2(4, dd, MO_64)
>   * linux-user/ in its get_user/put_user macros.
>   *
>   * TODO: Construct some helpers, written in assembly, that interact with
> - * handle_cpu_signal to produce memory ops which can properly report
> errors
> + * host_signal_handler to produce memory ops which can properly report
> errors
>   * without racing.
>   */
>
> --
> 2.25.1
>
>

Re: [PATCH v5 16/67] target/arm: Fixup comment re handle_cpu_signal

Posted by Philippe Mathieu-Daudé 4 years, 3 months ago

On 10/15/21 06:10, Richard Henderson wrote:
> The named function no longer exists.

It seems to be declared inlined since QEMU v0.1.0 in 2003!

So it was likely a typo.

Anyhow,
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> Refer to host_signal_handler instead.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/arm/sve_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c
> index dab5f1d1cd..07be55b7e1 100644
> --- a/target/arm/sve_helper.c
> +++ b/target/arm/sve_helper.c
> @@ -6118,7 +6118,7 @@ DO_LDN_2(4, dd, MO_64)
>   * linux-user/ in its get_user/put_user macros.
>   *
>   * TODO: Construct some helpers, written in assembly, that interact with
> - * handle_cpu_signal to produce memory ops which can properly report errors
> + * host_signal_handler to produce memory ops which can properly report errors
>   * without racing.
>   */
>  
>