target/mips: Remove unused TCG temporary in gen_mipsdsp_accinsn()

[PATCH] target/mips: Remove unused TCG temporary in gen_mipsdsp_accinsn()

Philippe Mathieu-Daudé posted 1 patch 4 years, 3 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211014224551.2204949-1-f4bug@amsat.org

Maintainers: Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>

target/mips/tcg/translate.c | 4 ----
1 file changed, 4 deletions(-)

Expand all Fold all

[PATCH] target/mips: Remove unused TCG temporary in gen_mipsdsp_accinsn()

Posted by Philippe Mathieu-Daudé 4 years, 3 months ago

Since gen_mipsdsp_accinsn() got added in commit b53371ed5d4
("target-mips: Add ASE DSP accumulator instructions"), the
'v2_t' TCG temporary has never been used. Remove it.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/mips/tcg/translate.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c
index 794676d42ff..cafc21088a5 100644
--- a/target/mips/tcg/translate.c
+++ b/target/mips/tcg/translate.c
@@ -13627,7 +13627,6 @@ static void gen_mipsdsp_accinsn(DisasContext *ctx, uint32_t op1, uint32_t op2,
     TCGv t0;
     TCGv t1;
     TCGv v1_t;
-    TCGv v2_t;
     int16_t imm;
 
     if ((ret == 0) && (check_ret == 1)) {
@@ -13638,10 +13637,8 @@ static void gen_mipsdsp_accinsn(DisasContext *ctx, uint32_t op1, uint32_t op2,
     t0 = tcg_temp_new();
     t1 = tcg_temp_new();
     v1_t = tcg_temp_new();
-    v2_t = tcg_temp_new();
 
     gen_load_gpr(v1_t, v1);
-    gen_load_gpr(v2_t, v2);
 
     switch (op1) {
     case OPC_EXTR_W_DSP:
@@ -13841,7 +13838,6 @@ static void gen_mipsdsp_accinsn(DisasContext *ctx, uint32_t op1, uint32_t op2,
     tcg_temp_free(t0);
     tcg_temp_free(t1);
     tcg_temp_free(v1_t);
-    tcg_temp_free(v2_t);
 }
 
 /* End MIPSDSP functions. */
-- 
2.31.1

Re: [PATCH] target/mips: Remove unused TCG temporary in gen_mipsdsp_accinsn()

Posted by Richard Henderson 4 years, 3 months ago

On 10/14/21 3:45 PM, Philippe Mathieu-Daudé wrote:
> Since gen_mipsdsp_accinsn() got added in commit b53371ed5d4
> ("target-mips: Add ASE DSP accumulator instructions"), the
> 'v2_t' TCG temporary has never been used. Remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   target/mips/tcg/translate.c | 4 ----
>   1 file changed, 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~