tests/vm/openbsd: Move timezone set to after disk setup

[PATCH] tests/vm/openbsd: Move timezone set to after disk setup

Richard Henderson posted 1 patch 4 years, 3 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211013163129.983810-1-richard.henderson@linaro.org

Maintainers: Thomas Huth <thuth@redhat.com>, Willian Rampazzo <willianr@redhat.com>, Brad Smith <brad@comstyle.com>, "Alex Bennée" <alex.bennee@linaro.org>, Wainer dos Santos Moschetta <wainersm@redhat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>

tests/vm/openbsd | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] tests/vm/openbsd: Move timezone set to after disk setup

Posted by Richard Henderson 4 years, 3 months ago

Currently the install gets stuck waiting for the timezone
when the installer is waiting on the disk.  Swap the two.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tests/vm/openbsd | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/vm/openbsd b/tests/vm/openbsd
index c4c78a80f1..cbb4006ef7 100755
--- a/tests/vm/openbsd
+++ b/tests/vm/openbsd
@@ -119,7 +119,6 @@ class OpenBSDVM(basevm.BaseVM):
         self.console_send("%s\n" % self._config["guest_pass"])
 
         self.console_wait_send("Allow root ssh login",    "yes\n")
-        self.console_wait_send("timezone",                "UTC\n")
         self.console_wait_send("root disk",               "\n")
         self.console_wait_send("(W)hole disk",            "\n")
         self.console_wait_send("(A)uto layout",           "\n")
@@ -130,6 +129,7 @@ class OpenBSDVM(basevm.BaseVM):
 
         self.print_step("Installation started now, this will take a while")
         self.console_wait_send("Location of sets",        "done\n")
+        self.console_wait_send("timezone",                "UTC\n")
 
         self.console_wait("successfully completed")
         self.print_step("Installation finished, rebooting")
-- 
2.17.1

Re: [PATCH] tests/vm/openbsd: Move timezone set to after disk setup

Posted by Brad Smith 4 years, 3 months ago

Yes, this is the correct order. The timezone question comes after the 
install sets are extracted.

Signed-off-by: Brad Smith <brad@comstyle.com>

On 10/13/2021 12:31 PM, Richard Henderson wrote:
> Currently the install gets stuck waiting for the timezone
> when the installer is waiting on the disk.  Swap the two.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tests/vm/openbsd | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/vm/openbsd b/tests/vm/openbsd
> index c4c78a80f1..cbb4006ef7 100755
> --- a/tests/vm/openbsd
> +++ b/tests/vm/openbsd
> @@ -119,7 +119,6 @@ class OpenBSDVM(basevm.BaseVM):
>           self.console_send("%s\n" % self._config["guest_pass"])
>   
>           self.console_wait_send("Allow root ssh login",    "yes\n")
> -        self.console_wait_send("timezone",                "UTC\n")
>           self.console_wait_send("root disk",               "\n")
>           self.console_wait_send("(W)hole disk",            "\n")
>           self.console_wait_send("(A)uto layout",           "\n")
> @@ -130,6 +129,7 @@ class OpenBSDVM(basevm.BaseVM):
>   
>           self.print_step("Installation started now, this will take a while")
>           self.console_wait_send("Location of sets",        "done\n")
> +        self.console_wait_send("timezone",                "UTC\n")
>   
>           self.console_wait("successfully completed")
>           self.print_step("Installation finished, rebooting")