[v2] meson.build: don't include libbpf in the common source set

[PATCH v2] meson.build: don't include libbpf in the common source set

Alex Bennée posted 1 patch 2 years, 6 months ago

Diff against v1
Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211012162552.16865-1-alex.bennee@linaro.org

meson.build | 2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[PATCH v2] meson.build: don't include libbpf in the common source set

Posted by Alex Bennée 2 years, 6 months ago

This library is only needed for the softmmu targets and as such
break static *-user builds where libbpf is detected and it tries to
link it into the user binaries. In fact ebpf/meson.build already
brings libbpf into the softmmu build so we can delete the common_ss
line altogether.

Fixes: 46627f41b6 ("ebpf: Added eBPF RSS loader.")
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211005182443.2954499-1-alex.bennee@linaro.org>

--
v2
  - delete common_ss altogether instead of replacing with softmmu_ss
---
 meson.build | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meson.build b/meson.build
index 99a0a3e689..42b7ba360d 100644
--- a/meson.build
+++ b/meson.build
@@ -2301,8 +2301,6 @@ subdir('bsd-user')
 subdir('linux-user')
 subdir('ebpf')
 
-common_ss.add(libbpf)
-
 bsd_user_ss.add(files('gdbstub.c'))
 specific_ss.add_all(when: 'CONFIG_BSD_USER', if_true: bsd_user_ss)
 
-- 
2.30.2