[v2] configure->meson queue for 6.2

[PATCH v2 21/24] configure: remove deprecated --{enable, disable}-git-update

Posted by Paolo Bonzini 4 years, 4 months ago

The options were deprecated in 6.0.  That said, we do not really have a
formal deprecation cycle for build-time changes, since they do not affect
users.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20211007130829.632254-16-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/configure b/configure
index 33d330dcc9..d00ba0cbd2 100755
--- a/configure
+++ b/configure
@@ -1483,14 +1483,6 @@ for opt do
   ;;
   --with-git=*) git="$optarg"
   ;;
-  --enable-git-update)
-      git_submodules_action="update"
-      echo "--enable-git-update deprecated, use --with-git-submodules=update"
-  ;;
-  --disable-git-update)
-      git_submodules_action="validate"
-      echo "--disable-git-update deprecated, use --with-git-submodules=validate"
-  ;;
   --with-git-submodules=*)
       git_submodules_action="$optarg"
   ;;
-- 
2.31.1

Re: [PATCH v2 21/24] configure: remove deprecated --{enable, disable}-git-update

Posted by Thomas Huth 4 years, 4 months ago

On 12/10/2021 13.12, Paolo Bonzini wrote:
> The options were deprecated in 6.0.  That said, we do not really have a
> formal deprecation cycle for build-time changes, since they do not affect
> users.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Message-Id: <20211007130829.632254-16-pbonzini@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   configure | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/configure b/configure
> index 33d330dcc9..d00ba0cbd2 100755
> --- a/configure
> +++ b/configure
> @@ -1483,14 +1483,6 @@ for opt do
>     ;;
>     --with-git=*) git="$optarg"
>     ;;
> -  --enable-git-update)
> -      git_submodules_action="update"
> -      echo "--enable-git-update deprecated, use --with-git-submodules=update"
> -  ;;
> -  --disable-git-update)
> -      git_submodules_action="validate"
> -      echo "--disable-git-update deprecated, use --with-git-submodules=validate"
> -  ;;
>     --with-git-submodules=*)
>         git_submodules_action="$optarg"
>     ;;
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>