Improvements to SIGP handling [QEMU]

[RFC PATCH v1 0/2] Improvements to SIGP handling [QEMU]

Eric Farman posted 2 patches 2 years, 6 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211008203811.1980478-1-farman@linux.ibm.com

Maintainers: Cornelia Huck <cohuck@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Thomas Huth <thuth@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, David Hildenbrand <david@redhat.com>

target/s390x/kvm/kvm.c |  4 ++++
target/s390x/sigp.c    | 18 +-----------------
2 files changed, 5 insertions(+), 17 deletions(-)

Expand all Fold all

[RFC PATCH v1 0/2] Improvements to SIGP handling [QEMU]

Posted by Eric Farman 2 years, 6 months ago

I'm cleaning up some of the SIGP code in KVM and QEMU,
and would like to propose the following changes.

Patch 1 should be less concerning than its KVM counterpart,
since the CZAM bit in question is already present in QEMU.

Patch 2 provides some handshaking with KVM. Since QEMU
injects a Stop IRQ for a couple of the SIGP orders, we
can provide the flags associated with it, to provide some
direction for how KVM should process it.

While this has no dependency on the KVM code, the KVM series
that I'm working on in parallel is here:

https://lore.kernel.org/r/20211008203112.1979843-1-farman@linux.ibm.com/

Eric Farman (2):
  s390x: sigp: Force Set Architecture to return Invalid Parameter
  s390x/kvm: Pass SIGP Stop flags

 target/s390x/kvm/kvm.c |  4 ++++
 target/s390x/sigp.c    | 18 +-----------------
 2 files changed, 5 insertions(+), 17 deletions(-)

-- 
2.25.1

Re: [RFC PATCH v1 0/2] Improvements to SIGP handling [QEMU]

Posted by Thomas Huth 2 years, 6 months ago

On 08/10/2021 22.38, Eric Farman wrote:
> I'm cleaning up some of the SIGP code in KVM and QEMU,
> and would like to propose the following changes.
> 
> Patch 1 should be less concerning than its KVM counterpart,
> since the CZAM bit in question is already present in QEMU.
> 
> Patch 2 provides some handshaking with KVM. Since QEMU
> injects a Stop IRQ for a couple of the SIGP orders, we
> can provide the flags associated with it, to provide some
> direction for how KVM should process it.
> 
> While this has no dependency on the KVM code, the KVM series
> that I'm working on in parallel is here:
> 
> https://lore.kernel.org/r/20211008203112.1979843-1-farman@linux.ibm.com/
> 
> Eric Farman (2):
>    s390x: sigp: Force Set Architecture to return Invalid Parameter
>    s390x/kvm: Pass SIGP Stop flags
> 
>   target/s390x/kvm/kvm.c |  4 ++++
>   target/s390x/sigp.c    | 18 +-----------------
>   2 files changed, 5 insertions(+), 17 deletions(-)
> 

FYI, I've queued the first patch to my s390x-next branch:

https://gitlab.com/thuth/qemu/-/commits/s390x-next

... for the second patch, I'll wait for the discussion to settle.

  Thomas