[PATCH 22/24] configure: accept "internal" for --enable-capstone/slirp/fdt

Paolo Bonzini posted 24 patches 4 years, 4 months ago
Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Jason Wang <jasowang@redhat.com>, Alexander Bulekov <alxndr@bu.edu>, Bandan Das <bsd@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Cleber Rosa <crosa@redhat.com>, Thomas Huth <thuth@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Darren Kenny <darren.kenny@oracle.com>, Kevin Wolf <kwolf@redhat.com>, Qiuhao Li <Qiuhao.Li@outlook.com>
There is a newer version of this series
[PATCH 22/24] configure: accept "internal" for --enable-capstone/slirp/fdt
Posted by Paolo Bonzini 4 years, 4 months ago
Options such as "--enable-capstone=git" do not make much sense when building
from a tarball.  Accept "internal" for consistency with the meson options.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/configure b/configure
index d00ba0cbd2..d2f754d5d1 100755
--- a/configure
+++ b/configure
@@ -1019,7 +1019,7 @@ for opt do
   ;;
   --enable-slirp=git) slirp="internal"
   ;;
-  --enable-slirp=system) slirp="system"
+  --enable-slirp=*) slirp="$optarg"
   ;;
   --disable-vde) vde="disabled"
   ;;
@@ -1193,7 +1193,7 @@ for opt do
   ;;
   --enable-fdt=git) fdt="internal"
   ;;
-  --enable-fdt=system) fdt="system"
+  --enable-fdt=*) fdt="$optarg"
   ;;
   --disable-linux-aio) linux_aio="disabled"
   ;;
@@ -1479,7 +1479,7 @@ for opt do
   ;;
   --enable-capstone=git) capstone="internal"
   ;;
-  --enable-capstone=system) capstone="system"
+  --enable-capstone=*) capstone="$optarg"
   ;;
   --with-git=*) git="$optarg"
   ;;
-- 
2.31.1



Re: [PATCH 22/24] configure: accept "internal" for --enable-capstone/slirp/fdt
Posted by Marc-André Lureau 4 years, 4 months ago
On Thu, Oct 7, 2021 at 5:25 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

> Options such as "--enable-capstone=git" do not make much sense when
> building
> from a tarball.  Accept "internal" for consistency with the meson options.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  configure | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index d00ba0cbd2..d2f754d5d1 100755
> --- a/configure
> +++ b/configure
> @@ -1019,7 +1019,7 @@ for opt do
>    ;;
>    --enable-slirp=git) slirp="internal"
>    ;;
> -  --enable-slirp=system) slirp="system"
> +  --enable-slirp=*) slirp="$optarg"
>    ;;
>    --disable-vde) vde="disabled"
>    ;;
> @@ -1193,7 +1193,7 @@ for opt do
>    ;;
>    --enable-fdt=git) fdt="internal"
>    ;;
> -  --enable-fdt=system) fdt="system"
> +  --enable-fdt=*) fdt="$optarg"
>    ;;
>    --disable-linux-aio) linux_aio="disabled"
>    ;;
> @@ -1479,7 +1479,7 @@ for opt do
>    ;;
>    --enable-capstone=git) capstone="internal"
>    ;;
> -  --enable-capstone=system) capstone="system"
> +  --enable-capstone=*) capstone="$optarg"
>    ;;
>    --with-git=*) git="$optarg"
>    ;;
> --
> 2.31.1
>
>
>
>

-- 
Marc-André Lureau