[PATCH 19/24] configure: remove obsolete Solaris ar check

Paolo Bonzini posted 24 patches 4 years, 4 months ago
Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Jason Wang <jasowang@redhat.com>, Alexander Bulekov <alxndr@bu.edu>, Bandan Das <bsd@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Ani Sinha <ani@anisinha.ca>, Cleber Rosa <crosa@redhat.com>, Thomas Huth <thuth@redhat.com>, Hanna Reitz <hreitz@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Darren Kenny <darren.kenny@oracle.com>, Kevin Wolf <kwolf@redhat.com>, Qiuhao Li <Qiuhao.Li@outlook.com>
There is a newer version of this series
[PATCH 19/24] configure: remove obsolete Solaris ar check
Posted by Paolo Bonzini 4 years, 4 months ago
Meson already has its own logic to find the "ar" binary, so remove the
Solaris specific check.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/configure b/configure
index 016814d23b..2091844ad6 100755
--- a/configure
+++ b/configure
@@ -2284,21 +2284,6 @@ EOF
   fi
 fi
 
-#########################################
-# Solaris specific configure tool chain decisions
-
-if test "$solaris" = "yes" ; then
-  if has ar; then
-    :
-  else
-    if test -f /usr/ccs/bin/ar ; then
-      error_exit "No path includes ar" \
-          "Add /usr/ccs/bin to your path and rerun configure"
-    fi
-    error_exit "No path includes ar"
-  fi
-fi
-
 if test "$tcg" = "enabled"; then
     git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
     git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
-- 
2.31.1



Re: [PATCH 19/24] configure: remove obsolete Solaris ar check
Posted by Thomas Huth 4 years, 4 months ago
On 07/10/2021 15.08, Paolo Bonzini wrote:
> Meson already has its own logic to find the "ar" binary, so remove the
> Solaris specific check.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   configure | 15 ---------------
>   1 file changed, 15 deletions(-)
> 
> diff --git a/configure b/configure
> index 016814d23b..2091844ad6 100755
> --- a/configure
> +++ b/configure
> @@ -2284,21 +2284,6 @@ EOF
>     fi
>   fi
>   
> -#########################################
> -# Solaris specific configure tool chain decisions
> -
> -if test "$solaris" = "yes" ; then
> -  if has ar; then
> -    :
> -  else
> -    if test -f /usr/ccs/bin/ar ; then
> -      error_exit "No path includes ar" \
> -          "Add /usr/ccs/bin to your path and rerun configure"
> -    fi
> -    error_exit "No path includes ar"
> -  fi
> -fi

Reviewed-by: Thomas Huth <thuth@redhat.com>


Re: [PATCH 19/24] configure: remove obsolete Solaris ar check
Posted by Marc-André Lureau 4 years, 4 months ago
On Thu, Oct 7, 2021 at 5:17 PM Paolo Bonzini <pbonzini@redhat.com> wrote:

> Meson already has its own logic to find the "ar" binary, so remove the
> Solaris specific check.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>


> ---
>  configure | 15 ---------------
>  1 file changed, 15 deletions(-)
>
> diff --git a/configure b/configure
> index 016814d23b..2091844ad6 100755
> --- a/configure
> +++ b/configure
> @@ -2284,21 +2284,6 @@ EOF
>    fi
>  fi
>
> -#########################################
> -# Solaris specific configure tool chain decisions
> -
> -if test "$solaris" = "yes" ; then
> -  if has ar; then
> -    :
> -  else
> -    if test -f /usr/ccs/bin/ar ; then
> -      error_exit "No path includes ar" \
> -          "Add /usr/ccs/bin to your path and rerun configure"
> -    fi
> -    error_exit "No path includes ar"
> -  fi
> -fi
> -
>  if test "$tcg" = "enabled"; then
>      git_submodules="$git_submodules tests/fp/berkeley-testfloat-3"
>      git_submodules="$git_submodules tests/fp/berkeley-softfloat-3"
> --
> 2.31.1
>
>
>
>

-- 
Marc-André Lureau