[PATCH] hw/ppc/spapr_softmmu: Reduce include list

Philippe Mathieu-Daudé posted 1 patch 2 years, 6 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20211006170801.178023-1-philmd@redhat.com
hw/ppc/spapr_softmmu.c | 15 ---------------
1 file changed, 15 deletions(-)
[PATCH] hw/ppc/spapr_softmmu: Reduce include list
Posted by Philippe Mathieu-Daudé 2 years, 6 months ago
Commit 962104f0448 ("hw/ppc: moved hcalls that depend on softmmu")
introduced a lot of unnecessary #include directives. Remove them.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/ppc/spapr_softmmu.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/hw/ppc/spapr_softmmu.c b/hw/ppc/spapr_softmmu.c
index 6c6b86dd3c6..f8924270eff 100644
--- a/hw/ppc/spapr_softmmu.c
+++ b/hw/ppc/spapr_softmmu.c
@@ -1,25 +1,10 @@
 #include "qemu/osdep.h"
 #include "qemu/cutils.h"
-#include "qapi/error.h"
-#include "sysemu/hw_accel.h"
-#include "sysemu/runstate.h"
-#include "qemu/log.h"
-#include "qemu/main-loop.h"
-#include "qemu/module.h"
-#include "qemu/error-report.h"
 #include "cpu.h"
-#include "exec/exec-all.h"
 #include "helper_regs.h"
 #include "hw/ppc/spapr.h"
-#include "hw/ppc/spapr_cpu_core.h"
 #include "mmu-hash64.h"
-#include "cpu-models.h"
-#include "trace.h"
-#include "kvm_ppc.h"
-#include "hw/ppc/fdt.h"
-#include "hw/ppc/spapr_ovec.h"
 #include "mmu-book3s-v3.h"
-#include "hw/mem/memory-device.h"
 
 static inline bool valid_ptex(PowerPCCPU *cpu, target_ulong ptex)
 {
-- 
2.31.1

Re: [PATCH] hw/ppc/spapr_softmmu: Reduce include list
Posted by David Gibson 2 years, 6 months ago
On Wed, Oct 06, 2021 at 07:08:01PM +0200, Philippe Mathieu-Daudé wrote:
> Commit 962104f0448 ("hw/ppc: moved hcalls that depend on softmmu")
> introduced a lot of unnecessary #include directives. Remove them.

Applied to ppc-for-6.2, thanks.

> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/ppc/spapr_softmmu.c | 15 ---------------
>  1 file changed, 15 deletions(-)
> 
> diff --git a/hw/ppc/spapr_softmmu.c b/hw/ppc/spapr_softmmu.c
> index 6c6b86dd3c6..f8924270eff 100644
> --- a/hw/ppc/spapr_softmmu.c
> +++ b/hw/ppc/spapr_softmmu.c
> @@ -1,25 +1,10 @@
>  #include "qemu/osdep.h"
>  #include "qemu/cutils.h"
> -#include "qapi/error.h"
> -#include "sysemu/hw_accel.h"
> -#include "sysemu/runstate.h"
> -#include "qemu/log.h"
> -#include "qemu/main-loop.h"
> -#include "qemu/module.h"
> -#include "qemu/error-report.h"
>  #include "cpu.h"
> -#include "exec/exec-all.h"
>  #include "helper_regs.h"
>  #include "hw/ppc/spapr.h"
> -#include "hw/ppc/spapr_cpu_core.h"
>  #include "mmu-hash64.h"
> -#include "cpu-models.h"
> -#include "trace.h"
> -#include "kvm_ppc.h"
> -#include "hw/ppc/fdt.h"
> -#include "hw/ppc/spapr_ovec.h"
>  #include "mmu-book3s-v3.h"
> -#include "hw/mem/memory-device.h"
>  
>  static inline bool valid_ptex(PowerPCCPU *cpu, target_ulong ptex)
>  {

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson