qemu-iotests: flush after every test

[PATCH] qemu-iotests: flush after every test

Posted by Paolo Bonzini 2 years, 6 months ago

This makes it possible to see what is happening, even if the output of
"make check-block" is not sent to a tty (for example if it is sent to
grep or tee).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/qemu-iotests/testrunner.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
index 4a6ec421ed..b76db57e4c 100644
--- a/tests/qemu-iotests/testrunner.py
+++ b/tests/qemu-iotests/testrunner.py
@@ -340,6 +340,7 @@ def run_tests(self, tests: List[str]) -> bool:
             elif res.status == 'not run':
                 notrun.append(name)
 
+            sys.stdout.flush()
             if res.interrupted:
                 break
 
-- 
2.31.1

Re: [PATCH] qemu-iotests: flush after every test

Posted by Richard Henderson 2 years, 6 months ago

On 10/6/21 2:27 AM, Paolo Bonzini wrote:
> This makes it possible to see what is happening, even if the output of
> "make check-block" is not sent to a tty (for example if it is sent to
> grep or tee).
> 
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   tests/qemu-iotests/testrunner.py | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH] qemu-iotests: flush after every test

Posted by Philippe Mathieu-Daudé 2 years, 6 months ago

On 10/6/21 11:27, Paolo Bonzini wrote:
> This makes it possible to see what is happening, even if the output of
> "make check-block" is not sent to a tty (for example if it is sent to
> grep or tee).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/qemu-iotests/testrunner.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
> index 4a6ec421ed..b76db57e4c 100644
> --- a/tests/qemu-iotests/testrunner.py
> +++ b/tests/qemu-iotests/testrunner.py
> @@ -340,6 +340,7 @@ def run_tests(self, tests: List[str]) -> bool:
>              elif res.status == 'not run':
>                  notrun.append(name)
>  
> +            sys.stdout.flush()

Shouldn't we flush stderr too?

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] qemu-iotests: flush after every test

Posted by Paolo Bonzini 2 years, 6 months ago

On 06/10/21 17:42, Philippe Mathieu-Daudé wrote:
> On 10/6/21 11:27, Paolo Bonzini wrote:
>> This makes it possible to see what is happening, even if the output of
>> "make check-block" is not sent to a tty (for example if it is sent to
>> grep or tee).
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>   tests/qemu-iotests/testrunner.py | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
>> index 4a6ec421ed..b76db57e4c 100644
>> --- a/tests/qemu-iotests/testrunner.py
>> +++ b/tests/qemu-iotests/testrunner.py
>> @@ -340,6 +340,7 @@ def run_tests(self, tests: List[str]) -> bool:
>>               elif res.status == 'not run':
>>                   notrun.append(name)
>>   
>> +            sys.stdout.flush()
> 
> Shouldn't we flush stderr too?

It's never used by the program.

Paolo

> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] qemu-iotests: flush after every test

Posted by Hanna Reitz 2 years, 6 months ago

On 06.10.21 11:27, Paolo Bonzini wrote:
> This makes it possible to see what is happening, even if the output of
> "make check-block" is not sent to a tty (for example if it is sent to
> grep or tee).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   tests/qemu-iotests/testrunner.py | 1 +
>   1 file changed, 1 insertion(+)

Thanks, applied to my block branch:

https://gitlab.com/hreitz/qemu/-/commits/block/

Hanna