failover: don't allow to migrate a paused VM that needs PCI unplug

[PATCH 0/2] failover: don't allow to migrate a paused VM that needs PCI unplug

Laurent Vivier posted 2 patches 4 years, 4 months ago

Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210929144311.1168561-1-lvivier@redhat.com

Maintainers: Jason Wang <jasowang@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela <quintela@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>

migration/migration.h |  2 +-
hw/net/virtio-net.c   | 10 +++++++++-
migration/migration.c |  9 ++++++---
migration/ram.c       |  3 +--
4 files changed, 17 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCH 0/2] failover: don't allow to migrate a paused VM that needs PCI unplug

Posted by Laurent Vivier 4 years, 4 months ago

As the guest OS is paused, we will never receive the unplug event
from the kernel and the migration cannot continue.

The first patch is optional, it provides the error message to display
to migration_cancel() rather than to have to call migrate_set_error()
from the caller.

Laurent Vivier (2):
  migration: provide an error message to migration_cancel()
  failover: don't allow to migrate a paused VM that needs PCI unplug

 migration/migration.h |  2 +-
 hw/net/virtio-net.c   | 10 +++++++++-
 migration/migration.c |  9 ++++++---
 migration/ram.c       |  3 +--
 4 files changed, 17 insertions(+), 7 deletions(-)

-- 
2.31.1

Re: [PATCH 0/2] failover: don't allow to migrate a paused VM that needs PCI unplug

Posted by Laurent Vivier 4 years, 4 months ago

On 29/09/2021 16:43, Laurent Vivier wrote:
> As the guest OS is paused, we will never receive the unplug event
> from the kernel and the migration cannot continue.
> 
> The first patch is optional, it provides the error message to display
> to migration_cancel() rather than to have to call migrate_set_error()
> from the caller.
> 
> Laurent Vivier (2):
>    migration: provide an error message to migration_cancel()
>    failover: don't allow to migrate a paused VM that needs PCI unplug
> 
>   migration/migration.h |  2 +-
>   hw/net/virtio-net.c   | 10 +++++++++-
>   migration/migration.c |  9 ++++++---
>   migration/ram.c       |  3 +--
>   4 files changed, 17 insertions(+), 7 deletions(-)
> 

Any comment?

Thanks,
Laurent

Re: [PATCH 0/2] failover: don't allow to migrate a paused VM that needs PCI unplug

Posted by Laurent Vivier 4 years, 3 months ago

On 29/09/2021 16:43, Laurent Vivier wrote:
> As the guest OS is paused, we will never receive the unplug event
> from the kernel and the migration cannot continue.
> 
> The first patch is optional, it provides the error message to display
> to migration_cancel() rather than to have to call migrate_set_error()
> from the caller.
> 
> Laurent Vivier (2):
>    migration: provide an error message to migration_cancel()
>    failover: don't allow to migrate a paused VM that needs PCI unplug
> 
>   migration/migration.h |  2 +-
>   hw/net/virtio-net.c   | 10 +++++++++-
>   migration/migration.c |  9 ++++++---
>   migration/ram.c       |  3 +--
>   4 files changed, 17 insertions(+), 7 deletions(-)
> 

ping...