hw/remote/proxy: Categorize Wireless devices as 'Network' ones

[PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones

Posted by Philippe Mathieu-Daudé 2 years, 7 months ago

QEMU doesn't distinct network devices per link layer (Ethernet,
Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network
devices.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/remote/proxy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c
index 499f540c947..bad164299dd 100644
--- a/hw/remote/proxy.c
+++ b/hw/remote/proxy.c
@@ -324,6 +324,7 @@ static void probe_pci_info(PCIDevice *dev, Error **errp)
         set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
         break;
     case PCI_BASE_CLASS_NETWORK:
+    case PCI_BASE_CLASS_WIRELESS:
         set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
         break;
     case PCI_BASE_CLASS_INPUT:
-- 
2.31.1

Re: [PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones

Posted by Jag Raman 2 years, 7 months ago


> On Sep 26, 2021, at 4:19 PM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> 
> QEMU doesn't distinct network devices per link layer (Ethernet,
> Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network
> devices.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>

> ---
> hw/remote/proxy.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c
> index 499f540c947..bad164299dd 100644
> --- a/hw/remote/proxy.c
> +++ b/hw/remote/proxy.c
> @@ -324,6 +324,7 @@ static void probe_pci_info(PCIDevice *dev, Error **errp)
>         set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>         break;
>     case PCI_BASE_CLASS_NETWORK:
> +    case PCI_BASE_CLASS_WIRELESS:
>         set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
>         break;
>     case PCI_BASE_CLASS_INPUT:
> -- 
> 2.31.1
>

Re: [PATCH] hw/remote/proxy: Categorize Wireless devices as 'Network' ones

Posted by Laurent Vivier 2 years, 7 months ago

Le 26/09/2021 à 22:19, Philippe Mathieu-Daudé a écrit :
> QEMU doesn't distinct network devices per link layer (Ethernet,
> Wi-Fi, CAN, ...). Categorize PCI Wireless cards as Network
> devices.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/remote/proxy.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/remote/proxy.c b/hw/remote/proxy.c
> index 499f540c947..bad164299dd 100644
> --- a/hw/remote/proxy.c
> +++ b/hw/remote/proxy.c
> @@ -324,6 +324,7 @@ static void probe_pci_info(PCIDevice *dev, Error **errp)
>          set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>          break;
>      case PCI_BASE_CLASS_NETWORK:
> +    case PCI_BASE_CLASS_WIRELESS:
>          set_bit(DEVICE_CATEGORY_NETWORK, dc->categories);
>          break;
>      case PCI_BASE_CLASS_INPUT:
> 

Applied to my trivial-patches branch.

Thanks,
Laurent