[v1] iotests: update environment and linting configuration

[PATCH 0/6] iotests: update environment and linting configuration

John Snow posted 6 patches 2 years, 7 months ago

Diff against v2
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210923001625.3996451-1-jsnow@redhat.com

Maintainers: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>

There is a newer version of this series

tests/qemu-iotests/235                        |  2 -
tests/qemu-iotests/297                        | 50 ++++++++-----------
tests/qemu-iotests/300                        |  7 ++-
tests/qemu-iotests/iotests.py                 |  2 -
tests/qemu-iotests/pylintrc                   |  6 ++-
tests/qemu-iotests/testenv.py                 | 35 ++++++++++---
tests/qemu-iotests/testrunner.py              |  7 +--
tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++++++++++--------
tests/qemu-iotests/tests/mirror-top-perms     | 12 ++---
9 files changed, 95 insertions(+), 76 deletions(-)

Expand all Fold all

[PATCH 0/6] iotests: update environment and linting configuration

Posted by John Snow 2 years, 7 months ago

GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt1
CI: https://gitlab.com/jsnow/qemu/-/pipelines/375630185

This series partially supersedes:
  [PATCH v3 00/16] python/iotests: Run iotest linters during Python CI'

Howdy, this is good stuff we want even if we aren't yet in agreement
about the best way to run iotest 297 from CI.

- Update linting config to tolerate pylint 2.11.1
- Eliminate sys.path hacking in individual test files
- make mypy execution in test 297 faster

The rest of the actual "run at CI time" stuff can get handled separately
and later pending some discussion on the other series.

--js

John Snow (6):
  iotests: add 'qemu' package location to PYTHONPATH in testenv
  iotests: add warning for rogue 'qemu' packages
  iotests/linters: check mypy files all at once
  iotests/mirror-top-perms: Adjust imports
  iotests/migrate-bitmaps-test: delint
  iotests: Update for pylint 2.11.1

 tests/qemu-iotests/235                        |  2 -
 tests/qemu-iotests/297                        | 50 ++++++++-----------
 tests/qemu-iotests/300                        |  7 ++-
 tests/qemu-iotests/iotests.py                 |  2 -
 tests/qemu-iotests/pylintrc                   |  6 ++-
 tests/qemu-iotests/testenv.py                 | 35 ++++++++++---
 tests/qemu-iotests/testrunner.py              |  7 +--
 tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++++++++++--------
 tests/qemu-iotests/tests/mirror-top-perms     | 12 ++---
 9 files changed, 95 insertions(+), 76 deletions(-)

-- 
2.31.1

Re: [PATCH 0/6] iotests: update environment and linting configuration

Posted by Kevin Wolf 2 years, 7 months ago

Am 23.09.2021 um 02:16 hat John Snow geschrieben:
> GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt1
> CI: https://gitlab.com/jsnow/qemu/-/pipelines/375630185
> 
> This series partially supersedes:
>   [PATCH v3 00/16] python/iotests: Run iotest linters during Python CI'
> 
> Howdy, this is good stuff we want even if we aren't yet in agreement
> about the best way to run iotest 297 from CI.
> 
> - Update linting config to tolerate pylint 2.11.1
> - Eliminate sys.path hacking in individual test files
> - make mypy execution in test 297 faster
> 
> The rest of the actual "run at CI time" stuff can get handled separately
> and later pending some discussion on the other series.

Patch 2 seems to need some more work.

The rest is: Reviewed-by: Kevin Wolf <kwolf@redhat.com>