avocado_qemu: small fixes and tweaks

[PATCH 0/6] avocado_qemu: small fixes and tweaks

Posted by Willian Rampazzo 4 years, 4 months ago

Standardize the super() calls according to PEP3135; fix import order based on
isort; fix and tweak the ssh `connect` method; explicitly return None on
`pick_default_qemu_bin` function to avoid linters R1710; and fix inheritance
order on `LinuxTest` to avoid future problems.

Note: borrowed https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05117.html
      for completeness.

Cleber Rosa (1):
  Acceptance Tests: add standard clean up at test tearDown()

Willian Rampazzo (5):
  avocado_qemu: standardize supper() call following PEP3135
  avocado_qemu: fix import module based on isort
  avocado_qemu: tweak ssh connect method
  avocado_qemu: explicitly return None to avoid R1710
  avocado_qemu: fix inheritance order on LinuxTest class

 tests/acceptance/avocado_qemu/__init__.py | 30 +++++++++--------------
 1 file changed, 12 insertions(+), 18 deletions(-)

-- 
2.31.1

Re: [PATCH 0/6] avocado_qemu: small fixes and tweaks

Posted by Philippe Mathieu-Daudé 4 years, 4 months ago

On 9/20/21 22:49, Willian Rampazzo wrote:
> Standardize the super() calls according to PEP3135; fix import order based on
> isort; fix and tweak the ssh `connect` method; explicitly return None on
> `pick_default_qemu_bin` function to avoid linters R1710; and fix inheritance
> order on `LinuxTest` to avoid future problems.
> 
> Note: borrowed https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05117.html
>       for completeness.
> 
> Cleber Rosa (1):
>   Acceptance Tests: add standard clean up at test tearDown()
> 
> Willian Rampazzo (5):
>   avocado_qemu: standardize supper() call following PEP3135
>   avocado_qemu: fix import module based on isort
>   avocado_qemu: tweak ssh connect method
>   avocado_qemu: explicitly return None to avoid R1710
>   avocado_qemu: fix inheritance order on LinuxTest class

Thanks, applied to my integration-testing tree.

Re: [PATCH 0/6] avocado_qemu: small fixes and tweaks

Posted by Philippe Mathieu-Daudé 4 years, 4 months ago

On 9/20/21 22:49, Willian Rampazzo wrote:
> Standardize the super() calls according to PEP3135; fix import order based on
> isort; fix and tweak the ssh `connect` method; explicitly return None on
> `pick_default_qemu_bin` function to avoid linters R1710; and fix inheritance
> order on `LinuxTest` to avoid future problems.
> 
> Note: borrowed https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05117.html
>       for completeness.
> 
> Cleber Rosa (1):
>   Acceptance Tests: add standard clean up at test tearDown()
> 
> Willian Rampazzo (5):
>   avocado_qemu: standardize supper() call following PEP3135
>   avocado_qemu: fix import module based on isort
>   avocado_qemu: tweak ssh connect method
>   avocado_qemu: explicitly return None to avoid R1710
>   avocado_qemu: fix inheritance order on LinuxTest class

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>