[PATCH] travis.yml: Remove the "Release tarball" job

Thomas Huth posted 1 patch 2 years, 7 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20210917094826.466047-1-thuth@redhat.com
Maintainers: Willian Rampazzo <willianr@redhat.com>, "Philippe Mathieu-Daudé" <f4bug@amsat.org>, "Alex Bennée" <alex.bennee@linaro.org>, Thomas Huth <thuth@redhat.com>, Wainer dos Santos Moschetta <wainersm@redhat.com>
.travis.yml | 23 -----------------------
1 file changed, 23 deletions(-)
[PATCH] travis.yml: Remove the "Release tarball" job
Posted by Thomas Huth 2 years, 7 months ago
This is a leftover from the days when we were using Travis excessively,
but since x86 jobs are not really usable there anymore, this job has
likely never been used since many months. Let's simply remove it now.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .travis.yml | 23 -----------------------
 1 file changed, 23 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 0faddf7b4e..41010ebe6b 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -305,26 +305,3 @@ jobs:
         - CONFIG="--disable-containers --disable-tcg --enable-kvm
                   --disable-tools --host-cc=clang --cxx=clang++"
         - UNRELIABLE=true
-
-    # Release builds
-    # The make-release script expect a QEMU version, so our tag must start with a 'v'.
-    # This is the case when release candidate tags are created.
-    - name: "Release tarball"
-      if: tag IS present AND tag =~ /^v\d+\.\d+(\.\d+)?(-\S*)?$/
-      env:
-        # We want to build from the release tarball
-        - BUILD_DIR="release/build/dir" SRC_DIR="../../.."
-        - BASE_CONFIG="--prefix=$PWD/dist"
-        - CONFIG="--target-list=x86_64-softmmu,aarch64-softmmu,armeb-linux-user,ppc-linux-user"
-        - TEST_CMD="make install -j${JOBS}"
-        - QEMU_VERSION="${TRAVIS_TAG:1}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
-      script:
-        - make -C ${SRC_DIR} qemu-${QEMU_VERSION}.tar.bz2
-        - ls -l ${SRC_DIR}/qemu-${QEMU_VERSION}.tar.bz2
-        - tar -xf ${SRC_DIR}/qemu-${QEMU_VERSION}.tar.bz2 && cd qemu-${QEMU_VERSION}
-        - mkdir -p release-build && cd release-build
-        - ../configure ${BASE_CONFIG} ${CONFIG} || { cat config.log meson-logs/meson-log.txt && exit 1; }
-        - make install
-  allow_failures:
-    - env: UNRELIABLE=true
-- 
2.27.0


Re: [PATCH] travis.yml: Remove the "Release tarball" job
Posted by Daniel P. Berrangé 2 years, 7 months ago
On Fri, Sep 17, 2021 at 11:48:26AM +0200, Thomas Huth wrote:
> This is a leftover from the days when we were using Travis excessively,
> but since x86 jobs are not really usable there anymore, this job has
> likely never been used since many months. Let's simply remove it now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .travis.yml | 23 -----------------------
>  1 file changed, 23 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


Re: [PATCH] travis.yml: Remove the "Release tarball" job
Posted by Alex Bennée 2 years, 7 months ago
Thomas Huth <thuth@redhat.com> writes:

> This is a leftover from the days when we were using Travis excessively,
> but since x86 jobs are not really usable there anymore, this job has
> likely never been used since many months. Let's simply remove it now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Queued to testing/next, thanks.

-- 
Alex Bennée

Re: [PATCH] travis.yml: Remove the "Release tarball" job
Posted by Philippe Mathieu-Daudé 2 years, 7 months ago
Le ven. 17 sept. 2021 11:48, Thomas Huth <thuth@redhat.com> a écrit :

> This is a leftover from the days when we were using Travis excessively,
> but since x86 jobs are not really usable there anymore, this job has
> likely never been used since many months. Let's simply remove it now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .travis.yml | 23 -----------------------
>  1 file changed, 23 deletions(-)
>

Do we have the equivalent job on GitLab?

>
Re: [PATCH] travis.yml: Remove the "Release tarball" job
Posted by Thomas Huth 2 years, 7 months ago
On 17/09/2021 13.25, Philippe Mathieu-Daudé wrote:
> Le ven. 17 sept. 2021 11:48, Thomas Huth <thuth@redhat.com 
> <mailto:thuth@redhat.com>> a écrit :
> 
>     This is a leftover from the days when we were using Travis excessively,
>     but since x86 jobs are not really usable there anymore, this job has
>     likely never been used since many months. Let's simply remove it now.
> 
>     Signed-off-by: Thomas Huth <thuth@redhat.com <mailto:thuth@redhat.com>>
>     ---
>       .travis.yml | 23 -----------------------
>       1 file changed, 23 deletions(-)
> 
> Do we have the equivalent job on GitLab?

I'm not aware of any. But since this job was only running on v* tags anyway, 
it likely does not make much sense to translate it 1:1 to a gitlab job. But 
maybe Michael could suggest something similar if it's helpful for making 
sure the release tarballs do no regress?

  Thomas


Re: [PATCH] travis.yml: Remove the "Release tarball" job
Posted by Philippe Mathieu-Daudé 2 years, 7 months ago
On 9/17/21 1:42 PM, Thomas Huth wrote:
> On 17/09/2021 13.25, Philippe Mathieu-Daudé wrote:
>> Le ven. 17 sept. 2021 11:48, Thomas Huth <thuth@redhat.com
>> <mailto:thuth@redhat.com>> a écrit :
>>
>>     This is a leftover from the days when we were using Travis
>> excessively,
>>     but since x86 jobs are not really usable there anymore, this job has
>>     likely never been used since many months. Let's simply remove it now.
>>
>>     Signed-off-by: Thomas Huth <thuth@redhat.com
>> <mailto:thuth@redhat.com>>
>>     ---
>>       .travis.yml | 23 -----------------------
>>       1 file changed, 23 deletions(-)
>>
>> Do we have the equivalent job on GitLab?
> 
> I'm not aware of any. But since this job was only running on v* tags
> anyway, it likely does not make much sense to translate it 1:1 to a
> gitlab job. But maybe Michael could suggest something similar if it's
> helpful for making sure the release tarballs do no regress?

This is why we added this job in the first place... Peter tagged a
released then Michael got issues when generating the archive.